Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 816060 - app-portage/portage-utils-0.92: qmerge SUBSLOT default handling differs from doc & emerge
Summary: app-portage/portage-utils-0.92: qmerge SUBSLOT default handling differs from ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-03 14:42 UTC by Barnabás Virágh
Modified: 2021-12-21 10:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tree.c default subslot handling fix (tree.c-default-subslot-fix.patch,878 bytes, patch)
2021-10-03 14:42 UTC, Barnabás Virágh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Barnabás Virágh 2021-10-03 14:42:02 UTC
According to documentation: "If an ebuild does not explicitly declare a sub-slot, the regular slot is used as the value of the sub-slot by default."

However, in the code it always defaults to NULL.

This also prevents finding the correct dependency if it is defined in package RDEPEND, fe.: sys-apps/util-linux:0/0=, where sys-apps/util-linux only defines SLOT=0

Reproducible: Always

Steps to Reproduce:
1. qmerge -pv sys-devel/gcc:10/10

Actual Results:  
qmerge: nothing found for sys-devel/gcc:10/10

Expected Results:  
[R] sys-devel/gcc-10.3.0-r2
*** unmerging sys-devel/gcc-10.3.0-r2
>>> sys-devel/gcc-10.3.0-r2
Comment 1 Barnabás Virágh 2021-10-03 14:42:43 UTC
Created attachment 742671 [details, diff]
tree.c default subslot handling fix
Comment 2 Fabian Groffen gentoo-dev 2021-10-03 17:48:10 UTC
Do you have a PMS reference for this?  I'm fine with the change, but just in case you still have it, else I'll have to find it myself.
Comment 3 Barnabás Virágh 2021-10-03 19:11:34 UTC
https://wiki.gentoo.org/wiki/Package_sets

You can also test how emerge behaves:
emerge --pretend sys-devel/gcc:10/10
emerge --pretend sys-devel/gcc:10/0
emerge --pretend sys-devel/gcc:10/11
emerge --pretend sys-devel/gcc:10

etc... :)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-03 19:59:47 UTC
(In reply to Fabian Groffen from comment #2)
> Do you have a PMS reference for this?  I'm fine with the change, but just in
> case you still have it, else I'll have to find it myself.

https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-610007.2
Comment 5 Fabian Groffen gentoo-dev 2021-10-04 06:02:35 UTC
Thanks Sam, that's exactly what I was looking for, so I can add that to the code as reference as to why we do such behaviour.
Comment 6 Larry the Git Cow gentoo-dev 2021-10-04 06:28:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=48ca7946e74ed6c1c065589c50327948a41c25b7

commit 48ca7946e74ed6c1c065589c50327948a41c25b7
Author:     Barnabás Virágh <cyborgyn@gmail.com>
AuthorDate: 2021-10-04 06:09:12 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2021-10-04 06:09:12 +0000

    libq/tree: properly set SUBSLOT value when absent (PMS 7.2)
    
    Bug: https://bugs.gentoo.org/816060
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 libq/tree.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Comment 7 Larry the Git Cow gentoo-dev 2021-12-21 10:25:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e74e1d6c4bf1db571db1cec13356ffbe10ba56f

commit 7e74e1d6c4bf1db571db1cec13356ffbe10ba56f
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2021-12-21 10:23:54 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2021-12-21 10:25:33 +0000

    app-portage/portage-utils-0.93: version bump
    
    Closes: https://bugs.gentoo.org/815622
    Closes: https://bugs.gentoo.org/816033
    Closes: https://bugs.gentoo.org/816060
    Closes: https://bugs.gentoo.org/829579
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 app-portage/portage-utils/Manifest                 |  1 +
 .../portage-utils/portage-utils-0.93.ebuild        | 67 ++++++++++++++++++++++
 2 files changed, 68 insertions(+)