Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 815913 - app-emulation/vice is missing midi support
Summary: app-emulation/vice is missing midi support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-03 07:29 UTC by Ville Oikarinen
Modified: 2021-10-04 07:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ville Oikarinen 2021-10-03 07:29:33 UTC
app-emulation/vice-3.4_p38553 doesn't support (among others) command line option "-midi" anymore.

Please see https://sourceforge.net/p/vice-emu/bugs/1573/ for an explanation.

The vice team has now disabled midi support by default. There may be other functionality that is currently missing, too. (The idea is to get more "reproducible" builds this way.)

Please update the ebuild to add option "--enable-midi" when building. Perhaps this can depend on the midi use flag?

It would be nice to get midi support back ASAP, and other possibly missing features can be added later, when identified.
Comment 1 Ionen Wolkens gentoo-dev 2021-10-03 08:07:19 UTC
Hm, as far as I can tell midi doesn't need any external libraries, so I see no reason not to just enable this by default without USE (I've added a USE for cpuhistory despite that before, but that was because it could hurt performance).

I'll add it to 3.5 in ~testing which is due to replace 3.4 in stable.

Feedback on what else needs to be done is welcome because I never used vice beside minor testing (I've only done minor maintenance on 3.5).
Comment 2 Ville Oikarinen 2021-10-03 08:10:42 UTC
Ionen Wolkens, yes, from the source it can be seen that vice uses alsa midi. And alsa is anyway a dependency for audio, so midi support won't add any new dependencies.
Comment 3 Ionen Wolkens gentoo-dev 2021-10-03 08:28:09 UTC
(In reply to Ville Oikarinen from comment #2)
> Ionen Wolkens, yes, from the source it can be seen that vice uses alsa midi.
> And alsa is anyway a dependency for audio, so midi support won't add any new
> dependencies.
alsa is optional for it actually, it can use OSS with USE=-alsa

So an unconditional --enable-midi seems right.
Comment 4 Ionen Wolkens gentoo-dev 2021-10-03 08:32:24 UTC
(In reply to Ionen Wolkens from comment #3)
> (In reply to Ville Oikarinen from comment #2)
> > Ionen Wolkens, yes, from the source it can be seen that vice uses alsa midi.
> > And alsa is anyway a dependency for audio, so midi support won't add any new
> > dependencies.
> alsa is optional for it actually, it can use OSS with USE=-alsa
> 
> So an unconditional --enable-midi seems right.
Well, I guess I could put it behind oss or alsa being enabled, given it won't make sense otherwise even if it builds.
Comment 5 Ville Oikarinen 2021-10-03 10:12:55 UTC
(In reply to Ionen Wolkens from comment #4)
> Well, I guess I could put it behind oss or alsa being enabled, given it
> won't make sense otherwise even if it builds.

Sound logical. Eagerly waiting to test it. :)
Comment 6 Ionen Wolkens gentoo-dev 2021-10-03 10:43:43 UTC
(In reply to Ville Oikarinen from comment #5)
> (In reply to Ionen Wolkens from comment #4)
> > Well, I guess I could put it behind oss or alsa being enabled, given it
> > won't make sense otherwise even if it builds.
> 
> Sound logical. Eagerly waiting to test it. :)
Meanwhile you can build vice-3.5 with 

EXTRA_ECONF=--enable-midi emerge vice

I'm reviewing deps a bit while here first.
Comment 7 Ville Oikarinen 2021-10-03 10:58:07 UTC
(In reply to Ionen Wolkens from comment #6)
> Meanwhile you can build vice-3.5 with 
> 
> EXTRA_ECONF=--enable-midi emerge vice

Wow, that was super helpful. Now I have midi back within the same day. Many thanks!
Comment 8 Larry the Git Cow gentoo-dev 2021-10-03 11:19:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b47efb343930139d4eb48eeea969c02988b503e

commit 3b47efb343930139d4eb48eeea969c02988b503e
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-10-03 09:16:32 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-10-03 11:17:14 +0000

    app-emulation/vice: enable midi support, tighten deps
    
    Midi support can work either through alsa or oss,
    so enable if one of these is set (no extra deps).
    
    While revbumping for this, adjusted deps a bit
    (notably fails to build without [X] on gtk+:3).
    
    Also removed IUSE=ipv6 (enabled by default).
    
    Not moving to EAPI-8 yet given econf tries to pass
    an unrecognized --disable-static (bug #814380)
    
    Closes: https://bugs.gentoo.org/815913
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../vice/{vice-3.5.ebuild => vice-3.5-r1.ebuild}   | 58 +++++++++++-----------
 1 file changed, 28 insertions(+), 30 deletions(-)
Comment 9 Ionen Wolkens gentoo-dev 2021-10-03 11:23:07 UTC
It's in vice-3.5-r1 now, please report if you have any issue with 3.5 in general -- will be looking at marking it stable in a few days if no new issues (should've been stable long ago, but giving it some time due to changes).
Comment 10 Ville Oikarinen 2021-10-04 07:01:08 UTC
(In reply to Ionen Wolkens from comment #9)
> It's in vice-3.5-r1 now, please report if you have any issue

I can verify that midi, audio and some simple graphics work. I haven't tested anything beyond my simple midi usecase, but this is perfect for me. Thank you for the quick fix!