Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 815658 - app-emulation/docker-cli: wrong version with `docker --version`
Summary: app-emulation/docker-cli: wrong version with `docker --version`
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-10-01 14:00 UTC by Mathieu Tortuyaux
Modified: 2021-10-02 04:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Tortuyaux 2021-10-01 14:00:40 UTC
Hi,

In the current version of `=app-emulation/docker-cli-20.10.8`, the version returned by the CLI is not correct:

```
$ docker --version
Docker version 20.10.0-dev, build 311fbfaf7d
```

The commit is good but not the version.

In the ebuild, we build using the version from the `VERSION` file which does not seem reliable and maintained by `docker/cli` repository: https://github.com/docker/cli/blob/v20.10.8/VERSION

We should rely directly on the `${PV}` version.
Comment 1 Larry the Git Cow gentoo-dev 2021-10-02 04:05:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a3655d676cb95bf0be1dc039c20349bb3d74ce6

commit 0a3655d676cb95bf0be1dc039c20349bb3d74ce6
Author:     Mathieu Tortuyaux <mtortuyaux@microsoft.com>
AuthorDate: 2021-10-01 14:14:34 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2021-10-02 04:03:47 +0000

    app-emulation/docker-cli: use `${PV}` for CLI version
    
    Upstream isn't updating the file regularly, so use ${PV}.
    
    Closes: https://bugs.gentoo.org/815658
    Closes: https://github.com/gentoo/gentoo/pull/22457
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 app-emulation/docker-cli/docker-cli-20.10.7.ebuild | 2 +-
 app-emulation/docker-cli/docker-cli-20.10.8.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)