Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 815469 - sys-fs/zfs: needs <sys-apps/coreutils-9.0 due to SEEK_DATA/SEEK_HOLE bug
Summary: sys-fs/zfs: needs <sys-apps/coreutils-9.0 due to SEEK_DATA/SEEK_HOLE bug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL: https://github.com/openzfs/zfs/issues...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-30 17:16 UTC by HougeLangley
Modified: 2024-05-03 04:53 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description HougeLangley 2021-09-30 17:16:11 UTC
sys-apps/coreutils:0

  (sys-apps/coreutils-9.0-r1:0/0::gentoo, ebuild scheduled for merge) USE="acl nls (split-usr) xattr -caps -gmp -hostname -kill -multicall (-selinux) -static -test -vanilla" ABI_X86="(64)" conflicts with
    <sys-apps/coreutils-9 required by (sys-fs/zfs-9999:0/5::gentoo, installed) USE="nls pam rootfs (split-usr) -custom-cflags -debug -dist-kernel (-kernel-builtin) -minimal -python -test-suite" ABI_X86="(64)" PYTHON_TARGETS="python3_9 -python3_10 -python3_8"

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-09-30 17:24:26 UTC
# temporary block new coreutils
# https://github.com/openzfs/zfs/issues/11900
RDEPEND+="
    <sys-apps/coreutils-9
"

issue is still open
Comment 2 Georgy Yakovlev archtester gentoo-dev 2021-10-05 19:47:04 UTC
we added a blocker on new versions, because using cp may lead to data loss due to weird interactions between zfs and copy_file_range in new coreutils.

blocker will remain until problem is solved.
Comment 3 Larry the Git Cow gentoo-dev 2021-11-07 23:59:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c97da7804003db7be32a3c696f930ca5555ba24

commit 7c97da7804003db7be32a3c696f930ca5555ba24
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-11-07 23:01:06 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-11-07 23:57:40 +0000

    sys-fs/zfs: revbump 2.1.1, add patch and dist-kernel version limit
    
    We don't really need patch in userspace package, but
    patch also installs tests for test-suite and what's why we include it.
    
    also remove coreutils blocker
    
    Bug: https://bugs.gentoo.org/815469
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-fs/zfs/files/2.1.1-fix-lseek-mmap.patch | 594 ++++++++++++++++++++++++++++
 sys-fs/zfs/zfs-2.1.1-r3.ebuild              | 298 ++++++++++++++
 2 files changed, 892 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2021-11-08 01:52:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36c01762fd547da25227dec8ba173fc8bc10a545

commit 36c01762fd547da25227dec8ba173fc8bc10a545
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-11-08 01:49:23 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-11-08 01:52:13 +0000

    sys-fs/zfs: re-introduce coreutils-9 blocker to 2.1.1
    
    Seems corruption still happening with coreutils-9 even with the SEEK
    patch applied
    
    Bug: https://bugs.gentoo.org/815469
    https://github.com/openzfs/zfs/issues/11900
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-fs/zfs/{zfs-2.1.1-r3.ebuild => zfs-2.1.1-r4.ebuild} | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2021-11-08 06:09:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd5b037d61a1c58a59ad989992321c4aae578e90

commit fd5b037d61a1c58a59ad989992321c4aae578e90
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-08 06:08:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-08 06:08:58 +0000

    sys-fs/zfs: yank SEEK_HOLE patch for now
    
    Preliminary investigation suggests this patch (and earlier iterations)
    may introduce regressions. Let's yank it for now while we continue
    the investigation with upstream.
    
    Bug: https://bugs.gentoo.org/815469
    See: https://github.com/openzfs/zfs/issues/11900
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/zfs/files/2.1.1-fix-lseek-mmap.patch        | 594 ---------------------
 .../{zfs-2.1.1-r4.ebuild => zfs-2.1.1-r5.ebuild}   |   1 -
 2 files changed, 595 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9fb275f656de639e25acc9497b70b4cae593d35d

commit 9fb275f656de639e25acc9497b70b4cae593d35d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-08 06:07:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-08 06:07:13 +0000

    sys-fs/zfs-kmod: yank SEEK_HOLE patch for now
    
    Preliminary investigation suggests this patch (and earlier iterations)
    may introduce regressions. Let's yank it for now while we continue
    the investigation with upstream.
    
    Bug: https://bugs.gentoo.org/815469
    See: https://github.com/openzfs/zfs/issues/11900
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/zfs-kmod/files/2.1.1-fix-lseek-mmap.patch   | 594 ---------------------
 ...od-2.1.1-r1.ebuild => zfs-kmod-2.1.1-r2.ebuild} |   2 -
 2 files changed, 596 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2021-11-11 02:22:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95c250a3f3986b2bc2091dd3981ff1e1d3de0c73

commit 95c250a3f3986b2bc2091dd3981ff1e1d3de0c73
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-11-11 02:03:18 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-11-11 02:10:52 +0000

    sys-fs/zfs-kmod: revbump 2.1.1 with SEEK/mmap/dnode fixes
    
    take two
    
    Bug: https://bugs.gentoo.org/815469
    https://github.com/openzfs/zfs/issues/11900
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 .../zfs-kmod/files/2.1.1-SEEK_DATA-SEEK_HOLE.patch | 594 +++++++++++++++++++++
 .../files/2.1.1-restore-dirty-dnode-logic.patch    |  31 ++
 sys-fs/zfs-kmod/zfs-kmod-2.1.1-r3.ebuild           | 210 ++++++++
 3 files changed, 835 insertions(+)
Comment 7 Georgy Yakovlev archtester gentoo-dev 2021-11-11 02:30:20 UTC
we decided to leave blocker for a bit more time to avoid scenario where user runs a world upgrade, upgrades to zfs which unblock coreutils-9 without being rebooted to fixed version of zfs-kmod.

so please update to zfs-kmod-2.1.1-r3 and reboot.
fix for 2.0.6 is in progress, but same logic applies. reboot to fixed version first, you'll get unblocked coreutils later.
Comment 8 Larry the Git Cow gentoo-dev 2021-11-11 03:13:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0372bbf13c029d77b6e3f2abe538c06b1648b5b2

commit 0372bbf13c029d77b6e3f2abe538c06b1648b5b2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-11 03:12:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-11 03:12:23 +0000

    sys-apps/coreutils: add check for running zfs(-kmod) version in coreutils 9
    
    We need to make sure people reboot to avoid data corruption, not just
    upgrade the module but fail to restart.
    
    Bug: https://bugs.gentoo.org/815469
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/coreutils/coreutils-9.0-r1.ebuild | 37 ++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
Comment 9 HougeLangley 2021-11-11 12:05:40 UTC
May be add zfs(kmod)-9999 in coreutils ebuild. I will test in system.

Would you like to merge these packages? [Yes/No]
>>> Verifying ebuild manifests
>>> Running pre-merge checks for sys-apps/coreutils-9.0-r1
 * Checking for compatible ZFS version
 * ERROR: sys-apps/coreutils-9.0-r1::gentoo failed (pretend phase):
 *   __eapi7_ver_compare: invalid version: 2.1.99-511_gde198f2d9
 *
 * Call stack:
 *                 ebuild.sh, line 127:  Called pkg_pretend
 *   coreutils-9.0-r1.ebuild, line  86:  Called ver_test '2.1.99-511_gde198f2d9' '-lt' '2.1.1-r3'
 *        eapi7-ver-funcs.sh, line 189:  Called __eapi7_ver_compare '2.1.99-511_gde198f2d9' '2.1.1-r3'
 *        eapi7-ver-funcs.sh, line  99:  Called die
 * The specific snippet of code:
 *   	[[ ${va} =~ ${re} ]] || die "${FUNCNAME}: invalid version: ${va}"
Comment 10 Georgy Yakovlev archtester gentoo-dev 2021-11-11 19:06:49 UTC
I've added check only for versions <9999 today in 
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3f1f1c0240f6b4cfe20673b0dece697e9287ee1
Comment 11 HougeLangley 2021-11-12 01:37:41 UTC
[09:33:15] [~] ❱❱❱ zfs --version
zfs-2.1.99-526_gc9d62d135
zfs-kmod-2.1.99-526_gc9d62d135
[09:33:17] [cost 0.014s] zfs --version

[09:33:36] [~] ❱❱❱ doas emerge -s sys-apps/coreutils

[ Results for search key : sys-apps/coreutils ]
Searching...

*  sys-apps/coreutils
      Latest version available: 9.0-r1
      Latest version installed: 9.0-r1
      Size of files: 5,487 KiB
      Homepage:      https://www.gnu.org/software/coreutils/
      Description:   Standard GNU utilities (chmod, cp, dd, ls, sort, tr, head, wc, who,...)
      License:       GPL-3

I have been test sys-apps/coreutils-9.0-r1 in my system build successed. Rebuild kernel and zfs(-kmod)-9999 no problem.I think this bug have been solved. Just need more test in future.

Thanks, you guys.
Comment 12 Georgy Yakovlev archtester gentoo-dev 2021-11-14 06:23:59 UTC
Let's not close it yet, we still have old ebuilds that block coreutils-9

zfs-kmod-9999 removed blocker indeed, git master of zfs contains required fixes.

we'll close the bug after blockers are gone
Comment 13 Georgy Yakovlev archtester gentoo-dev 2021-12-23 22:29:15 UTC
zfs-2.0.7 added which should unblock coreutils-9

will be stabilized soon
Comment 14 Larry the Git Cow gentoo-dev 2021-12-26 22:35:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86408dcfd657a851da226323d2ad210baaea7ec9

commit 86408dcfd657a851da226323d2ad210baaea7ec9
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-12-26 22:29:17 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-12-26 22:35:03 +0000

    sys-fs/zfs-kmod: drop 2.0.6
    
    Closes: https://bugs.gentoo.org/815469
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-fs/zfs-kmod/Manifest              |   2 -
 sys-fs/zfs-kmod/zfs-kmod-2.0.6.ebuild | 219 ----------------------------------
 2 files changed, 221 deletions(-)
Comment 15 Larry the Git Cow gentoo-dev 2023-11-22 19:15:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6a9c7f40ffb7f393a707b6d0face1c2f39d3901

commit d6a9c7f40ffb7f393a707b6d0face1c2f39d3901
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-11-22 19:12:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-22 19:15:00 +0000

    profiles: mask buggy zfs-2.2.0
    
    Further bugs with CoW via copy_file_range (bug #917224, https://github.com/openzfs/zfs/issues/15526).
    The issue is very similar to bug #815469.
    
    ZFS 2.2.1 has a workaround but if you haven't already upgraded your pool to
    use the new block cloning feature, consider using <zfs-2.2 for now.
    
    Bug: https://github.com/openzfs/zfs/issues/15526
    Bug: https://bugs.gentoo.org/815469
    Bug: https://bugs.gentoo.org/91722
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 8 ++++++++
 1 file changed, 8 insertions(+)
Comment 16 Larry the Git Cow gentoo-dev 2024-05-03 04:53:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33c9e9ebd07e6d158e6064a267db3876f3a1f130

commit 33c9e9ebd07e6d158e6064a267db3876f3a1f130
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-03 04:52:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-03 04:53:35 +0000

    sys-fs/zfs-kmod: add 2.2.4
    
    This release contains a fix for https://github.com/openzfs/zfs/issues/15933.
    
    Closes: https://bugs.gentoo.org/928518
    Bug: https://bugs.gentoo.org/815469
    Bug: https://bugs.gentoo.org/917224
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/zfs-kmod/Manifest              |   2 +
 sys-fs/zfs-kmod/zfs-kmod-2.2.4.ebuild | 217 ++++++++++++++++++++++++++++++++++
 2 files changed, 219 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54cd669fae4c965242510044481ac5df0beaaba0

commit 54cd669fae4c965242510044481ac5df0beaaba0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-03 04:49:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-03 04:53:34 +0000

    sys-fs/zfs: add 2.2.4
    
    This release contains a fix for https://github.com/openzfs/zfs/issues/15933.
    
    Closes: https://bugs.gentoo.org/928518
    Bug: https://bugs.gentoo.org/815469
    Bug: https://bugs.gentoo.org/917224
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-fs/zfs/Manifest         |   2 +
 sys-fs/zfs/zfs-2.2.4.ebuild | 308 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 310 insertions(+)