Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 813483 - >sys-apps/openrc-0.44: new src_configure() causes regression and build failure with audit and pam_misc
Summary: >sys-apps/openrc-0.44: new src_configure() causes regression and build failur...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-17 17:23 UTC by Ethan Carr
Modified: 2021-09-29 04:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
relevant build.log (openrc-0.44.4.build.log,52.99 KB, text/x-log)
2021-09-17 17:23 UTC, Ethan Carr
Details
0001-build-link-to-libpam_misc-and-audit.patch (0001-build-link-to-libpam_misc-and-audit.patch,946 bytes, text/x-diff)
2021-09-17 19:29 UTC, William Hubbs
Details
build.log result of applying patch 0001 (openrc-0.44.4.build.log,73.33 KB, text/x-log)
2021-09-18 01:57 UTC, Ethan Carr
Details
openrc-0.44.4 build.log 2021-09-20 (openrc-0.44.4.build.2021-09-20.log,80.51 KB, text/plain)
2021-09-20 18:47 UTC, Eddie Chapman
Details
Patch that lets 0.44.5 actually build with pam and selinux (fix.patch,1.27 KB, patch)
2021-09-29 04:52 UTC, Benjamin Southall
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ethan Carr 2021-09-17 17:23:29 UTC
Created attachment 739719 [details]
relevant build.log

openrc-0.43.5 compiles fine. However, openrc-0.44.4 fails as it forgets to link libaudit. In a similar spirit while I was tinkering, I noticed the ebuild also fails to link libpam_misc, which causes an error as well.

I suspect that the use of meson_src_configure which is new in the ebuild as of openrc-0.44 is the reason why this is happening -- perhaps there is a typo or something needs to be tweaked.

build.log is attached
Comment 1 William Hubbs gentoo-dev 2021-09-17 19:29:27 UTC
Created attachment 739728 [details]
0001-build-link-to-libpam_misc-and-audit.patch

Can you apply this patch locally and let me know if it fixes the build
for you?

Thanks,

William
Comment 2 Ethan Carr 2021-09-18 01:57:45 UTC
Created attachment 739737 [details]
build.log result of applying patch 0001

No dice yet --

Might be a red herring; I noticed early on in the log it spots libaudit as a runtime dependency and pam and pam_misc as libraries. It then forgets to link libaudit.so (this error happens before the pam_misc error happened historically when I messed with things, so I don't know if the pam issue is fixed yet)

I've only ever used autotools and microsoft products, not meson, so I don't know what I'm talking about here -- though it catches my eye.
Comment 3 Larry the Git Cow gentoo-dev 2021-09-18 20:32:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef393aa67b39b67ca5e804a5a74db3771585aec4

commit ef393aa67b39b67ca5e804a5a74db3771585aec4
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2021-09-18 20:31:50 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2021-09-18 20:32:28 +0000

    sys-apps/openrc: fix selinux and audit build
    
    Bug: https://bugs.gentoo.org/813483
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 .../openrc/files/openrc-0.44.4-fix-build.patch     | 36 ++++++++++++++++++++++
 sys-apps/openrc/openrc-0.44.4.ebuild               |  4 +++
 2 files changed, 40 insertions(+)
Comment 4 William Hubbs gentoo-dev 2021-09-18 20:35:14 UTC
Please drop your patch and attempt to emerge openrc 0.44.4 again.
I know this patch fixes the audit issue, but I need to know if it works
for pam_misc as well.
Please report back.

Thanks,

William
Comment 5 Eddie Chapman 2021-09-20 18:47:44 UTC
Created attachment 740403 [details]
openrc-0.44.4 build.log 2021-09-20

I'm having the same problem. Been unable to build any 0.44.x release yet on my SELinux system, including the latest sys-apps/openrc-0.44.4

Attaching latest build.log, happy to try any patches.
Comment 6 jeremy mills 2021-09-21 19:37:30 UTC
(In reply to William Hubbs from comment #4)
> Please drop your patch and attempt to emerge openrc 0.44.4 again.
> I know this patch fixes the audit issue, but I need to know if it works
> for pam_misc as well.
> Please report back.
> 
> Thanks,
> 
> William

0.44.5 is now failing because it cant find the patch for 0.44.5 (patch doesnt exist  in the git tree either only patch for 0.44.4). are we still using this patch and it just not renamed yet? or possibly a mistake in the ebuild if we arent using it anymore? i can file a seperate bug report for this missing patch too if you prefer.
Comment 7 Larry the Git Cow gentoo-dev 2021-09-21 19:49:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c60ca59302d2dca0aa9ba3ab4ee1d10dbec4b110

commit c60ca59302d2dca0aa9ba3ab4ee1d10dbec4b110
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-09-21 19:49:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-09-21 19:49:12 +0000

    sys-apps/openrc: drop missing patch
    
    Closes: https://bugs.gentoo.org/813483
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/openrc/openrc-0.44.5.ebuild | 4 ----
 1 file changed, 4 deletions(-)
Comment 8 Benjamin Southall 2021-09-29 04:52:48 UTC
Created attachment 741819 [details, diff]
Patch that lets 0.44.5 actually build with pam and selinux

I found that openrc-0.44.5 wouldn't compile or install without the following patch.