Bug 812119 – dev-libs/jansson-2.14: stabilisation (was: dev-libs/jansson: library using unversioned symbols causing crashes/bugs)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Stanislav Ochotnicky 2021-09-08 07:35:44 UTC]

Jansson library symbol names clash with json-c and some time ago both projects merged changes to add versioning to their libs. However jansson has not had a release since then (over a year ago).

Missing symbols cause weird problems/crashes. For example in firewalld: github.com/firewalld/firewalld/issues/819

There is an upstream merged PR github.com/akheron/jansson/pull/540 which fixes the issue by adding versioning symbols. It would be good to add this to current jansson gentoo ebuilds to prevent bugs in apps linking with jansson.

Ideally of course upstream would release a new version which I asked about here:
github.com/akheron/jansson/issues/460



Reproducible: Always

Steps to Reproduce:
1. Run readelf -W -s -- /usr/lib64/libjansson.so

Actual Results:  
function names are not versioned (have no @<libjansson version>

Expected Results:  
Each symbol is versioned with something like "<symbol_name>@@libjansson.so.4"

Sorry for non-link links, new account...

[Comment 1 David Zero 2021-09-09 01:27:57 UTC]

I'll go ahead and ping him myself. If he doesn't cut a new version within a week, I'll create a revision with the required patches.

Naturally, as soon as I take the time to make the revision, *that's* when he'll decide to cut the new version.

[Comment 2 Sam James 2021-09-09 02:53:21 UTC]

(In reply to David Zero from comment #1)
> I'll go ahead and ping him myself. If he doesn't cut a new version within a
> week, I'll create a revision with the required patches.
> 
> Naturally, as soon as I take the time to make the revision, *that's* when
> he'll decide to cut the new version.

Thank you!

Note that this will require us to:
- add a subslot to jansson (you do this bit for the new revision or new version)
- revbump all consumers and add := to them (I'll do this when I merge the PR)

[Comment 3 David Zero 2021-09-09 21:18:29 UTC]

New release created: https://github.com/akheron/jansson/releases/tag/v2.14

Busy on a trip, but when I get back in a few days, I'll do a version bump.

[Comment 4 David Zero 2021-09-25 19:11:38 UTC]

https://github.com/gentoo/gentoo/commit/1f3776d1d8f7b1cbd8664024e2a062d48f6274ce

[Comment 5 Sam James 2021-09-25 19:21:50 UTC]

Let's reuse this bug for stabilisation in a little while (a few days at least).

[Comment 6 Sam James 2021-10-07 06:47:36 UTC]

Let's proceed.

[Comment 7 Sam James 2021-10-08 02:10:31 UTC]

amd64 done

[Comment 8 Sam James 2021-10-08 02:10:33 UTC]

x86 done

[Comment 9 Sam James 2021-10-08 02:10:35 UTC]

ppc done

[Comment 10 Sam James 2021-10-08 02:10:36 UTC]

ppc64 done

[Comment 11 Sam James 2021-10-10 00:33:32 UTC]

arm64 done

[Comment 12 Sam James 2021-10-10 00:33:34 UTC]

arm done

[Comment 13 Rolf Eike Beer 2021-10-14 13:57:20 UTC]

sparc done

[Comment 14 Rolf Eike Beer 2021-11-10 14:42:37 UTC]

hppa done, bug done