Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 810958 - kde-apps/okular-21.04.3-r1 proposal: make kwallet optional
Summary: kde-apps/okular-21.04.3-r1 proposal: make kwallet optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard: fixed in 21.08.1
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-29 20:14 UTC by Esteve Varela Colominas
Modified: 2021-12-20 15:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Esteve Varela Colominas 2021-08-29 20:14:55 UTC
I use okular outside of KDE, and I don't need any functionality provided by kwallet.
It seems like upstream supports building without kwallet support, as there's a WITH_KWALLET ifdef available, though support for it can not be disabled without patching the CMakeLists.txt:

https://invent.kde.org/graphics/okular/-/blob/master/CMakeLists.txt#L101

I've contacted upstream about whether it's possible to build without KWallet support (mistakenly using the wrong bug tracker), but they just told me to get my vision checked: https://invent.kde.org/graphics/okular/-/issues/61

Something like a `sed -i '/^    Wallet$/d' CMakeLists.txt` in src_prepare() would likely be enough to disable support for it, as setting the `${optionalComponents}` variable will still cause it to be used when it's installed.

I'd like it if kwallet support was made optional through a USE flag, given it's "supported" (at least partially) by upstream.
Comment 1 Larry the Git Cow gentoo-dev 2021-08-31 15:43:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=1d70d930366adcb88fef9f0559af30b1a64f7352

commit 1d70d930366adcb88fef9f0559af30b1a64f7352
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-31 15:26:50 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-31 15:40:12 +0000

    kde-apps/okular: Add IUSE="kwallet" via upstream submitted patch
    
    See also: https://invent.kde.org/graphics/okular/-/merge_requests/474
    
    Bug: https://bugs.gentoo.org/810958
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/okular-21.08.1-optional-options.patch    | 109 +++++++++++++++++++++
 kde-apps/okular/metadata.xml                       |   1 +
 kde-apps/okular/okular-21.08.49.9999.ebuild        |   6 +-
 kde-apps/okular/okular-9999.ebuild                 |   6 +-
 4 files changed, 118 insertions(+), 4 deletions(-)
Comment 2 Esteve Varela Colominas 2021-09-01 14:55:18 UTC
Thanks a lot for looking into this!
Comment 3 Sok Ann Yap 2021-09-06 10:28:41 UTC
With the kwallet USE flag disabled, I got error "Could not open file:///path/to/file.pdf" when trying to open a password protected PDF file.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-09-06 16:31:42 UTC
(In reply to Sok Ann Yap from comment #3)
> With the kwallet USE flag disabled, I got error "Could not open
> file:///path/to/file.pdf" when trying to open a password protected PDF file.

I'd probably open a new bug for this, but that might well be expected.
Comment 5 Esteve Varela Colominas 2021-09-06 17:26:29 UTC
I think that's very much expected.