Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 810317 - app-admin/vault-1.8.1 fails to compile
Summary: app-admin/vault-1.8.1 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zac Medico
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-25 11:25 UTC by Agostino Sarubbo
Modified: 2021-09-16 22:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,78.52 KB, text/plain)
2021-08-25 11:25 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-08-25 11:25:32 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/vault-1.8.1 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
If you think this is a GCC-11 related issue, please block bug 732706.
Comment 1 Agostino Sarubbo gentoo-dev 2021-08-25 11:25:35 UTC
Created attachment 735941 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2021-08-25 11:25:36 UTC
Possible context of error(s):

--> linux/amd64 error: exit status 2
Comment 3 Gabriel Linder 2021-09-02 12:26:21 UTC
Everything works here with go version go1.16.7 linux/amd64

But is fails with go version go1.17 linux/amd64 :
1 errors occurred:
--> linux/amd64 error: exit status 2
Stderr: # github.com/hashicorp/vault
github.com/sethvargo/go-limiter/memorystore.(*store).purge: relocation target runtime.walltime not defined
github.com/sethvargo/go-limiter/memorystore.newBucket: relocation target runtime.walltime not defined
github.com/sethvargo/go-limiter/memorystore.(*bucket).take: relocation target runtime.walltime not defined
make: *** [Makefile:37: dev] Error 1

Same gcc version on both tests :
$ cc --version
cc (Gentoo 10.3.0-r2 p3) 10.3.0
Comment 4 George Diamantopoulos 2021-09-10 08:21:01 UTC
It appears this is the culprit: https://discuss.hashicorp.com/t/basic-build-error/28526

Apparently bumping go-limiter to 0.7.0 should fix this. I tries to do this locally, but one needs to take care of other mods depending on go-limiter 0.3.0 as well...
Comment 5 Gabriel Linder 2021-09-14 10:58:33 UTC
Upstream has bumped the faulty lib in this PR : https://github.com/hashicorp/vault/pull/12358
Comment 6 Austin English 2021-09-16 17:12:46 UTC
Dupe of bug 808791 (which has a patch attached).
Comment 7 Patrick McLean gentoo-dev 2021-09-16 17:13:39 UTC

*** This bug has been marked as a duplicate of bug 808791 ***
Comment 8 Larry the Git Cow gentoo-dev 2021-09-16 22:07:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fa16bc47f1c8d140656cfa0492e989da5c1bf67

commit 7fa16bc47f1c8d140656cfa0492e989da5c1bf67
Author:     Austin English <austin.m.english@sony.com>
AuthorDate: 2021-09-16 16:45:05 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2021-09-16 22:07:48 +0000

    app-admin/vault: fix build with newer golang
    
    Closes: https://bugs.gentoo.org/808791
    Closes: https://bugs.gentoo.org/810317
    
    Signed-off-by: Austin English <austin.m.english@sony.com>
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 app-admin/vault/Manifest                           |   4 +-
 app-admin/vault/files/vault-1.8.2-go-limiter.patch | 264 +++++++++++++++++++++
 app-admin/vault/vault-1.8.2.ebuild                 |   6 +-
 3 files changed, 270 insertions(+), 4 deletions(-)