810094 – >=dev-python/websockets-9.1: some legacy tests fail on riscv due to taking too long

Bug 810094 - >=dev-python/websockets-9.1: some legacy tests fail on riscv due to taking too long

Summary: >=dev-python/websockets-9.1: some legacy tests fail on riscv due to taking to...

Status:	RESOLVED OBSOLETE

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	riscv Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Games

URL:	https://bugs.debian.org/cgi-bin/bugre...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2021-08-24 19:57 UTC by Marek Szuba
Modified:	2022-05-31 06:34 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
websockets-9.1-r1-build.log (websockets-9.1-r1-build.log,86.58 KB, text/plain) 2021-08-24 19:58 UTC, Marek Szuba	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marek Szuba archtester

2021-08-24 19:57:01 UTC

Looks like it's the same thing as the Debian bug 857753.

Comment 1 Marek Szuba archtester

2021-08-24 19:58:19 UTC

Created attachment 735811 [details]
websockets-9.1-r1-build.log

Comment 2 James Le Cuirot gentoo-dev

2021-09-04 14:20:09 UTC

I haven't been able to reproduce this, even when emulating m68k. Could you please retry with WEBSOCKETS_TESTS_TIMEOUT_FACTOR=100 set? If that doesn't work, try 1000.

Comment 3 Marek Szuba archtester

2021-09-06 16:55:03 UTC

WEBSOCKETS_TESTS_TIMEOUT_FACTOR=100 helps, then the tests fail with

AssertionError: Items in the first set but not the second:                                                                                                                                                                                   
'The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.'                                                                                                                                                

Which (the fact that the time-out factor helps, not the assertion errors) match the Debian assessment of the problem.

Comment 4 Larry the Git Cow gentoo-dev

2021-10-30 07:52:36 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df822423436f87dcd357ff2e2af57e041135d661

commit df822423436f87dcd357ff2e2af57e041135d661
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2021-10-30 07:52:06 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2021-10-30 07:52:06 +0000

    dev-python/websockets: Fix tests on slower systems for 9.1
    
    Infuriatingly, this approach makes one of the 10.0 tests fail
    consistently on my fast desktop.
    
    Bug: https://bugs.gentoo.org/810094
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 dev-python/websockets/websockets-9.1-r1.ebuild | 3 +++
 1 file changed, 3 insertions(+)

Comment 5 Michał Górny archtester

2022-05-31 06:34:17 UTC

Closing bugs for old versions with the new stabilization round.  If you can still reproduce with the newest ~arch version, feel free to reopen.