Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 809591 - media-video/pipewire-0.3.33 version bump
Summary: media-video/pipewire-0.3.33 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-22 14:46 UTC by retidurc
Modified: 2021-08-24 13:17 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description retidurc 2021-08-22 14:46:13 UTC
New release is available upstream 

https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/0.3.33

Tried a trivial bump in a local overlay but patch "pipewire-0.3.31-reverse-openaptx-restriction" failed to apply.  Fixing is unfortunately out of my skill



Reproducible: Always
Comment 1 retidurc 2021-08-22 16:40:17 UTC
I don't know if here is the right place to provide those informations (and you may already know about it), pipewire switched from libopenaptx to libfreeaptx over licensing stuff https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/843

So this is the reason why the patch is failing

Libreaptx is not in the portage tree so I guess this blocks the update
I'll try to do something locally on my end, do you wants or need me to update here if I got anything working?
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-08-22 22:49:17 UTC
All we need to do is revert upstream commit 1216371f8c06f548f8ade6468b66612f43df1436 in order to still use libopenaptx. Even pipewire-0.3.31-reverse-openaptx-restriction.patch then applies again.
Comment 3 Matt Turner gentoo-dev 2021-08-22 23:19:58 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #2)
> All we need to do is revert upstream commit
> 1216371f8c06f548f8ade6468b66612f43df1436 in order to still use libopenaptx.
> Even pipewire-0.3.31-reverse-openaptx-restriction.patch then applies again.

Why don't we just switch to freeaptx and be done with it?
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-08-23 03:15:20 UTC
(In reply to Matt Turner from comment #3)
> (In reply to Lars Wendler (Polynomial-C) from comment #2)
> > All we need to do is revert upstream commit
> > 1216371f8c06f548f8ade6468b66612f43df1436 in order to still use libopenaptx.
> > Even pipewire-0.3.31-reverse-openaptx-restriction.patch then applies again.
> 
> Why don't we just switch to freeaptx and be done with it?

Agreed. From IRC:
[03:59:11]  <+sam_> mattst88, Polynomial-C: re bug https://bugs.gentoo.org/809591#c3
[03:59:21]  <+sam_> this is pretty much my view and I still don't agree with this random patch which upstream don't approve of
[03:59:26]  <+sam_> it's legally dubious but even if we ignore that
[03:59:31]  <+sam_> upstream don't support openaptx, so..
[03:59:53]  <+sam_> i'm happy to try package freeaptx, but I don't use pipewire, so someone else would ideally runtime test it before switching the dep in pipewire
[03:59:55]  <+sam_> sound ok?
[04:02:11]  <@mattst88> sounds good to me

Sorry I forgot to tag this bug with the addition commit, but see here: https://bugs.gentoo.org/791259#c21
Comment 5 Larry the Git Cow gentoo-dev 2021-08-24 13:17:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b0f9b2915c3e98ef272f613515afc74a53286b28

commit b0f9b2915c3e98ef272f613515afc74a53286b28
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-08-24 12:51:17 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-08-24 12:52:07 +0000

    media-video/pipewire: bump to v0.3.33
    
    Stick to libaptx for now and delay decision since both
    aptx libs haven't diverged yet.
    
    Closes: https://bugs.gentoo.org/809591
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 media-video/pipewire/Manifest                      |   1 +
 ...pipewire-0.3.33-revert-libfreeaptx-switch.patch |  38 +++
 media-video/pipewire/pipewire-0.3.33.ebuild        | 273 +++++++++++++++++++++
 media-video/pipewire/pipewire-9999.ebuild          |   1 +
 4 files changed, 313 insertions(+)