Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 809401 - visual-studio-code/codium: rename binaries to their upstream names
Summary: visual-studio-code/codium: rename binaries to their upstream names
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Adel KARA SLIMANE
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-08-21 13:06 UTC by Mikle Kolyada (RETIRED)
Modified: 2021-09-14 07:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-08-21 13:06:16 UTC
The original binaries names on each platform/distro are:

- code
- codium

I fail to see why not following the generic scheme and adding kinda misleading symlinks.
Comment 1 Adel KARA SLIMANE 2021-08-21 13:22:56 UTC
Hello,

It was a matter of subjective taste. 

I find the naming `code` to be too generic, especially compared to `vscode`. I think people out of the blue won't search for `code` when doing `emerge --search` but will search for `vscode` instead. `vscode` or `visual studio code` is used everywhere by Microsoft except for the executable names, I do not understand this choice and did not abide by it.

If it bothers everyone, which I don't think it is the case (I may be wrong), then it is better to do a name change.
Comment 2 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-08-21 13:29:43 UTC
Well, you can expect 'code' or 'codium' across each and every platform (macos/windows/etc) so it indeed might be kinda confusing for a moment for really long time users (I had to check the 'equery f' output to see what's was going on)
Comment 3 Adel KARA SLIMANE 2021-08-21 13:32:14 UTC
If what bothers you the most is the executable name and not the package name then what we can do is add both versions, `code` and `vscode` to `/usr/bin`, and everyone can be happy :D
Comment 4 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-08-21 13:34:34 UTC
But is there a point really? I agree that 'code' itself is kinda generic historically, but this is what people really expect to see :)
Comment 5 Adel KARA SLIMANE 2021-08-21 13:42:59 UTC
I think `vscode` has its advantages as a package name: if you do `emerge --search code` you will get 154 results whereas `vscode` gives you what you want.

Now, about the "easy to lookup" argument
 
If you are convinced: then having a `vscode` executable makes sense too. 

If the argument does not make sense to you, then I don't know what we should do next: a package name change ? Wouldn't that confuse even more people ? Is it really that bad to go by "vscode" as a package name even if we don't follow the other distros ?

In any case, I agree with your argument to stick with package naming across distros, but I had the chance to do a "special snowflake" move and I did it given it doesn't really hurt anyone xD. This package originally was in GURU and its original name was even "worse": visual-studio-code-bin
Comment 6 Larry the Git Cow gentoo-dev 2021-09-14 07:39:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9cfd21d6e5bd33376c6a0b82ab5c6c4d4233e280

commit 9cfd21d6e5bd33376c6a0b82ab5c6c4d4233e280
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2021-09-10 11:44:19 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-09-14 07:38:52 +0000

    app-editors/vscode: version bump to 1.60.0 + wayland support
    
    Closes: https://bugs.gentoo.org/809401
    Closes: https://bugs.gentoo.org/811759
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/vscode/Manifest                        |   3 +
 .../files/vscode-url-handler-wayland.desktop       |  12 ++
 .../vscode/files/vscode-url-handler.desktop        |   4 +-
 app-editors/vscode/files/vscode-wayland.desktop    |  18 +++
 app-editors/vscode/files/vscode.desktop            |   4 +-
 app-editors/vscode/vscode-1.60.0.ebuild            | 121 +++++++++++++++++++++
 6 files changed, 158 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b7cac79fda891fda9210afbdf30326f4b71d9be

commit 6b7cac79fda891fda9210afbdf30326f4b71d9be
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2021-09-10 11:43:31 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-09-14 07:38:52 +0000

    app-editors/vscodium: version bump to 1.60.0 + wayland support
    
    Closes: https://bugs.gentoo.org/809401
    Closes: https://bugs.gentoo.org/811759
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/vscodium/Manifest                      |   3 +
 .../files/vscodium-url-handler-wayland.desktop     |  12 +++
 .../vscodium/files/vscodium-url-handler.desktop    |   2 +-
 .../vscodium/files/vscodium-wayland.desktop        |  18 ++++
 app-editors/vscodium/files/vscodium.desktop        |   2 +-
 app-editors/vscodium/vscodium-1.60.0.ebuild        | 112 +++++++++++++++++++++
 6 files changed, 147 insertions(+), 2 deletions(-)