Some games with enabled set-group-ID bit have wrong group owner, 'root'. It should be 'gamestat'. (Probably incomplete) list of the games: - games-arcade/emilia-pinball - games-arcade/lbreakout2 - games-arcade/tomatoes - games-action/maelstrom - games-action/powermanga Because of that: 1. Games runs with effective group ID 0, which can have security implications. 2. Scores are not saved.
lbreakout2 and maelstorm seem to use gamestat, are you sure about these? $ ls -l /usr/bin/lbreakout2 /var/games/lbreakout2.hscr -rwxr-s--x 1 root gamestat 287240 Aug 21 04:36 /usr/bin/lbreakout2 -rw-rw---- 1 root gamestat 229 Aug 21 04:36 /var/games/lbreakout2.hscr # ls -l /usr/bin/Maelstrom /var/games/Maelstrom-Scores -rwxr-s--x 1 root gamestat 200784 Aug 21 04:45 /usr/bin/Maelstrom -rw-rw---- 1 root gamestat 280 Aug 21 04:45 /var/games/Maelstrom-Scores But for the three others, indeed I see: $ ls -l /usr/bin/pinball /var/games/pinball/tux/highscores -rwxr-s--x 1 root root 343640 Aug 21 04:42 /usr/bin/pinball -rw-rw---- 1 root gamestat 0 Aug 21 04:42 /var/games/pinball/tux/highscores $ ls -l /usr/bin/tomatoes /var/games/tomatoes/hiscore.lst -rwxr-s--x 1 root root 155344 Aug 21 04:44 /usr/bin/tomatoes -rw-rw---- 1 root gamestat 0 Aug 21 04:44 /var/games/tomatoes/hiscore.lst $ ls -l /usr/bin/powermanga /var/games/powermanga.hi -rwxr-xr-x 1 root root 65 Aug 21 04:48 /usr/bin/powermanga -rw-rw---- 1 root root 0 Aug 21 04:48 /var/games/powermanga.hi
Normally prefer 1 bug per package, but I'll just set it like that for now (just to ensure they come up in searches). Removed lbreakout2/maelstrom unless you can tell me what's wrong with them. This is something I fixed on a few other packages I happened to look at, but I do fear rushed migrations may have left more of these.
LBreakout2 and Maelstrom are fine, sorry about that.
I have found one more - games-arcade/pachi. Its binary /usr/bin/pachi has root group owner. On the other hand, games-action/powermanga is fine because /usr/bin/powermanga is a wrapper script of /usr/bin/powermanga.bin. powermanga.bin has correct group: $ ls -l /usr/bin/powermanga.bin -rwxr-s--x 1 root gamestat 294280 Sep 5 2019 /usr/bin/powermanga.bin So the list is: games-arcade/emilia-pinball, games-arcade/tomatoes, games-arcade/pachi.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0186a06df950e5a40d7555efc2db368c34e8413 commit f0186a06df950e5a40d7555efc2db368c34e8413 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:03:42 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:13 +0000 games-roguelike/tome: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-roguelike/tome/{tome-2.3.5.ebuild => tome-2.3.5-r1.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd960a14955aaff48cd102936e9643b88f738722 commit bd960a14955aaff48cd102936e9643b88f738722 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:03:27 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:12 +0000 games-arcade/xjump: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-arcade/xjump/{xjump-2.7.5-r1.ebuild => xjump-2.7.5-r2.ebuild} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=280712171311f1d1e10490512a08737f5f8e0eab commit 280712171311f1d1e10490512a08737f5f8e0eab Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:02:51 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:11 +0000 games-arcade/xgalaga: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-arcade/xgalaga/xgalaga-2.1.1.0-r1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36377e34890d1bb805dfaf3719f8359309b76846 commit 36377e34890d1bb805dfaf3719f8359309b76846 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:02:37 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:10 +0000 games-arcade/gunocide2ex: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> .../{gunocide2ex-1.0-r2.ebuild => gunocide2ex-1.0-r3.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ddb81deb7cef20f5ab6f6b1d213f53de2d07604 commit 8ddb81deb7cef20f5ab6f6b1d213f53de2d07604 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:02:20 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:09 +0000 games-arcade/barbarian-bin: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-arcade/barbarian-bin/barbarian-bin-1.01-r3.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3edb7e2e494e96c71008051b9d2ae9327364f5d9 commit 3edb7e2e494e96c71008051b9d2ae9327364f5d9 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 03:48:30 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:07 +0000 games-arcade/pachi: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-arcade/pachi/{pachi-1.0-r1.ebuild => pachi-1.0-r2.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=784f76a9a73772dddf73cf96bd85e4db11c765da commit 784f76a9a73772dddf73cf96bd85e4db11c765da Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 03:48:05 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:06 +0000 games-arcade/tomatoes: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> .../tomatoes/{tomatoes-1.55-r3.ebuild => tomatoes-1.55-r4.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fa0a7832b504e16e28ee8047d815384e0d5ec01 commit 7fa0a7832b504e16e28ee8047d815384e0d5ec01 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 03:46:25 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 04:06:05 +0000 games-arcade/emilia-pinball: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> .../{emilia-pinball-0.3.1-r2.ebuild => emilia-pinball-0.3.1-r3.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=38cec4aec1686ee5bdacd91ea3af64f302f42e6f commit 38cec4aec1686ee5bdacd91ea3af64f302f42e6f Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:22:51 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:08 +0000 games-rpg/coe2: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-rpg/coe2/{coe2-2007-r2.ebuild => coe2-2007-r3.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=724646eb72b857009a0a7c32e18cef7805c9a507 commit 724646eb72b857009a0a7c32e18cef7805c9a507 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:22:04 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:07 +0000 games-roguelike/moria: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-roguelike/moria/{moria-5.7.14.ebuild => moria-5.7.14-r1.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e8f53e08c282ff4d91c3022f9de5c66b6101e64 commit 4e8f53e08c282ff4d91c3022f9de5c66b6101e64 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:21:29 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:06 +0000 games-puzzle/xwelltris: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> .../xwelltris/{xwelltris-1.0.1.ebuild => xwelltris-1.0.1-r1.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b920a253cdd0256b108ecebcaed105911d2b2e8c commit b920a253cdd0256b108ecebcaed105911d2b2e8c Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:20:33 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:05 +0000 games-puzzle/xbomb: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-puzzle/xbomb/{xbomb-2.2b-r1.ebuild => xbomb-2.2b-r2.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3018fbea51adebe6a7b0e8adb9f11de9aaca112c commit 3018fbea51adebe6a7b0e8adb9f11de9aaca112c Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:20:19 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:04 +0000 games-puzzle/seatris: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> .../seatris/{seatris-0.0.14-r1.ebuild => seatris-0.0.14-r2.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8eefadd7f340c6249981d5de2000cd55dccb54cb commit 8eefadd7f340c6249981d5de2000cd55dccb54cb Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:19:47 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:03 +0000 games-arcade/jardinains: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> .../jardinains/{jardinains-2.0-r3.ebuild => jardinains-2.0-r4.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c81abb29b6dd6d708c4d568cad2146da3422d5a commit 2c81abb29b6dd6d708c4d568cad2146da3422d5a Author: Sam James <sam@gentoo.org> AuthorDate: 2021-08-23 04:14:06 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-08-23 05:05:02 +0000 games-arcade/xbill: fix group of binary Closes: https://bugs.gentoo.org/809353 Signed-off-by: Sam James <sam@gentoo.org> games-arcade/xbill/{xbill-2.1-r3.ebuild => xbill-2.1-r4.ebuild} | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
