Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 809092 - sys-process/criu-3.15 with dev-libs/protobuf-c-1.4.0: criu/fsnotify.c:227:5: error: conflicting types for ‘check_open_handle’; have ‘int(unsigned int, long unsigned int, FhEntry *)’
Summary: sys-process/criu-3.15 with dev-libs/protobuf-c-1.4.0: criu/fsnotify.c:227:5: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-08-19 14:51 UTC by Kobboi
Modified: 2021-11-04 21:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,219.99 KB, text/x-log)
2021-08-19 14:53 UTC, Kobboi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2021-08-19 14:51:05 UTC
x86_64-pc-linux-gnu-gcc -c -O2 -march=skylake -pipe -g -ggdb -Wall -Wformat-security -Wdeclaration-after-statement -Wstrict-prototypes -DCONFIG_X86_64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DCONFIG_GNUTLS -DCONFIG_HAS_NFTABLES_LIB_API_1 -DCONFIG_COMPAT -iquote include/ -DCONFIG_GNUTLS -DCONFIG_HAS_NFTABLES_LIB_API_1 -DCONFIG_COMPAT -I ./compel/include/uapi -fno-strict-aliasing -iquote criu/include -iquote include -iquote images -iquote criu/arch/x86/include -iquote . -I/usr/include/libnl3 -DSYSCONFDIR='"/etc"' -DGLOBAL_CONFIG_DIR='"/etc/criu/"' -DDEFAULT_CONFIG_FILENAME='"default.conf"' -DUSER_CONFIG_DIR='".criu/"' criu/img-streamer.c -o criu/img-streamer.o
criu/fsnotify.c:227:5: error: conflicting types for ‘check_open_handle’; have ‘int(unsigned int,  long unsigned int,  FhEntry *)’
  227 | int check_open_handle(unsigned int s_dev, unsigned long i_ino,
      |     ^~~~~~~~~~~~~~~~~
In file included from criu/fsnotify.c:38:
criu/include/irmap.h:9:5: note: previous declaration of ‘check_open_handle’ with type ‘int(unsigned int,  long unsigned int,  struct _FhEntry *)’
    9 | int check_open_handle(unsigned int s_dev, unsigned long i_ino,
      |     ^~~~~~~~~~~~~~~~~
criu/fsnotify.c: In function ‘pre_dump_one_inotify’:
criu/fsnotify.c:377:63: warning: passing argument 3 of ‘irmap_queue_cache’ from incompatible pointer type [-Wincompatible-pointer-types]
  377 |                 if (irmap_queue_cache(we->s_dev, we->i_ino, we->f_handle))
      |                                                             ~~^~~~~~~~~~
      |                                                               |
      |                                                               FhEntry *
In file included from criu/fsnotify.c:38:
criu/include/irmap.h:6:34: note: expected ‘struct _FhEntry *’ but argument is of type ‘FhEntry *’
    6 |                 struct _FhEntry *fh);
      |                 ~~~~~~~~~~~~~~~~~^~
criu/fsnotify.c: In function ‘pre_dump_one_fanotify’:
criu/fsnotify.c:482:47: warning: passing argument 3 of ‘irmap_queue_cache’ from incompatible pointer type [-Wincompatible-pointer-types]
  482 |                                         me->ie->f_handle))
      |                                         ~~~~~~^~~~~~~~~~
      |                                               |
      |                                               FhEntry *
In file included from criu/fsnotify.c:38:
criu/include/irmap.h:6:34: note: expected ‘struct _FhEntry *’ but argument is of type ‘FhEntry *’
    6 |                 struct _FhEntry *fh);
      |                 ~~~~~~~~~~~~~~~~~^~
make[2]: *** [/var/tmp/portage/sys-process/criu-3.15/work/criu-3.15/scripts/nmk/scripts/build.mk:118: criu/fsnotify.o] Error 1
make[2]: *** Waiting for unfinished jobs....
criu/image.c:25:19: error: conflicting types for ‘root_ids’; have ‘TaskKobjIdsEntry *’
   25 | TaskKobjIdsEntry *root_ids;
      |                   ^~~~~~~~
In file included from criu/image.c:11:
criu/include/pstree.h:116:34: note: previous declaration of ‘root_ids’ with type ‘struct _TaskKobjIdsEntry *’
  116 | extern struct _TaskKobjIdsEntry *root_ids;
      |                                  ^~~~~~~~
make[2]: *** [/var/tmp/portage/sys-process/criu-3.15/work/criu-3.15/scripts/nmk/scripts/build.mk:118: criu/image.o] Error 1
make[1]: *** [criu/Makefile:76: criu/built-in.o] Error 2
make: *** [Makefile:248: criu] Error 2


Reproducible: Always
Comment 1 Kobboi 2021-08-19 14:53:36 UTC
Created attachment 734293 [details]
build.log
Comment 2 Kobboi 2021-08-19 14:53:58 UTC
Portage 3.0.22 (python 3.9.6-final-0, !../../var/db/repos/kobboi-linux/profiles/kobboi/samsonov, gcc-11.2.0, glibc-2.33-r7, 5.13.10-gentoo-dist x86_64)
=================================================================
System uname: Linux-5.13.10-gentoo-dist-x86_64-Intel-R-_Core-TM-_i7-6700_CPU_@_3.40GHz-with-glibc2.33
KiB Mem:    32773552 total,   9451608 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Thu, 19 Aug 2021 11:51:43 +0000
Head commit of repository gentoo: 92d6221a5e9f8a8c5490cde95c4302f901c08df4

Timestamp of repository brother-overlay: Wed, 18 Aug 2021 18:36:56 +0000
Head commit of repository brother-overlay: a72e4de7e2d38f8129ccea481a6878040dd281b7

Timestamp of repository gitlab: Thu, 19 Aug 2021 06:36:22 +0000
Head commit of repository gitlab: e5587e72a533989933c9be37502d287bc7b0374d

Head commit of repository kobboi-linux: 4aeecdc1383568ae3539cad86d7d34aac28c0b13

Timestamp of repository steam-overlay: Wed, 18 Aug 2021 10:52:45 +0000
Head commit of repository steam-overlay: 938b29bc838293e3b0371fa2da205dc87f389364

sh bash 5.1_p8
ld GNU ld (Gentoo 2.36.1 p4) 2.36.1
distcc 3.4 x86_64-pc-linux-gnu [disabled]
ccache version 4.3 [disabled]
app-shells/bash:          5.1_p8::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.34.0-r2::gentoo
dev-lang/python:          2.7.18_p11::gentoo, 3.9.6_p1::gentoo, 3.10.0_rc1_p1::gentoo
dev-lang/rust:            1.54.0::gentoo
dev-util/ccache:          4.3-r3::gentoo
dev-util/cmake:           3.21.1::gentoo
sys-apps/baselayout:      2.7-r3::gentoo
sys-apps/sandbox:         2.24::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:       1.16.4::gentoo
sys-devel/binutils:       2.36.1-r2::gentoo
sys-devel/gcc:            11.2.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000

brother-overlay
    location: /var/db/repos/brother-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/brother-overlay.git
    masters: gentoo

gitlab
    location: /var/db/repos/gitlab
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gitlab.git
    masters: gentoo

kobboi-linux
    location: /var/db/repos/kobboi-linux
    sync-type: git
    sync-uri: https://github.com/kobboi/kobboi-linux.git
    masters: gentoo

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo

Installed sets: @kobboi-all
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=skylake -pipe -g -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.8/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.4/ext-active/ /etc/php/apache2-php8.0/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cgi-php8.0/ext-active/ /etc/php/cli-php7.4/ext-active/ /etc/php/cli-php8.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=skylake -pipe -g -ggdb"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -march=skylake -pipe -g -ggdb"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles installsources ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=skylake -pipe -g -ggdb"
GENTOO_MIRRORS="ftp://kobboi-linux:*password*@10.8.0.1/2020.11"
INSTALL_MASK="/usr/src/debug /usr/lib/debug"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 avahi bluetooth bzip2 cairo cdda cdr cli colord crypt cups dbus dist-kernel djvu dri dts dvd dvdr eds egl emboss encode evo exif facedetect ffmpeg flac fluidsynth fortran frei0r gdbm gif glade gles gles2 gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gtk3 gtkstyle gui iconv icu introspection ipv6 jpeg ladspa lcms libass libglvnd libnotify libsecret libtirpc lv2 lz4 lzma lzo mad midi mng modemmanager mono mp3 mp4 mpeg mtp multilib nautilus ncurses networkmanager nls nptl ogg opencv opengl openmp opus pam pango pcre pdf png policykit ppds pulseaudio qt5 readline samba screencast sdl seccomp smartcard smp spell split-usr ssl startup-notification svg sysprof systemd tcpd tiff truetype udev udisks unicode upower usb v4l vaapi vdpau vorbis wayland wxwidgets x264 xattr xcb xml xv xvid zeroconf zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="hda-intel ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse synaptics libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="vesa radeon nvidia intel amdgpu dummy fbdev nouveau radeonsi v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
Comment 3 Kobboi 2021-08-19 14:57:38 UTC
Compiles fine with protobuf-c-1.3.3
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-09-05 04:27:44 UTC
https://github.com/checkpoint-restore/criu/commit/1c25914a5dd1eb385937dffdd85901c3f5e39b8c may help, but ideally needs testing with both the old and new versions of protobuf-c
Comment 5 Larry the Git Cow gentoo-dev 2021-09-05 05:57:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24ba952b3ff906ee79987fcfb100ca495a23675d

commit 24ba952b3ff906ee79987fcfb100ca495a23675d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-09-05 05:57:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-09-05 05:57:18 +0000

    sys-process/criu: add patch for >=dev-libs/protobuf-c-1.4.0
    
    Could be adapted to earlier versions in theory.
    
    Closes: https://bugs.gentoo.org/809092
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-process/criu/criu-3.15-r1.ebuild               | 140 +++++++++++++++++
 .../criu/files/criu-3.15-protobuf-c-1.4.0.patch    | 168 +++++++++++++++++++++
 2 files changed, 308 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2021-11-04 21:10:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=582a26d6ebc8a93a086e2117dca3f9e712998832

commit 582a26d6ebc8a93a086e2117dca3f9e712998832
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-04 21:09:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-04 21:09:38 +0000

    sys-process/criu: add additional protobuf-c patch
    
    Closes: https://bugs.gentoo.org/809092
    Closes: https://bugs.gentoo.org/814056
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-process/criu/{criu-3.15-r1.ebuild => criu-3.15-r2.ebuild} | 0
 sys-process/criu/files/criu-3.15-protobuf-c-1.4.0.patch       | 2 ++
 2 files changed, 2 insertions(+)