Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 808833 - net-misc/curl disabled NTLM without explanation
Summary: net-misc/curl disabled NTLM without explanation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-18 07:15 UTC by Hasso Tepper
Modified: 2021-08-27 13:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hasso Tepper 2021-08-18 07:15:05 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/net-misc/curl?id=2aa4412540761e726c93fa29e5c9e917acc15a25 disabled NTLM support without explanation and no way to enable it via USE flag for example. Why it was done? It's required for many use cases. In my case it breaks all PHP applications using backends in Windows (MSSQL etc).

Reproducible: Always

Steps to Reproduce:
1. Execute curl with --ntlm option.
Actual Results:  
> curl --ntlm
curl: option --ntlm: the installed libcurl version doesn't support this

Expected Results:  
> curl --ntlm
curl: no URL specified!
Comment 1 Anthony Basile gentoo-dev 2021-08-24 20:11:04 UTC
I disable flags that I think people won't need, but I can never be sure what people want and what they don't.

Please try curl-7.78.0-r2.ebuild.  If it does what you want, then curl will have it going forward.
Comment 2 Larry the Git Cow gentoo-dev 2021-08-24 20:12:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22464d85277707f1f3958d845702b85dc0c78d2f

commit 22464d85277707f1f3958d845702b85dc0c78d2f
Author:     Anthony G. Basile <blueness@gentoo.org>
AuthorDate: 2021-08-24 20:11:47 +0000
Commit:     Anthony G. Basile <blueness@gentoo.org>
CommitDate: 2021-08-24 20:12:01 +0000

    net-misc/curl: enable ntlm
    
    Closes: https://bugs.gentoo.org/808833
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Anthony G. Basile <blueness@gentoo.org>

 net-misc/curl/curl-7.78.0-r2.ebuild | 290 ++++++++++++++++++++++++++++++++++++
 net-misc/curl/metadata.xml          |   1 +
 2 files changed, 291 insertions(+)
Comment 3 Mike Gilbert gentoo-dev 2021-08-24 22:17:28 UTC
(In reply to Anthony Basile from comment #1)
> I disable flags that I think people won't need, but I can never be sure what
> people want and what they don't.

Can you please revert back to having it enabled unconditionally without a USE flag? This feature required no external dependencies, and I don't see any purpose to making it optional.
Comment 4 Maurizio Firmani 2021-08-26 14:00:20 UTC
I also use curl in my PHP applications and I couldn't find out why they were not working anymore. Could you enable it again or at least give the option to enable it? It is already difficult to "talk" with Windows applications. Thank you.
Comment 5 Larry the Git Cow gentoo-dev 2021-08-27 10:31:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d09f46f20d78a56db8b109db1dbe066305428ba7

commit d09f46f20d78a56db8b109db1dbe066305428ba7
Author:     Anthony G. Basile <blueness@gentoo.org>
AuthorDate: 2021-08-27 10:31:06 +0000
Commit:     Anthony G. Basile <blueness@gentoo.org>
CommitDate: 2021-08-27 10:31:24 +0000

    net-misc/curl: enable NTLM unconditionally
    
    Closes: https://bugs.gentoo.org/808833
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Anthony G. Basile <blueness@gentoo.org>

 net-misc/curl/{curl-7.78.0-r2.ebuild => curl-7.78.0-r3.ebuild} | 4 ++--
 net-misc/curl/metadata.xml                                     | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)
Comment 6 Anthony Basile gentoo-dev 2021-08-27 10:34:23 UTC
(In reply to Mike Gilbert from comment #3)
> (In reply to Anthony Basile from comment #1)
> > I disable flags that I think people won't need, but I can never be sure what
> > people want and what they don't.
> 
> Can you please revert back to having it enabled unconditionally without a
> USE flag? This feature required no external dependencies, and I don't see
> any purpose to making it optional.

It was hard disabled for many past versions without anyone complaining  Nonetheless, there is no added dependency to hard enabling it, as you said, so please test curl-7.78.0-r2.ebuild.
Comment 7 Mike Gilbert gentoo-dev 2021-08-27 13:20:49 UTC
(In reply to Anthony Basile from comment #6)
> It was hard disabled for many past versions without anyone complaining 
> Nonetheless, there is no added dependency to hard enabling it, as you said,
> so please test curl-7.78.0-r2.ebuild.

I think you are incorrect about that. I believe NTLM was *enabled* unconditionally for many releases.

The configure switch to control it was only recently added. Before then, it was enabled by default with no direct way to disable it.
Comment 8 Anthony Basile gentoo-dev 2021-08-27 13:24:08 UTC
(In reply to Mike Gilbert from comment #7)
> (In reply to Anthony Basile from comment #6)
> > It was hard disabled for many past versions without anyone complaining 
> > Nonetheless, there is no added dependency to hard enabling it, as you said,
> > so please test curl-7.78.0-r2.ebuild.
> 
> I think you are incorrect about that. I believe NTLM was *enabled*
> unconditionally for many releases.
> 
> The configure switch to control it was only recently added. Before then, it
> was enabled by default with no direct way to disable it.

Ah, that explains it.  So it has only been since the ntlm switch was added that I have been disabling it by default in the ebuild.