Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 807933 - kde-apps/konsole-21.04.3-r3 flashes white when using CTRL-D to close
Summary: kde-apps/konsole-21.04.3-r3 flashes white when using CTRL-D to close
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard: fixed in 21.04.3-r4
Keywords: CC-ARCHES, UPSTREAM
Depends on: 808510
Blocks:
  Show dependency tree
 
Reported: 2021-08-12 23:24 UTC by David Flogeras
Modified: 2021-11-17 07:48 UTC (History)
0 users

See Also:
Package list:
kde-apps/konsole-21.04.3-r4
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Flogeras 2021-08-12 23:24:37 UTC
See https://bugs.kde.org/show_bug.cgi?id=432077

The above patch is slated for 21.12, but applies cleanly and works on current tree's konsole-21.04.3.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2021-08-13 20:14:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0e6cbb16cc7682173870439709ba880e1460b46

commit c0e6cbb16cc7682173870439709ba880e1460b46
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-13 20:06:18 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-13 20:13:47 +0000

    kde-apps/konsole: Prevent window "flashing" when closing last session
    
    Upstream commit 302c16791935cc3cf262aee355afce13d694b00f
    
    KDE-bug: https://bugs.kde.org/show_bug.cgi?id=432077
    Bug: https://bugs.gentoo.org/807933
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...konsole-21.04.3-no-flash-on-session-close.patch | 81 ++++++++++++++++++++++
 kde-apps/konsole/konsole-21.04.3-r1.ebuild         | 76 ++++++++++++++++++++
 kde-apps/konsole/konsole-21.08.0-r1.ebuild         | 72 +++++++++++++++++++
 3 files changed, 229 insertions(+)
Comment 2 Agostino Sarubbo gentoo-dev 2021-08-23 10:45:02 UTC
amd64 stable
Comment 3 Agostino Sarubbo gentoo-dev 2021-08-23 22:16:27 UTC
x86 stable
Comment 4 NATTkA bot gentoo-dev 2021-08-24 13:40:23 UTC Comment hidden (obsolete)
Comment 5 NATTkA bot gentoo-dev 2021-08-30 13:00:27 UTC Comment hidden (obsolete)
Comment 6 David Flogeras 2021-08-31 23:03:09 UTC
I just updated to konsole-21.04.3-r3 and for me the flashing white when closing via CTRL-D is back.
Comment 7 Andreas Sturmlechner gentoo-dev 2021-09-01 07:32:27 UTC
Please report this in the upstream bug. 21.04.3-r3 contains two follow-up patches to the (unchanged) original fix for the flashing phenomenon, all were necessary to fix resulting regressions worse than a visual glitch.

The three commits applied in -r3:

302c16791935cc3cf262aee355afce13d694b00f
2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7
2591a9489a4d3a43c7a7f00764e9f84822d4946c
Comment 8 David Flogeras 2021-09-01 11:03:42 UTC
Upstream has another patch in the pipe which seems to fix it again for me (applied on top of -r3)

https://invent.kde.org/utilities/konsole/-/merge_requests/469
Comment 9 NATTkA bot gentoo-dev 2021-09-01 11:20:25 UTC Comment hidden (obsolete)
Comment 10 Larry the Git Cow gentoo-dev 2021-09-22 21:59:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7efccec23f297902e698925af2503519d58ddf45

commit 7efccec23f297902e698925af2503519d58ddf45
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-09-22 21:28:56 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-09-22 21:59:10 +0000

    kde-apps/konsole: (Final) fix(?) for window flashing on session close
    
    Upstream commit e693f2d7f1977ca227589154a5cd8c18d8ce44b7
    
    Tested-by: David Flogeras <dflogeras2@gmail.com>
    Bug: https://bugs.gentoo.org/807933
    Package-Manager: Portage-3.0.23, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ....3-default-navigation-be-TabbedNavigation.patch | 32 +++++++++
 kde-apps/konsole/konsole-21.04.3-r4.ebuild         | 81 ++++++++++++++++++++++
 ...le-21.08.1.ebuild => konsole-21.08.1-r1.ebuild} |  4 ++
 3 files changed, 117 insertions(+)
Comment 11 Andreas Sturmlechner gentoo-dev 2021-09-23 10:50:36 UTC
David, did testing reveal any issues with the patch?
Comment 12 David Flogeras 2021-09-23 14:35:45 UTC
No problems here, using it on 3 separate machines since Sept 1.

But to be completely fair, I did not notice the previous patches' regressions because they were in features I never touch anyway.
Comment 13 Agostino Sarubbo gentoo-dev 2021-09-29 20:55:03 UTC
x86 stable
Comment 14 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-09-30 18:15:20 UTC
amd64 done
Comment 15 Andreas Sturmlechner gentoo-dev 2021-11-05 17:28:30 UTC
ping arm64.
Comment 16 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-17 07:48:17 UTC
arm64 done

all arches done