Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 807232 - x11-misc/xorg-cf-files: no machine defines for riscv
Summary: x11-misc/xorg-cf-files: no machine defines for riscv
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: riscv Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL: https://gitlab.freedesktop.org/xorg/u...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-09 02:56 UTC by Alex Fan
Modified: 2021-08-10 16:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (nas-1.9.4-r2:20210809-093108.log,62.86 KB, text/x-log)
2021-08-09 02:57 UTC, Alex Fan
Details
emerge --info (emerge.info,5.14 KB, application/x-info)
2021-08-09 02:57 UTC, Alex Fan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Fan archtester 2021-08-09 02:56:37 UTC
compilation on qemu riscv64 failed.

In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from ../include/os.h:124,
                 from ../include/misc.h:57,
                 from dixutils.c:52:
/usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
  187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
      |   ^~~~~~~
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from ../include/os.h:124,
                 from ../include/misc.h:57,
                 from globals.c:58:
/usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
  187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
      |   ^~~~~~~
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from ../include/os.h:124,
                 from ../include/misc.h:57,
                 from dispatch.c:52:
/usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
  187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
      |   ^~~~~~~
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from ../include/os.h:124,
                 from ../include/misc.h:57,
                 from events.c:52:
/usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
  187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
      |   ^~~~~~~
riscv64-unknown-linux-gnu-gcc: warning: LinuxMachineDefines: linker input file unused because linking not done
riscv64-unknown-linux-gnu-gcc: error: LinuxMachineDefines: linker input file not found: No such file or directory
make: *** [Makefile:1064: globals.o] Error 1
make: *** Waiting for unfinished jobs....
riscv64-unknown-linux-gnu-gcc: warning: LinuxMachineDefines: linker input file unused because linking not done
riscv64-unknown-linux-gnu-gcc: warning: LinuxMachineDefines: linker input file unused because linking not done
riscv64-unknown-linux-gnu-gcc: error: LinuxMachineDefines: linker input file not found: No such file or directory
riscv64-unknown-linux-gnu-gcc: error: LinuxMachineDefines: linker input file not found: No such file or directory
make: *** [Makefile:1064: dixutils.o] Error 1
make: *** [Makefile:1064: events.o] Error 1
riscv64-unknown-linux-gnu-gcc: warning: LinuxMachineDefines: linker input file unused because linking not done
riscv64-unknown-linux-gnu-gcc: error: LinuxMachineDefines: linker input file not found: No such file or directory
make: *** [Makefile:1064: dispatch.o] Error 1


Reproducible: Always
Comment 1 Alex Fan archtester 2021-08-09 02:57:33 UTC
Created attachment 731641 [details]
build log
Comment 2 Alex Fan archtester 2021-08-09 02:57:48 UTC
Created attachment 731644 [details]
emerge --info
Comment 3 Larry the Git Cow gentoo-dev 2021-08-10 08:58:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6b552b810bb457b5dcac796beb30888573989de

commit f6b552b810bb457b5dcac796beb30888573989de
Author:     Alex Fan <alexfanqi@yahoo.com>
AuthorDate: 2021-08-09 02:59:21 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2021-08-10 08:51:00 +0000

    profiles/arch/riscv: mask USE=nas
    
    compilation failed
    
    Bug: https://bugs.gentoo.org/807232
    Signed-off-by: Alex Fan <alexfanqi@yahoo.com>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 profiles/arch/riscv/use.mask | 4 ++++
 1 file changed, 4 insertions(+)
Comment 4 Marek Szuba archtester gentoo-dev 2021-08-10 15:14:56 UTC
The problem lies not in media-libs/nas itself but in the fact that imake config files installed by x11-misc/xorg-cf-files do not set arch-specific macros on riscv; see /usr/lib64/X11/config/linux.cf. This unfortunately is still the case in the upstream Git master.

Will cobble something together shortly, would rather avoid breaking the deptree by having to dekeyword all imake revdeps (assuming there are any.
Comment 5 Larry the Git Cow gentoo-dev 2021-08-10 16:00:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dcc8aaaf06ad9364679448c3dcd5404ccde66b8

commit 2dcc8aaaf06ad9364679448c3dcd5404ccde66b8
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-08-10 15:48:29 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-08-10 16:00:37 +0000

    x11-misc/xorg-cf-files: unkeyword <1.0.7-r1 for ~riscv
    
    They do not really support this arch, see the previous commit.
    
    Bug: https://bugs.gentoo.org/807232
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 x11-misc/xorg-cf-files/xorg-cf-files-1.0.6-r2.ebuild | 2 +-
 x11-misc/xorg-cf-files/xorg-cf-files-1.0.7.ebuild    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c21168e7901475574942701c381d8160f303a5b4

commit c21168e7901475574942701c381d8160f303a5b4
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-08-10 15:45:02 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-08-10 16:00:36 +0000

    x11-misc/xorg-cf-files: add support for riscv
    
    While both this package itself and x11-misc/imake emerge fine on riscv
    without this patch, the installed .cf files are useless for native
    RISC-V builds.
    
    Bug: https://bugs.gentoo.org/807232
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../files/xorg-cf-files-1.0.7-linux-riscv.patch    | 56 ++++++++++++++++++++++
 .../xorg-cf-files/xorg-cf-files-1.0.7-r1.ebuild    | 46 ++++++++++++++++++
 2 files changed, 102 insertions(+)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-08-10 16:17:52 UTC
When adding -arch, consider adding a bug reference in a comment above it in the ebuild for future reference. Also if possible include a link to the upstream patch and bug at the top of the patch file.