Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 806409 - sci-libs/ceres-solver-2.0.0 version bump
Summary: sci-libs/ceres-solver-2.0.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-04 18:21 UTC by Brian McCarter
Modified: 2021-08-04 19:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for ceres 2.0.0 as git-format patch (0001-sci-libs-ceres-solver-Bump-to-2.0.0.patch,5.95 KB, text/plain)
2021-08-04 18:21 UTC, Brian McCarter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian McCarter 2021-08-04 18:21:37 UTC
Created attachment 730164 [details]
ebuild for ceres 2.0.0 as git-format patch

See attached for an ebuild for ceres 2.0.0 in a git-format patch with GCO sign-off.  This ebuild is based off sci-libs/ceres-solver-1.14.0.  Changes include: 
* Uses existing `USE=openmp` to set new CERES_THREADING_MODEL cmake variable.
* Fixes error where `Eigen3Config.cmake` is missing.
* Add `USE=system-mathjax` and associated patch to enable generated doc to use local MathJax to render embedded math.

I'm using this ebuild on an x86_64 system but haven't tested it elsewhere.
Comment 1 Larry the Git Cow gentoo-dev 2021-08-04 19:32:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bcfb8cbaf2ba393d0959684675c3913e44338dc3

commit bcfb8cbaf2ba393d0959684675c3913e44338dc3
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2021-08-04 19:25:40 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2021-08-04 19:32:25 +0000

    sci-libs/ceres-solver: Bump to 2.0.0
    
    * Based off of sci-libs/ceres-solver-1.14.0.
    * Uses existing `USE=openmp` to set new CERES_THREADING_MODEL cmake
      variable.
    * Fixes error where `Eigen3Config.cmake` is missing.
    * Add `USE=system-mathjax` and associated patch to enable generated doc to
      use local MathJax to render embedded math.
    
    Closes: https://bugs.gentoo.org/806409
    Signed-off-by: Brian R McCarter <brian.r.mccarter.ctr@us.navy.mil>
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-libs/ceres-solver/Manifest                     |   1 +
 sci-libs/ceres-solver/ceres-solver-2.0.0.ebuild    | 104 +++++++++++++++++++++
 .../files/ceres-solver-2.0.0-system-mathjax.patch  |  10 ++
 3 files changed, 115 insertions(+)
Comment 2 Andrew Nowa Ammerlaan gentoo-dev 2021-08-04 19:37:57 UTC
Thanks, 

I made some small changes before merging. Most notably I added the docs eclass to take care of the doc dependencies, and I dropped the system-mathjax flag because the flag doesn't seem to be toggling anything. If we would want to actually toggle this we should make the applying of the patch conditional on that flag, but IMO we can just use the system version of mathjax unconditionally.
Comment 3 Brian McCarter 2021-08-04 19:50:39 UTC
Ah, you're right about the system-mathjax flag.  I intended the patch to be conditional on the flag but forgot to make the change.  Unconditional application works for me, and the other changes look good.  Thanks for the quick edit and commit.