Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 804966 - games-emulation/dolphin-5.0_p20210506 - /.../MD5.cpp: error: mbedtls_md5_starts_ret was not declared in this scope
Summary: games-emulation/dolphin-5.0_p20210506 - /.../MD5.cpp: error: mbedtls_md5_star...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: mbedtls-3
  Show dependency tree
 
Reported: 2021-07-29 08:05 UTC by Toralf Förster
Modified: 2022-12-21 11:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.36 KB, text/plain)
2021-07-29 08:05 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,273.73 KB, text/plain)
2021-07-29 08:05 UTC, Toralf Förster
Details
environment (environment,109.81 KB, text/plain)
2021-07-29 08:05 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,52.45 KB, application/x-bzip)
2021-07-29 08:05 UTC, Toralf Förster
Details
games-emulation:dolphin-5.0_p20210506:20210728-212326.log (games-emulation:dolphin-5.0_p20210506:20210728-212326.log,155.16 KB, text/plain)
2021-07-29 08:05 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,8.19 KB, application/x-bzip)
2021-07-29 08:05 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,34.38 KB, application/x-bzip)
2021-07-29 08:05 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-07-29 08:05:49 UTC
/var/tmp/portage/games-emulation/dolphin-5.0_p20210506/work/dolphin-5.0_p20210506/Source/Core/Common/MD5.cpp: In function ‘std::string MD5::MD5Sum(const string&, std::function<bool(int)>)’:
/var/tmp/portage/games-emulation/dolphin-5.0_p20210506/work/dolphin-5.0_p20210506/Source/Core/Common/MD5.cpp:29:3: error: ‘mbedtls_md5_starts_ret’ was not declared in this scope; did you mean ‘mbedtls_md5_starts’?
   29 |   mbedtls_md5_starts_ret(&ctx);
      |   ^~~~~~~~~~~~~~~~~~~~~~
      |   mbedtls_md5_starts
/var/tmp/portage/games-emulation/dolphin-5.0_p20210506/work/dolphin-5.0_p20210506/Source/Core/Common/MD5.cpp:37:5: error: ‘mbedtls_md5_update_ret’ was not declared in this scope; did you mean ‘mbedtls_md5_update’?

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop-j3_debug-20210725-175241

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.1.0 *
/usr/lib/llvm/12
12.0.1
Python 3.9.6
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.53.0 *
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.292_p10 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  HEAD of ::gentoo
commit 5cfa384719b084ce24550cd993da9325c2c52b74
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Wed Jul 28 20:36:47 2021 +0000

    2021-07-28 20:36:46 UTC

emerge -qpvO games-emulation/dolphin
[ebuild   R   ] games-emulation/dolphin-5.0_p20210506  USE="alsa bluetooth evdev -discord-presence -doc -ffmpeg -log -lto -profile -pulseaudio -qt5 -systemd -upnp -vulkan"
Comment 1 Toralf Förster gentoo-dev 2021-07-29 08:05:50 UTC
Created attachment 727635 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-07-29 08:05:52 UTC
Created attachment 727638 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-07-29 08:05:53 UTC
Created attachment 727641 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-07-29 08:05:54 UTC
Created attachment 727644 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-07-29 08:05:56 UTC
Created attachment 727647 [details]
games-emulation:dolphin-5.0_p20210506:20210728-212326.log
Comment 6 Toralf Förster gentoo-dev 2021-07-29 08:05:57 UTC
Created attachment 727650 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2021-07-29 08:05:58 UTC
Created attachment 727653 [details]
temp.tar.bz2
Comment 8 Sergei Trofimovich (RETIRED) gentoo-dev 2021-07-29 09:01:28 UTC
It's more likely a "2021-07-28T23:22:21 >>> net-libs/mbedtls-3.0.0".
Comment 9 Sergei Trofimovich (RETIRED) gentoo-dev 2021-07-29 09:21:24 UTC
Does mbedtls have a tracker to handle porting to mbedtls-3?
Comment 10 Sergei Trofimovich (RETIRED) gentoo-dev 2021-07-29 10:45:47 UTC
I'm also very confused by API change:

mbedtls-2.26.0:
/**
 * \brief          MD5 context setup
 *
 * \param ctx      context to be initialized
 *
 * \return         0 if successful
 */
int mbedtls_md5_starts_ret( mbedtls_md5_context *ctx );

/**
 * \brief          MD5 context setup
 *
 * \deprecated     Superseded by mbedtls_md5_starts_ret() in 2.7.0
 *
 * \param ctx      context to be initialized
 */
MBEDTLS_DEPRECATED void mbedtls_md5_starts( mbedtls_md5_context *ctx );

mbedtls-3:

/**
 * \brief          MD5 context setup
 *
 * \param ctx      context to be initialized
 *
 * \return         0 if successful
 */
int mbedtls_md5_starts( mbedtls_md5_context *ctx );

(from new mbedtls/compat-2.x.h)

#define mbedtls_md5_starts_ret        mbedtls_md5_starts

It looks like instead of moving away deprecated symbol the non-deprecated one was completely removed.
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-12 11:04:59 UTC
Any idea if this is fixed upstream or reported there at least yet?
Comment 12 Ionen Wolkens gentoo-dev 2022-11-12 11:30:12 UTC
May possibly be given the md5 code was first moved, and then replaced by sha1 -- if it still fails on latest it'll be on something else.

Albeit their bundled mbedtls is still 2.28.0.
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-12-21 11:09:19 UTC
Unsurprisingly, "something else" is:

/tmp/portage/games-emulation/dolphin-5.0_p20220520-r1/work/dolphin-0f2540a0d1133950467845f20b1e003181147781/Source/Core/Core/DolphinAnalytics.cpp: In member function ‘std::string DolphinAnalytics::MakeUniqueId(std::string_view) const’:
/tmp/portage/games-emulation/dolphin-5.0_p20220520-r1/work/dolphin-0f2540a0d1133950467845f20b1e003181147781/Source/Core/Core/DolphinAnalytics.cpp:105:3: error: ‘mbedtls_sha1_ret’ was not declared in this scope; did you mean ‘mbedtls_sha1_free’?
  105 |   mbedtls_sha1_ret(reinterpret_cast<const u8*>(input.c_str()), input.size(), digest.data());
      |   ^~~~~~~~~~~~~~~~
      |   mbedtls_sha1_free
Comment 14 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-12-21 11:15:15 UTC
Actually, there are more and upstream's still at 2.x.