Looking at current installed catalayst I noticed that custom_kopts was used before being assigned, maybe not used at all? this potentially affects ia64|ppc*|powerpc*|sparc*|x86|amd64 Reproducible: Always Steps to Reproduce: Do not have a usecase, just inspecting code, sorry Actual Results: https://gitweb.gentoo.org/proj/catalyst.git/tree/targets/support/bootloader-setup.sh?h=catalyst-3.0-stable Line ~26 custom_kopts is used to set default_append_line custom_kopts is updated further down, but never used (default_append_line not updated) Expected Results: custom_kopts should be used after assignment, default_append_line should probably not contain custom_kopts at all. Or maybe the whole custom_kopts part should removed in its entirety
Thanks. I did some git archeology, and as far as I can tell custom_kopts has *never* been used in targets/support/bootloader-setup.sh. As far as I can tell, this script was sort of a fork of livecd/runscript/x86-archscript.sh which was removed in: commit 1fcca24724e5b00fd538e8d701733bf30d223efa Author: Eric Edgar <rocket@gentoo.org> Date: Tue Apr 5 21:26:27 2005 +0000 Removed these as they are moved to the appropriate target directories It actually did use custom_kopts. I'll send a patch to remove the custom_kopts variable.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=6976c5fe167b7949c8a33edace8cd93fd87e8dcd commit 6976c5fe167b7949c8a33edace8cd93fd87e8dcd Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2021-07-29 01:07:33 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2021-07-29 01:07:33 +0000 targets: Remove dead custom_kopts variable It looks like this has been dead since 2005. Closes: https://bugs.gentoo.org/804591 Fixes: 1fcca247 ("Removed these as they are moved to the appropriate target directories") Signed-off-by: Matt Turner <mattst88@gentoo.org> targets/support/bootloader-setup.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
