Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 802924 - dev-libs/rocm-opencl-runtime doesn't need ocaml
Summary: dev-libs/rocm-opencl-runtime doesn't need ocaml
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-07-19 14:48 UTC by Alex Xu (Hello71)
Modified: 2022-02-11 16:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Xu (Hello71) 2021-07-19 14:48:36 UTC
I couldn't find any *.ml* files, or references to ocaml or findlib in source tree. It builds and runs OK for me without ocaml.

In original 2.6 version, the README.md specified ocaml and findlib, but apparently did not actually require them either. It was added in https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/commit/3dd2be036c44f46858288bcc8aac41f82c651ad6 with no clear reason. I guess maybe confused with another package?

Anyways, this reference was removed in 3.5 rebase, so I think it is definitely not valid now.
Comment 1 Craig Andrews gentoo-dev 2021-07-19 18:16:32 UTC
Thank you!
Comment 2 Larry the Git Cow gentoo-dev 2021-07-20 01:07:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff8a60339c12e8e6b13fffe789b7a5973671d929

commit ff8a60339c12e8e6b13fffe789b7a5973671d929
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2021-07-19 18:16:24 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2021-07-20 01:07:30 +0000

    dev-libs/rocm-opencl-runtime: remove unnecessary ocaml dependency
    
    Closes: https://bugs.gentoo.org/802924
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-3.10.0.ebuild | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-3.8.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-3.9.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.0.0.ebuild  | 1 -
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.1.0.ebuild  | 1 -
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.2.0.ebuild  | 1 -
 6 files changed, 3 insertions(+), 9 deletions(-)
Comment 3 Alex Xu (Hello71) 2021-07-20 12:29:31 UTC
this is not right change... what is findlib useful for without ocaml?
Comment 4 Larry the Git Cow gentoo-dev 2021-12-26 13:44:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b354ac2d8ce10af0ded05ebf027cd60fc1f0ba1a

commit b354ac2d8ce10af0ded05ebf027cd60fc1f0ba1a
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2021-12-26 13:43:30 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2021-12-26 13:43:30 +0000

    dev-libs/rocm-opencl-runtime: remove dev-ml/findlib from DEPEND.
    
    Suggested-by: Alex Xu
    Closes: https://bugs.gentoo.org/802924
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-3.10.0.ebuild | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-3.8.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-3.9.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.0.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.1.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.2.0.ebuild  | 3 +--
 dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-4.3.0.ebuild  | 3 +--
 7 files changed, 7 insertions(+), 14 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2022-02-11 16:12:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2a17410775f2c569c1e091decfe41467680deef

commit d2a17410775f2c569c1e091decfe41467680deef
Author:     Fco Javier Felix <ffelix@inode64.com>
AuthorDate: 2022-02-11 16:09:22 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-02-11 16:12:44 +0000

    sys-devel/llvm-roc: bump to 4.5.2
    
    Closes: https://bugs.gentoo.org/802924
    Package-Manager: Portage-3.0.28-r1, Repoman-3.0.3-r1
    Signed-off-by: Fco. Javier Felix <ffelix@inode64.com>
    Closes: https://github.com/gentoo/gentoo/pull/23343
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-devel/llvm-roc/Manifest                        |   1 +
 .../files/llvm-roc-4.5.2-add_libraries.patch       |  11 ++
 .../files/llvm-roc-4.5.2-hip-location.patch        | 188 +++++++++++++++++++++
 sys-devel/llvm-roc/llvm-roc-4.5.2.ebuild           |  97 +++++++++++
 4 files changed, 297 insertions(+)