In the `PATCHES=()` section all patches begin with `"${FILESDIR}/${PN}-` with the exception of the final patch `"${FILESDIR}/dhcp-`.
I agree it’s a minor style issue, but does it cause an actual problem for you..?
(In reply to Sam James from comment #1) > I agree it’s a minor style issue, but does it cause an actual problem for > you..? I thank you for your quick reply. It most certainly isn't a problem cause for me, and it definitely isn't a bug, so I was unsure how should I report similar stylistic issues. Hopefully reporting them here isn't a bother? Thanks again!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7963dc6e972c419a8001ec70d852bcc519581eda commit 7963dc6e972c419a8001ec70d852bcc519581eda Author: Sam James <sam@gentoo.org> AuthorDate: 2021-07-20 01:02:54 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-07-20 01:24:26 +0000 net-misc/dhcp: don't hardcode PN in patch filename Match existing style. Closes: https://bugs.gentoo.org/802804 Signed-off-by: Sam James <sam@gentoo.org> net-misc/dhcp/dhcp-4.4.2_p1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(In reply to Firas Khalil Khana from comment #2) > (In reply to Sam James from comment #1) > > I agree it’s a minor style issue, but does it cause an actual problem for > > you..? > > I thank you for your quick reply. > > It most certainly isn't a problem cause for me, and it definitely isn't a > bug, so I was unsure how should I report similar stylistic issues. > > Hopefully reporting them here isn't a bother? > > Thanks again! Sure, no problem at all, thanks for the report! My only suggestion would be to either: 1) attach a patch (from git format-patch, with GCO sign off, so we can just apply it) or 2) make a github PR so it's easier to fix.
