Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 802531 - net-fs/samba, sys-libs/tevent, sys-libs/ldb: unconditional dependency on dev-util/cmocka
Summary: net-fs/samba, sys-libs/tevent, sys-libs/ldb: unconditional dependency on dev-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-17 03:39 UTC by Sam James
Modified: 2023-02-24 10:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-17 03:39:54 UTC
dev-util/cmocka seems an unusual unconditional dependency. It looks like it's only used for testing (naturally) but the build system checks for it even if we're not going to run tests.

I suggest we allow "using" the bundled version when USE=-test (which won't ever actually be used for anything) to avoid the system dependency.
Comment 1 Matthew Smith gentoo-dev 2021-09-24 16:17:36 UTC
*** Bug 814578 has been marked as a duplicate of this bug. ***
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-24 23:19:33 UTC
Same for net-fs/samba.
Comment 3 Larry the Git Cow gentoo-dev 2022-09-30 03:49:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9fb78a8af3fe51b6f28f3cd4bfe0ddaef0639b8

commit c9fb78a8af3fe51b6f28f3cd4bfe0ddaef0639b8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-30 03:47:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-30 03:48:00 +0000

    sys-libs/tevent: add 0.13.0, conditionally depend on cmocka
    
    Conditionally depend on cmocka by "using" the bundled copy
    when we're not running tests (just to satisfy configure).
    
    Closes: https://bugs.gentoo.org/802531
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/tevent/Manifest             |  1 +
 sys-libs/tevent/tevent-0.13.0.ebuild | 89 ++++++++++++++++++++++++++++++++++++
 2 files changed, 90 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60cae9e5131fb42796cdacf8a10b20738d3cf783

commit 60cae9e5131fb42796cdacf8a10b20738d3cf783
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-30 03:23:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-30 03:47:59 +0000

    net-fs/samba: conditionally depend on cmocka
    
    - Conditionally depend on cmocka by "using" the bundled copy
    when we're not running tests (just to satisfy configure).
    
    - Tidy up ebuild a bit while here.
    
    Closes: https://bugs.gentoo.org/802531
    Signed-off-by: Sam James <sam@gentoo.org>

 ...{samba-4.16.5.ebuild => samba-4.16.5-r1.ebuild} | 43 +++++++++++-----------
 1 file changed, 22 insertions(+), 21 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-09-30 04:18:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73e739c37f444c45aa549bc5688ca58c693dc505

commit 73e739c37f444c45aa549bc5688ca58c693dc505
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-30 04:13:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-30 04:18:41 +0000

    sys-libs/ldb: add 2.6.1, conditionally depend on cmocka, add version checker
    
    - Conditionally depend on cmocka by "using" the bundled copy
    when we're not running tests (just to satisfy configure).
    
    - Add talloc/tdb/tevent version checker.
      Nabbed Ionen's sed from wine-proton etc.
    
    Closes: https://bugs.gentoo.org/802531
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/ldb/Manifest         |   1 +
 sys-libs/ldb/ldb-2.6.1.ebuild | 167 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 168 insertions(+)
Comment 5 Garry Filakhtov 2023-02-24 09:58:46 UTC
sys-libs/ldb does the same and requires a similar treatment.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-24 10:00:49 UTC
(In reply to Garry Filakhtov from comment #5)
> sys-libs/ldb does the same and requires a similar treatment.

>= 2.6.1 does it. You're asking for me to backport the improvements to older versions? I guess I can do that.
Comment 7 Garry Filakhtov 2023-02-24 10:02:40 UTC
Oh, sorry, I missed that, because it wasn't referenced in the title! All good.
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-24 10:05:23 UTC
Oh I see! I'll fix that now :)