Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80148 - [PATCH] Add last successful snapshot date support to emerge-webrsync
Summary: [PATCH] Add last successful snapshot date support to emerge-webrsync
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-30 17:02 UTC by James Roberts-Thomson
Modified: 2009-06-08 06:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to emerge-webrsymc, which adds last successful date support etc (emerge-webrsync.patch,5.39 KB, patch)
2005-01-30 17:06 UTC, James Roberts-Thomson
Details | Diff
Corrected patch (emerge-webrsync.patch,6.32 KB, patch)
2005-01-30 17:36 UTC, James Roberts-Thomson
Details | Diff
Third attempt to generate a patch to emerge-webrsync (emerge-webrsync.patch,5.47 KB, patch)
2005-01-31 16:03 UTC, James Roberts-Thomson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Roberts-Thomson 2005-01-30 17:02:57 UTC
The recent portage snapshot issues (Bug #79455) showed a weakness in emerge-webrsync, in that it will fetch and sync against a previously-installed snapshot, as it doesn't track the last "successful" snapshot.

I have made some changes to the script to do this (and also slightly improved help, and fixing of another couple of issues that annoy me), and submit this patch for inclusion in the original source.

Reproducible: Always
Steps to Reproduce:




Expected Results:  
Portage should not try to download a snapshot it has already used.
Comment 1 James Roberts-Thomson 2005-01-30 17:06:22 UTC
Created attachment 50009 [details, diff]
Patch to emerge-webrsymc, which adds last successful date support etc

This patch will add "last successful date" support, by recording the date of
the last successful snapshot download into /var/lib/portage/webrsync-date.  The
patch also adds help (-h) support, and fixes one or two minor things that irk
me about the current script.
Comment 2 James Roberts-Thomson 2005-01-30 17:36:20 UTC
Created attachment 50025 [details, diff]
Corrected patch

Whoops, the last version of the patch missed the line which updates the stored
date - now corrected.
Comment 3 James Roberts-Thomson 2005-01-31 16:03:17 UTC
Created attachment 50086 [details, diff]
Third attempt to generate a patch to emerge-webrsync

Brain obviously asleep the previous day - this patch should work.
Comment 4 Jason Stubbs (RETIRED) gentoo-dev 2005-07-28 07:24:45 UTC
Putting a hold on feature requests for portage as they are drowning out the 
bugs. Most of these features should be available in the next major version of 
portage. But for the time being, they are just drowning out the major bugs and 
delaying the next version's progress. 
 
Any bugs that contain patches and any bugs for etc-update or dispatch-conf can 
be reopened. Sorry, I'm just not good enough with bugzilla. ;) 
Comment 5 Marius Mauch (RETIRED) gentoo-dev 2007-01-11 14:31:13 UTC
Reopening for consideration.
Comment 6 James Roberts-Thomson 2007-01-11 19:52:45 UTC
In the time since this bug was initially raised, I've also made some other minor changes to my own copy of "emerge-webrsync"; the main one is the use of a tmpfs filesystem to unpack the downloaded tarball into (since I have plenty of RAM and this prevents disk IO contention).

Would you like me to update the attached patch with a newly generated one with these features as well?