Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 800863 - net-misc/nextcloud-client-3.2.3: QtWebengine is now an optional dependency
Summary: net-misc/nextcloud-client-3.2.3: QtWebengine is now an optional dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
: 800896 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-07-06 15:03 UTC by FlyingWaffle
Modified: 2021-07-07 19:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with the change (nextcloud-client-3.2.3.ebuild,1.96 KB, text/plain)
2021-07-06 15:03 UTC, FlyingWaffle
Details
backport optional webengine patch (3.2.3-optional-webengine.patch,15.64 KB, patch)
2021-07-06 18:53 UTC, FlyingWaffle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description FlyingWaffle 2021-07-06 15:03:38 UTC
Created attachment 722404 [details]
ebuild with the change

QtWebengine is an optional dependency as of this merge: https://github.com/nextcloud/desktop/pull/3471

Only required change is adding the USE flag since they didn't add an explicit compile option.  Ebuild attached.
Comment 1 Bernard Cafarelli gentoo-dev 2021-07-06 17:35:03 UTC
This is good news! Though we will need to wait for 3.2.x stable backport or new major release, as this is currently only in master (you can see in src/CMakeLists.txt we still have WebEngineWidgets WebEngine REQUIRED)

It is sad the configure option WITH_WEBENGINE from initial patch was not kept, though with some cmake hacks we may be able to still force a configure option - setting Qt5WebEngine_FOUND to false, or worst case by patching it
Comment 2 FlyingWaffle 2021-07-06 18:53:20 UTC
Created attachment 722419 [details, diff]
backport optional webengine patch

(In reply to Bernard Cafarelli from comment #1)
> This is good news! Though we will need to wait for 3.2.x stable backport or
> new major release, as this is currently only in master (you can see in
> src/CMakeLists.txt we still have WebEngineWidgets WebEngine REQUIRED)
> 
> It is sad the configure option WITH_WEBENGINE from initial patch was not
> kept, though with some cmake hacks we may be able to still force a configure
> option - setting Qt5WebEngine_FOUND to false, or worst case by patching it

Ah, whoops; I got too excited and didn't realize that the change hadn't been merged into a release branch yet.  I've attached my personal backport patch that works for 3.2.x; it uses the WITH_WEBENGINE option as well.
Comment 3 Marco Scardovi (scardracs) 2021-07-06 19:17:45 UTC
*** Bug 800896 has been marked as a duplicate of this bug. ***
Comment 4 Bernard Cafarelli gentoo-dev 2021-07-07 18:49:46 UTC
OK let's get this in :) Final patch is not too large, and cmake allows to override cleanly that Qt5WebEngine_FOUND variable, like in:
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-apps/marble/marble-21.04.2.ebuild#n87

I spotted some enhancements to the build system and ebuild too, once done -r1 should have webengine optional
Comment 5 Larry the Git Cow gentoo-dev 2021-07-07 19:16:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e05aaacaa41045d2f7b08efe61899a0087e699b

commit 9e05aaacaa41045d2f7b08efe61899a0087e699b
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2021-07-07 19:16:04 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2021-07-07 19:16:17 +0000

    net-misc/nextcloud-client: make qtwebengine optional
    
    This large dependency is not needed for most current authentications
    
    Also updated many build options (doc, dolphin and nautilus integration)
    
    Closes: https://bugs.gentoo.org/800863
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../files/nextcloud-client-3.2.3-webengine.patch   | 419 +++++++++++++++++++++
 net-misc/nextcloud-client/metadata.xml             |   1 +
 .../nextcloud-client-3.2.3-r1.ebuild               |  94 +++++
 3 files changed, 514 insertions(+)