Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 800668 - net-dialup/ppp-2.4.9-r3: Acct Session ID not formatted correctly
Summary: net-dialup/ppp-2.4.9-r3: Acct Session ID not formatted correctly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: https://github.com/ppp-project/ppp/is...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-07-05 14:28 UTC by Ian Coetzee
Modified: 2021-07-13 09:22 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Coetzee 2021-07-05 14:28:17 UTC
Due to, what seems to be, an upstream related bug. pppd is not formatting the Acct-Session-ID correctly when sending the Acct packet to the radius server.

Compare the Act-Session-Id field from a 2.4.9 pppd session

(11) Received Accounting-Request Id 116 from 127.0.0.1:57872 to 127.0.0.1:1813 length 154
(11)   Acct-Session-Id = "%lX60e2f023%hX"

to one from 2.4.8

16:05:58.121266 IP (tos 0x0, ttl 64, id 42010, offset 0, flags [DF], proto UDP (17), length 179)
    127.0.0.1.43973 > 127.0.0.1.1813: RADIUS, length: 151
        Accounting-Request (4), id: 0x2c, Authenticator: cb3ff3b110dfc03aadbad5d14183b7bc
          Acct-Session-Id Attribute (44), length: 16, Value: 60E311894F6500

Rollback to net-dialup/ppp-2.4.8-r1 solved the issue for us

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-12 06:18:39 UTC
Can you verify https://github.com/ppp-project/ppp/commit/301230f8fde94b5b80e9dfba51816ede340e6b64 fixes the issue?

(Put https://github.com/ppp-project/ppp/commit/301230f8fde94b5b80e9dfba51816ede340e6b64.patch in /etc/portage/patches/net-dialup/ppp/bug800668.patch and re-emerge).
Comment 2 Jaco Kroon 2021-07-12 08:36:48 UTC
Hi Sam,

tauri ~ # wget https://github.com/ppp-project/ppp/commit/301230f8fde94b5b80e9dfba51816ede340e6b64.patch -O /etc/portage/patches/net-dialup/ppp/bug800668.patch
...
tauri ~ # emerge -1av ppp
...
 * Applying 40-ppp-gigawords-support.patch ...
patching file pppd/plugins/radius/radius.c
Hunk #2 FAILED at 957.
Hunk #3 succeeded at 1014 (offset 7 lines).
...
 * Enabling CBCP
 * Applying bug800668.patch ...                                                              [ ok ]
 * User patches applied.
...
>>> Configuring source in /var/tmp/portage/net-dialup/ppp-2.4.9-r3/work/ppp-ppp-2.4.9 ...
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64
./configure: line 10: CC: command not found
./configure: line 23: CFLAGS: command not found
Configuring for Linux
Creating Makefiles.
...

And yes, we can confirm this does solve the issue.
Comment 3 Larry the Git Cow gentoo-dev 2021-07-13 09:22:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7fb43f73a44554b3db5e876a22f9e74446d494b

commit a7fb43f73a44554b3db5e876a22f9e74446d494b
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-07-13 09:19:45 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-07-13 09:22:27 +0000

    net-dialup/ppp: Revbump to fix Acct Session ID in radius
    
    Bumped straight to stable
    
    Thanks-to: Jaco Kroon <jaco@uls.co.za>
    Closes: https://bugs.gentoo.org/800668
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-dialup/ppp/Manifest                                     | 2 +-
 net-dialup/ppp/{ppp-2.4.9-r3.ebuild => ppp-2.4.9-r4.ebuild} | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)