Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 800100 - media-sound/pulseeffects: optfeature "viewing the docs" gnome-extra/yelp
Summary: media-sound/pulseeffects: optfeature "viewing the docs" gnome-extra/yelp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-03 00:19 UTC by mehw
Modified: 2021-07-17 03:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mehw 2021-07-03 00:19:38 UTC
The help requires gnome-extra/yelp.

Please, add the required optfeature.

i.e.:

diff -Nuar pulseeffects-5.0.4.ebuild pulseeffects-5.0.4-r1.ebuild
--- pulseeffects-5.0.4.ebuild	2021-06-27 10:41:23.573297631 +0000
+++ pulseeffects-5.0.4-r1.ebuild	2021-07-03 00:13:51.357483396 +0000
@@ -3,7 +3,7 @@
 
 EAPI=7
 
-inherit gnome2-utils meson
+inherit gnome2-utils meson optfeature
 
 DESCRIPTION="Limiter, compressor, reverberation, equalizer auto volume effects for Pulseaudio"
 HOMEPAGE="https://github.com/wwmm/pulseeffects"
@@ -58,6 +58,8 @@
 "
 
 pkg_postinst() {
+	optfeature "viewing the docs" gnome-extra/yelp
+
 	gnome2_gconf_install
 	gnome2_schemas_update
 	xdg_icon_cache_update
Comment 1 Andreas Sturmlechner gentoo-dev 2021-07-03 10:56:39 UTC
Either it is required, then it is an unconditional RDEPEND.
Or it is optional, then it can be an optfeature.
Comment 2 mehw 2021-07-03 16:22:11 UTC
(In reply to Andreas Sturmlechner from comment #1)
> Either it is required, then it is an unconditional RDEPEND.
> Or it is optional, then it can be an optfeature.

Without gnome-extra/yelp the HELP button doesn't open the help documentation...
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2021-07-03 19:54:53 UTC
it seems like more of a hard requirement
Comment 4 Larry the Git Cow gentoo-dev 2021-07-03 19:57:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=239e00a147fcf43c65d2d779d63068545cf52fd5

commit 239e00a147fcf43c65d2d779d63068545cf52fd5
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2021-07-03 19:57:07 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2021-07-03 19:57:07 +0000

    media-sound/pulseeffects: add yelp dep for help docs
    
    Closes: https://bugs.gentoo.org/800100
    Package-Manager: Portage-3.0.20, Repoman-3.0.2
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 media-sound/pulseeffects/pulseeffects-9999.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)