Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 799827 - xfce-extra/xfce4-wavelan-plugin-0.6.2-r1: stabilisation (was: wi_linux.c: error: conflicting types for close; have void(int))
Summary: xfce-extra/xfce4-wavelan-plugin-0.6.2-r1: stabilisation (was: wi_linux.c: err...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: XFCE Team
URL: https://gitlab.xfce.org/panel-plugins...
Whiteboard:
Keywords: CC-ARCHES, PATCH
Depends on:
Blocks:
 
Reported: 2021-07-02 07:10 UTC by Toralf Förster
Modified: 2022-01-03 09:17 UTC (History)
2 users (show)

See Also:
Package list:
xfce-extra/xfce4-wavelan-plugin-0.6.2-r1
Runtime testing required: ---
nattka: sanity-check+


Attachments
emerge-info.txt (emerge-info.txt,16.76 KB, text/plain)
2021-07-02 07:10 UTC, Toralf Förster
no flags Details
emerge-history.txt (emerge-history.txt,165.40 KB, text/plain)
2021-07-02 07:10 UTC, Toralf Förster
no flags Details
environment (environment,19.95 KB, text/plain)
2021-07-02 07:10 UTC, Toralf Förster
no flags Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,19.32 KB, application/x-bzip)
2021-07-02 07:10 UTC, Toralf Förster
no flags Details
logs.tar.bz2 (logs.tar.bz2,10.18 KB, application/x-bzip)
2021-07-02 07:10 UTC, Toralf Förster
no flags Details
temp.tar.bz2 (temp.tar.bz2,10.69 KB, application/x-bzip)
2021-07-02 07:11 UTC, Toralf Förster
no flags Details
xfce-extra:xfce4-wavelan-plugin-0.6.2:20210701-224823.log (xfce-extra:xfce4-wavelan-plugin-0.6.2:20210701-224823.log,32.65 KB, text/plain)
2021-07-02 07:11 UTC, Toralf Förster
no flags Details
It does what its name suggests, it removes a false function from the file 'panel-plugin/wi_linux.c'. The modification in the file belongs to upstream. (remove-bogus-close-function.patch,892 bytes, patch)
2021-12-14 22:51 UTC, Remus-Gabriel Chelu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-07-02 07:10:52 UTC
Generating and caching the translation database
Merging translations into wavelan.desktop.
wi_linux.c:83:1: error: conflicting types for ‘close’; have ‘void(int)’
   83 | close(int fd)
      | ^~~~~
In file included from /usr/include/glib-2.0/gio/gcredentials.h:32,
                 from /usr/include/glib-2.0/gio/gio.h:46,

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-j3-20210629-092836

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.1.0 *
clang version 12.0.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/12/bin
/usr/lib/llvm/12
12.0.0
Python 3.9.6
Available Ruby profiles:
  (none found)
Available Rust versions:
  [1]   rust-1.53.0 *
The following VMs are available for generation-2:
1)	IcedTea JDK 3.16.0 [icedtea-bin-8]
*)	AdoptOpenJDK 8.292_p10 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8 
  [2]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4
  HEAD of ::gentoo
commit 2909a4f6afee763c29448bc8685b8e7776491b14
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Thu Jul 1 22:21:44 2021 +0000

    2021-07-01 22:21:43 UTC

emerge -qpvO xfce-extra/xfce4-wavelan-plugin
[ebuild  N    ] xfce-extra/xfce4-wavelan-plugin-0.6.2
Comment 1 Toralf Förster gentoo-dev 2021-07-02 07:10:53 UTC
Created attachment 720900 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-07-02 07:10:55 UTC
Created attachment 720903 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-07-02 07:10:56 UTC
Created attachment 720906 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-07-02 07:10:57 UTC
Created attachment 720909 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-07-02 07:10:59 UTC
Created attachment 720912 [details]
logs.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2021-07-02 07:11:00 UTC
Created attachment 720915 [details]
temp.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2021-07-02 07:11:01 UTC
Created attachment 720918 [details]
xfce-extra:xfce4-wavelan-plugin-0.6.2:20210701-224823.log
Comment 9 Remus-Gabriel Chelu 2021-12-14 22:51:07 UTC
Created attachment 759019 [details, diff]
It does what its name suggests, it removes a false function from the file 'panel-plugin/wi_linux.c'. The modification in the file belongs to upstream.
Comment 10 Remus-Gabriel Chelu 2021-12-14 22:53:46 UTC
(In reply to Sam James from comment #8)
> https://gitlab.xfce.org/panel-plugins/xfce4-wavelan-plugin/-/merge_requests/4

Thanks for the link, Sam James! I have created the patch: remove-bogus-close-function.patch; and it has worked.
Comment 11 Larry the Git Cow gentoo-dev 2021-12-14 23:37:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cfeef27953f5c1b66bfbb270ce8b7a444899850

commit 1cfeef27953f5c1b66bfbb270ce8b7a444899850
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-12-14 23:36:27 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-14 23:36:32 +0000

    xfce-extra/xfce4-wavelan-plugin: update EAPI 7 -> 8, add build patch
    
    Revbumping for EAPI 8 + the build patch given that it could (but shouldn't)
    affect runtime behaviour.
    
    Closes: https://bugs.gentoo.org/799827
    Signed-off-by: Sam James <sam@gentoo.org>

 ...ce4-wavelan-plugin-0.6.2-close-definition.patch | 55 ++++++++++++++++++++++
 .../xfce4-wavelan-plugin-0.6.2-r1.ebuild           | 31 ++++++++++++
 2 files changed, 86 insertions(+)
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-12-14 23:37:23 UTC
(In reply to Remus-Gabriel Chelu from comment #10)
> (In reply to Sam James from comment #8)
> > https://gitlab.xfce.org/panel-plugins/xfce4-wavelan-plugin/-/merge_requests/4
> 
> Thanks for the link, Sam James! I have created the patch:
> remove-bogus-close-function.patch; and it has worked.

Thanks for confirming! I've applied it now :)
Comment 13 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-12-15 00:04:13 UTC
We'll stable soon.
Comment 14 Agostino Sarubbo gentoo-dev 2021-12-26 08:07:41 UTC
amd64 stable
Comment 15 Jakov Smolić archtester gentoo-dev 2022-01-03 09:17:32 UTC
x86 done

all arches done