Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 799362 - games-emulation/vbam-2.1.4: unable to emerge on arm64
Summary: games-emulation/vbam-2.1.4: unable to emerge on arm64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM64 Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-06-30 15:37 UTC by Michał Dec
Modified: 2021-11-07 02:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that fixes the problem (vbam-on-non-x86.patch,447 bytes, patch)
2021-06-30 15:40 UTC, Michał Dec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Dec 2021-06-30 15:37:58 UTC
Compilation crashed because the project incorrectly detects that it's being compiled for x86 Linux

Reproducible: Always

Steps to Reproduce:
1. emerge vbam
Actual Results:  
FAILED: CMakeFiles/vbamcore.dir/src/filters/xBRZ/xbrz.cpp.o 
/usr/bin/aarch64-unknown-linux-gnu-g++ -DBKPT_SUPPORT -DC_CORE -DELF -DENABLE_NLS -DFINAL_VERSION -DGBA_LOGGING -DHAVE_ARPA_INET_H -DHAVE_NETINET_IN_H -DHAVE_ZLIB_H -DLOCALEDIR=\"/usr/share/locale\" -DNDEBUG -DNO_ASM -DNO_FFMPEG -DNO_LINK -DPACKAGE="" -DPKGDATADIR=\"/usr/share/vbam\" -DSDL -DSYSCONF_INSTALL_DIR=\"/etc\" -DUSE_OPENGL -DWITH_LIRC=0 -D_REENTRANT -D__STDC_FORMAT_MACROS -I. -I/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/fex -I/usr/include/SDL2  -march=armv8-a+crc+simd -mtune=cortex-a72 -ftree-vectorize -O2 -pipe -fomit-frame-pointer -fdiagnostics-color=always -pipe -Wformat -Wformat-security -D_FORTIFY_SOURCE=2 -feliminate-unused-debug-types -fPIC -fopenmp -O2 -fomit-frame-pointer -Wno-error -std=gnu++11 -MD -MT CMakeFiles/vbamcore.dir/src/filters/xBRZ/xbrz.cpp.o -MF CMakeFiles/vbamcore.dir/src/filters/xBRZ/xbrz.cpp.o.d  -std=gnu++11 -fexceptions  -o CMakeFiles/vbamcore.dir/src/filters/xBRZ/xbrz.cpp.o -c /var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/filters/xBRZ/xbrz.cpp
/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/filters/xBRZ/xbrz.cpp:69:17: warning: extra tokens at end of #ifdef directive
   69 | #ifdef __GNUC__ || __clang__ || __MINGW64_VERSION_MAJOR || __MINGW32_MAJOR_VERSION
      |                 ^~
/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/filters/xBRZ/xbrz.cpp: In static member function ‘static double {anonymous}::ColorDistanceUnbufferedARGB::dist(uint32_t, uint32_t, double)’:
/var/tmp/portage/games-emulation/vbam-2.1.4/work/visualboyadvance-m-2.1.4/src/filters/xBRZ/xbrz.cpp:70:5: error: impossible constraint in ‘asm’
   70 |     __asm__ ("fsqrt" : "+t" (n));
      |     ^~~~~~~

Expected Results:  
Software emerges successfully
Comment 1 Michał Dec 2021-06-30 15:40:07 UTC
Created attachment 720369 [details, diff]
Patch that fixes the problem

This patch fixes the issue and mimics the behavior from the git commit that fixes the problem upstream https://github.com/visualboyadvance-m/visualboyadvance-m/commit/af0de1c4b308ef8d9a081ecf407805b75a99d877
Comment 2 Larry the Git Cow gentoo-dev 2021-11-07 02:51:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9c52de97ac8da18f8ec9f7863950582aee3e71c

commit d9c52de97ac8da18f8ec9f7863950582aee3e71c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-07 02:50:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-07 02:50:55 +0000

    games-emulation/vbam: fix build on arm(64)
    
    Closes: https://bugs.gentoo.org/799362
    Signed-off-by: Sam James <sam@gentoo.org>

 .../vbam/files/vbam-2.1.4-arm-asm.patch            | 33 ++++++++++++++++++++++
 games-emulation/vbam/vbam-2.1.4.ebuild             |  1 +
 2 files changed, 34 insertions(+)