Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 799092 - net-nds/openldap - bump to 2.5.5 and fix various issues in ebuild
Summary: net-nds/openldap - bump to 2.5.5 and fix various issues in ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2021-06-28 18:05 UTC by Timo Rothenpieler
Modified: 2022-03-19 18:07 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openldap-2.5.5.ebuild (openldap-2.5.5.ebuild,22.95 KB, text/plain)
2021-06-28 18:05 UTC, Timo Rothenpieler
Details
openldap-2.5.5-mdb-unbundle.patch (openldap-2.5.5-mdb-unbundle.patch,4.31 KB, patch)
2021-06-28 18:06 UTC, Timo Rothenpieler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timo Rothenpieler 2021-06-28 18:05:40 UTC
Created attachment 719853 [details]
openldap-2.5.5.ebuild

The ebuild for the new openldap 2.5 version has various issues in it.
Most prominently:


configure: WARNING: unrecognized options: --enable-monitor, --enable-shell, --disable-lmpasswd, --enable-rewrite
checking configure arguments... configure: error: --enable-aci requires --enable-dynacl


I checked the configure.ac file, and it seems like "--enable-aci=mod" does not work to begin with(unconditionally throws an error), and --enable-aci itself needs dynacl.
So I removed aci from being unconditionally enabled.

The other options it warns about appear to be simply removed from openldap. Which also gets rid of the samba useflag in turn.

My fixed version of the ebuild is attached, together with a new version of the lmbd unbundling patch.

Also includes the fixed for building the contrib modules with their respective Makefiles instead of a half-broken homecooked build function.
Comment 1 Timo Rothenpieler 2021-06-28 18:06:09 UTC
Created attachment 719856 [details, diff]
openldap-2.5.5-mdb-unbundle.patch
Comment 2 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-07-18 08:40:25 UTC
Hello Timo!

I am reviewing your changes now, might take some time.
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-07-18 14:56:27 UTC
Hmm I am unable to convert slapd.conf into olc due to 'missing backends', needs more investigation
Comment 4 Timo Rothenpieler 2021-07-21 19:12:04 UTC
Is that an issue with openldap 2.5(.5) itself, or is there an issue in the ebuild causing that?

In any case, I just found a small issue with the ebuild:
with USE=minimal, it stops installing the leftover directory to /var/lib/run.
So a change along the lines of https://github.com/TimoRoth/klima-cluster-overlay/commit/5ba94b714f2828d74b6c3ad6087c952354e26e5a is required.
Comment 5 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-07-23 09:09:34 UTC
(In reply to Timo Rothenpieler from comment #4)
> Is that an issue with openldap 2.5(.5) itself, or is there an issue in the
> ebuild causing that?
> 
> In any case, I just found a small issue with the ebuild:
> with USE=minimal, it stops installing the leftover directory to /var/lib/run.
> So a change along the lines of
> https://github.com/TimoRoth/klima-cluster-overlay/commit/
> 5ba94b714f2828d74b6c3ad6087c952354e26e5a is required.

This one I caught dureng testing of your attachement, also it misses a dependency on libxcrypt if the minimal flag is not used (slapd links to linxcrypt.so). But the most painful thing happens when I try to convert the slapd.conf file into the cn=config olc database with slaptest. it says it can not find any backend :/ (still do not know why)
Comment 6 Larry the Git Cow gentoo-dev 2022-03-19 18:07:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d12a02243969b7c715e9b639345ec8aacd925a28

commit d12a02243969b7c715e9b639345ec8aacd925a28
Author:     Dennis Lamm <expeditioneer@gentoo.org>
AuthorDate: 2022-02-05 23:24:54 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2022-03-19 18:07:51 +0000

    net-nds/openldap 2.6.1 version bump
    
    Closes: https://bugs.gentoo.org/799092
    Bug: https://bugs.gentoo.org/624178
    Bug: https://bugs.gentoo.org/815844
    Bug: https://bugs.gentoo.org/609486
    
    Signed-off-by: Dennis Lamm <expeditioneer@gentoo.org>
    (cherry picked from commit c2e92fe1e144e8563f753a76d9d0cba923bb8878)
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

 net-nds/openldap/Manifest                          |   1 +
 net-nds/openldap/files/openldap-2.6.1-cloak.patch  |  25 +
 .../files/openldap-2.6.1-fix-missing-mapping.patch |  21 +
 net-nds/openldap/files/openldap-2.6.1-flags.patch  | 416 +++++++++++
 .../openldap/files/openldap-2.6.1-system-mdb.patch | 148 ++++
 net-nds/openldap/files/slapd-2.6.1.service         |  12 +
 net-nds/openldap/files/slapd-confd-2.6.1           |  26 +
 net-nds/openldap/metadata.xml                      |   4 +
 net-nds/openldap/openldap-2.6.1.ebuild             | 796 +++++++++++++++++++++
 9 files changed, 1449 insertions(+)