Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 798300 - net-misc/teamviewer-15.19.3-r1: fail to start because of missing EULA files
Summary: net-misc/teamviewer-15.19.3-r1: fail to start because of missing EULA files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Martin Dummer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-06-24 09:01 UTC by Martin Dummer
Modified: 2021-06-25 06:43 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Dummer 2021-06-24 09:01:38 UTC
On a fresh install of teamviewer15, when started the first time, an error message dialogue is displayed with the message:

"Loading EULA/DPA failed
Your TeamViewer installation seems to be broken and cannot be used.
Please reinstall."

After checking with strace, I find the following messages:


openat(AT_FDCWD, "/opt/teamviewer15//doc/EULA_en.txt", O_RDONLY) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/opt/teamviewer15//doc/DPA_en.txt", O_RDONLY) = -1 ENOENT (No such file or directory)


/opt/teamviewer/doc is a symlink to ../../usr/share/doc/teamviewer-15.19.3-r1/doc

So it is obvious that TeamViewer expects his documents in clear text file format, while portage compresses all documents in /usr/share/doc/teamviewer-15.19.3-r1/doc.

Crosschecking: uncompressing these docs manually 

bzip2 --decompress /usr/share/doc/teamviewer-*/doc/EULA_* /usr/share/doc/teamviewer-*/doc/DPA_*

allows me to start TeamViewer and shows the "license agreement" dialogue.

This is not a duplicate of Bug #778617, looks more like the fix is insufficient.
Comment 1 Martin Dummer 2021-06-24 10:33:34 UTC
It looks like "docompress -x" is not recursive.

Proposed fix in the ebuild:

=================================================
--- teamviewer-15.19.3-r1.ebuild        2021-06-24 12:11:30.324752832 +0200
+++ teamviewer-15.19.3-r2.ebuild        2021-06-24 12:16:52.826930628 +0200
@@ -112,7 +112,7 @@
        dosym ../../usr/share/doc/${PF}/doc ${dst}/doc
 
        # We need to keep docs uncompressed, bug #778617
-       docompress -x /usr/share/doc/${PF}/*
+       docompress -x /usr/share/doc/${PF}/doc/
 
        keepdir /etc/${MY_P}
        dosym ../../etc/${MY_P} ${dst}/config
=================================================
Comment 2 Martin Dummer 2021-06-24 11:03:10 UTC
Better fix:
place docs directly in /usr/share/doc/${PF}, no .../doc/ subdirectoy

=================================================
--- teamviewer-15.19.3-r1.ebuild        2021-06-24 12:11:30.324752832 +0200
+++ teamviewer-15.19.3-r2.ebuild        2021-06-24 12:58:05.311682694 +0200
@@ -106,13 +106,13 @@
                newicon -s ${size} tv_bin/desktop/teamviewer_${size}.png teamviewer.png
        done
 
-       dodoc -r doc
+       dodoc -r doc/*
 
        # Make docs available in expected location
-       dosym ../../usr/share/doc/${PF}/doc ${dst}/doc
+       dosym ../../usr/share/doc/${PF}/ ${dst}/doc
 
        # We need to keep docs uncompressed, bug #778617
-       docompress -x /usr/share/doc/${PF}/*
+       docompress -x /usr/share/doc/${PF}/
 
        keepdir /etc/${MY_P}
        dosym ../../etc/${MY_P} ${dst}/config
=================================================
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2021-06-24 13:50:03 UTC
I would really like to understand why it is working for me. It's like bug 778617. I have zero problems. Program works fine :(
Comment 4 Martin Dummer 2021-06-24 14:28:18 UTC
I am sure this happens only when you start teamviewer the VERY first time on a computer. I tried a lot with deleting local configs and logs to reproduce (I accepted EULA in the meantime....) but I cant find it. Maybe it's done by creating the local station ID on first run and transferring it to teamviewer's server in the internet.
Comment 5 Larry the Git Cow gentoo-dev 2021-06-24 15:06:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5848a9b5d29763277ce7ecf14d10061c50e8a6c

commit d5848a9b5d29763277ce7ecf14d10061c50e8a6c
Author:     Martin Dummer <martin.dummer@gmx.net>
AuthorDate: 2021-06-24 13:04:46 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-06-24 15:06:41 +0000

    net-misc/teamviewer: fix compression of doc files
    
    When teamviewer starts on new installation, it likes to display a
    license agreement dialogue. This fails when documentation files are
    compressed. fixed.
    
    Adopt package, change maintainer-needed -> @me
    
    Additionally, adjust dependencies.
    
    Closes: https://bugs.gentoo.org/798300
    Package-Manager: Portage-3.0.20, Repoman-3.0.2
    Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
    Closes: https://github.com/gentoo/gentoo/pull/21404
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 net-misc/teamviewer/metadata.xml                                 | 9 ++++++++-
 ...teamviewer-15.19.3-r1.ebuild => teamviewer-15.19.3-r2.ebuild} | 6 +++---
 2 files changed, 11 insertions(+), 4 deletions(-)