Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 797688 - dev-util/diffoscope-177 fails tests tests/comparators/test_docx.py, tests/comparators/test_ico_image.py, and tests/comparators/test_jpeg_image.py
Summary: dev-util/diffoscope-177 fails tests tests/comparators/test_docx.py, tests/com...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2021-06-23 02:05 UTC by Jonathan Lovelace
Modified: 2021-06-23 07:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-util:diffoscope-177:20210623-014726.log (dev-util:diffoscope-177:20210623-014726.log,106.22 KB, text/plain)
2021-06-23 02:05 UTC, Jonathan Lovelace
Details
emerge-info.txt (emerge-info.txt,8.26 KB, text/plain)
2021-06-23 02:05 UTC, Jonathan Lovelace
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lovelace 2021-06-23 02:05:29 UTC
Created attachment 717774 [details]
dev-util:diffoscope-177:20210623-014726.log

=dev-util/diffoscope-177 fails 9 tests on my machines, tests/comparators/test_docx.py::test_diff and test_diff, test_diff_meta, test_diff_meta2, and test_has_visuals under tests/comparators/test_ico_image.py and tests/comparators/test_jpeg_image.py.

Since the bulk of the test failures are in image-comparison tests, I tried disabling USE=imagemagick, but it still ran and failed those tests.

Full build log and emerge --info attached.
Comment 1 Jonathan Lovelace 2021-06-23 02:05:53 UTC
Created attachment 717777 [details]
emerge-info.txt
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2021-06-23 06:26:12 UTC
Let's post here full list of failures:

FAILED tests/comparators/test_docx.py::test_diff - AssertionError: assert '@@ -1,2 +1,2 @@\n-a\n+b\n \n' == '@@ -1 +1 @@\n-...
FAILED tests/comparators/test_ico_image.py::test_diff - IndexError: list index out of range
FAILED tests/comparators/test_ico_image.py::test_diff_meta - IndexError: list index out of range
FAILED tests/comparators/test_ico_image.py::test_diff_meta2 - IndexError: list index out of range
FAILED tests/comparators/test_ico_image.py::test_has_visuals - assert 0 == 2
FAILED tests/comparators/test_jpeg_image.py::test_diff - IndexError: list index out of range
FAILED tests/comparators/test_jpeg_image.py::test_compare_non_existing - assert 0 > 0
FAILED tests/comparators/test_jpeg_image.py::test_diff_meta - IndexError: list index out of range
FAILED tests/comparators/test_jpeg_image.py::test_has_visuals - assert 0 == 2

And a bit of context for one of them:

tests/comparators/test_jpeg_image.py:70: AssertionError
_______________________________________________________ test_diff_meta _______________________________________________________

differences_meta = []

    @skip_unless_tools_exist("img2txt", "identify")
    @skip_unless_tool_is_at_least("identify", identify_version, "6.9.6")
    def test_diff_meta(differences_meta):
        expected_diff = get_data("jpeg_image_meta_expected_diff")
>       assert differences_meta[-1].unified_diff == expected_diff
E       IndexError: list index out of range

differences_meta = []
expected_diff = ('@@ -1,20 +1,20 @@\n'
 ' Image format: JPEG\n'
 '-File size: 662B\n'
 '+File size: 627B\n'
 ' Height: 100\n'
 ' Width: 100\n'
 ' Orientation: Undefined\n'
 ' Compression type: JPEG\n'
 '-Compression quality: 90\n'
 '+Compression quality: 95\n'
 ' Colorspace: sRGB\n'
 ' Channels: srgb\n'
 ' Depth: 8\n'
 ' Interlace mode: JPEG\n'
 ' Rendering intent: Perceptual\n'
 '-X resolution: 88\n'
 '-Y resolution: 88\n'
 '+X resolution: 65\n'
 '+Y resolution: 65\n'
 ' Resolution units: PixelsPerInch\n'
 ' Transparency channel enabled: False\n'
 ' Gamma: 0.454545\n'
 ' Number of unique colors: 1\n'
 '-Comment: Comment #1\n'
 '+Comment: Comment #2\n'
 ' EXIF data: \n')
Comment 3 Larry the Git Cow gentoo-dev 2021-06-23 06:55:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bef484b5b6d9df5c3fd756e7205616d4e7f22464

commit bef484b5b6d9df5c3fd756e7205616d4e7f22464
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2021-06-23 06:55:37 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2021-06-23 06:55:47 +0000

    dev-util/diffoscope: pull in media-libs/libcaca for optional tests
    
    The change does not fix tests, but exposes test failures consistently.
    
    Reported-by: Jonathan Lovelace
    Bug: https://bugs.gentoo.org/797688
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 dev-util/diffoscope/diffoscope-177.ebuild | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2021-06-23 07:50:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=589cc8529aa9901cf6c4330a8f7f7b93b1888b02

commit 589cc8529aa9901cf6c4330a8f7f7b93b1888b02
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2021-06-23 07:49:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2021-06-23 07:50:43 +0000

    dev-util/diffoscope: disable img2txt tests
    
    Reported-by: Jonathan Lovelace
    Closes: https://bugs.gentoo.org/797688
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 dev-util/diffoscope/diffoscope-177.ebuild | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2021-06-23 07:56:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f68a8ddea4485cea2d1cd54a04ab211f5babd49

commit 4f68a8ddea4485cea2d1cd54a04ab211f5babd49
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2021-06-23 07:56:28 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2021-06-23 07:56:35 +0000

    dev-util/diffoscope:  disable docx2txt tests
    
    Reported-by: Jonathan Lovelace
    Closes: https://bugs.gentoo.org/797688
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 dev-util/diffoscope/diffoscope-177.ebuild | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)