Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 797235 - media-sound/mixxx-9999: CMAKE_BUILD_TYPE=Gentoo is not supported, use one of Debug, Release or RelWithDebInfo.
Summary: media-sound/mixxx-9999: CMAKE_BUILD_TYPE=Gentoo is not supported, use one of ...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on: 780888
Blocks:
  Show dependency tree
 
Reported: 2021-06-20 23:49 UTC by gerion
Modified: 2022-10-16 08:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,3.78 KB, text/x-log)
2021-06-20 23:51 UTC, gerion
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gerion 2021-06-20 23:49:01 UTC
Mixxx Git currently does not run, because of #780888. However, when I'm dropping this patch, mixxx compilation fails (9 days ago compilation still worked, when dropping the patch).

The build log is attached.

My ebuild modification:
```
diff --git a/media-sound/mixxx/mixxx-9999.ebuild b/media-sound/mixxx/mixxx-9999.ebuild
index 437d4ca2e35d..5445f5b0fb07 100644
--- a/media-sound/mixxx/mixxx-9999.ebuild
+++ b/media-sound/mixxx/mixxx-9999.ebuild
@@ -81,10 +81,6 @@ BDEPEND="virtual/pkgconfig
        dev-qt/qttest:5
        dev-qt/qtxmlpatterns:5"
 
-PATCHES=(
-       "${FILESDIR}"/mixxx-9999-docs.patch
-       )
-
 src_prepare() {
        cmake_src_prepare
 }
```

The error message:
```
>>> Preparing source in /var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999 ...
 * Working in BUILD_DIR: "/var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999_build"
 * Hardcoded definition(s) removed in CMakeLists.txt:
 *      set(CMAKE_BUILD_TYPE "${default_build_type}" CACHE STRING "Choose the typ
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999 ...
 * Working in BUILD_DIR: "/var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999_build"
cmake -C /var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999_build/gentoo_common_config.cmake -G Ninja -DCMAKE_INSTALL_PREFIX=/usr -DFAAD=on -DFFMPEG=on -DHID=on -DLILV=on -DMAD=on -DOPTIMIZE=off -DCCACHE_SUPPORT=off -DOPUS=on -DBROADCAST=on -DVINYLCONTROL=on -DINSTALL_USER_UDEV_RULES=OFF -DWAVPACK=on -DQTKEYCHAIN=off -DKEYFINDER=on -DENGINEPRIME=OFF -DCMAKE_BUILD_TYPE=Gentoo -DCMAKE_TOOLCHAIN_FILE=/var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999_build/gentoo_toolchain.cmake  /var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999
loading initial cache file /var/tmp/portage/media-sound/mixxx-9999/work/mixxx-9999_build/gentoo_common_config.cmake
CMake Error at CMakeLists.txt:57 (message):
  CMAKE_BUILD_TYPE=Gentoo is not supported, use one of Debug, Release or
  RelWithDebInfo.

```

Reproducible: Always

Steps to Reproduce:
1. Apply the patch to workaround #780888.
2. emerge mixxx-9999
Comment 1 gerion 2021-06-20 23:51:40 UTC
Created attachment 717258 [details]
build.log
Comment 2 jospezial 2021-06-21 04:22:53 UTC
Upstream commit:
https://github.com/mixxxdj/mixxx/commit/c7aa1c9a984ebb4dfdd81bc0e0b630602d080221
"Fail with CMAKE_BUILD_TYPE=MinSizeRel or any other unsupported value"

CMAKE_BUILD_TYPE=Gentoo is automatically set by cmake.eclass

Maybe we should set CMAKE_BUILD_TYPE to one of Debug, Release (or RelWithDebInfo ?) in the ebuild.
Comment 3 Andreas Sturmlechner gentoo-dev 2021-06-21 06:22:12 UTC
We should ignore upstream's wishes.
Comment 4 jospezial 2021-06-21 08:19:53 UTC
If I revert the upstream commit c7aa1c9a984ebb4dfdd81bc0e0b630602d080221 all seems to work normal in media-sound/mixxx-2.3.9999.

But I still see too:
* Hardcoded definition(s) removed in CMakeLists.txt:
 *    set(CMAKE_BUILD_TYPE "${default_build_type}" CACHE STRING "Choose the type
Comment 5 jospezial 2021-06-30 09:46:53 UTC
Can we solve the bugs with the live ebuilds and then bump to
https://github.com/mixxxdj/mixxx/releases/tag/2.3.0
?
Comment 6 Miroslav Šulc gentoo-dev 2021-06-30 11:21:46 UTC
sure, but first i'd like to see the docs issue resolved.
Comment 7 jospezial 2021-07-14 22:54:27 UTC
I found a discussion about CMAKE_BUILD_TYPE in archlinux with the mixxx-developers:

https://github.com/archlinux/svntogit-community/commit/da37cf256156dead98e5a62219ab4006167986f9#r53047679
Comment 8 gerion 2021-08-21 00:52:28 UTC
I have packaged mixxx with the two updated patches in my overlay:
https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx

The current mixxx-9999 version depends on hidapi-0.10.1, see https://bugs.gentoo.org/696482. It can be installed from the netfab overlay (https://github.com/netfab/overlay)
Comment 9 jospezial 2021-11-09 15:21:03 UTC
Upstream PR for allowing buildtype "None" used in Alpine Linux
https://github.com/mixxxdj/mixxx/pull/4112

https://github.com/gentoo/gentoo/pull/22497
contains a patch that adds buildtype "Gentoo"

https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/files/mixxx-9999-gentoo-build.patch
removes the FATAL_ERROR message.

Which way do we wanna go?
Comment 10 gerion 2021-11-10 08:00:37 UTC
Although I wrote one of the patches, I have no strong opinion. I chose this approach this it seems minimal invasive and seems to work (at least the latest Mixxx is running for me again).

BTW, I had a problem with an unwanted dev-cpp/benchmark dependency, this is solved in a quick and dirty way in my ebuild https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/files/drop-mixxx-test.patch
Please find a better way :).
Comment 11 jospezial 2021-11-10 14:26:56 UTC
(In reply to gerion from comment #10)
> Although I wrote one of the patches, I have no strong opinion. I chose this
> approach this it seems minimal invasive and seems to work (at least the
> latest Mixxx is running for me again).
> 
> BTW, I had a problem with an unwanted dev-cpp/benchmark dependency, this is
> solved in a quick and dirty way in my ebuild
> https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/
> files/drop-mixxx-test.patch
> Please find a better way :).

Bug 822357
Comment 12 jospezial 2021-11-12 17:35:32 UTC
gerion, your
https://gitweb.gentoo.org/repo/user/gerislay.git/tree/media-sound/mixxx/mixxx-9999.ebuild
is missing commit
https://github.com/gentoo/gentoo/commit/7a8c9e7be5c18dde7265591309bad5fe026957ca
"add missing slot operator dep (libid3tag)"
and
Bug 775443 - media-sound/mixxx-{2.3.9999,9999}: upstream has changed from libshout to libshout-idjc
Comment 13 Andreas Sturmlechner gentoo-dev 2022-10-16 08:45:06 UTC
Ported to EAPI-8 in commit 5acda659d06d385c84365844e2bde568819a9e0b, cmake.eclass in EAPI-8 defaults to RelWithDebInfo.