While running the test suite, I repeatedly get a GUI window asking me for root password in order to 'stop consul.service'. Sounds like a major command leak. Not that I'm running such a service.
Several tests call "ghe-restore", which calls "ssh ... sudo systemctl stop consul". https://github.com/github/backup-utils/blob/v3.0.0/bin/ghe-restore#L301 As well, the tests use a wrapper script for ssh that removes any "sudo" calls and runs the commands locally. https://github.com/github/backup-utils/blob/v3.0.0/test/bin/ssh#L37 The end result is that "systemctl stop consul" gets executed directly as the portage user, which triggers a polkit prompt if portage is not running as root.
ghe-restore attempts to perform many privileged operations, and it doesn't look like it was really designed for use in an isolated test environment. I would recommend masking the test USE flag until/unless the tests can be made more safe for general use.
Other tests are still failing but, at least, they don't seem to end up asking for privileges in my system with 3.8.0 version
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ae704d20ec8a0bac6662a527c909a56d36de8af commit 6ae704d20ec8a0bac6662a527c909a56d36de8af Author: William Hubbs <williamh@gentoo.org> AuthorDate: 2024-06-18 15:30:26 +0000 Commit: William Hubbs <williamh@gentoo.org> CommitDate: 2024-06-18 15:30:26 +0000 app-admin/github-backup-utils: The tests are meant to be run in an isolated environment, so restrict them. This also removes the need for python. Closes: https://bugs.gentoo.org/796815 Closes: https://bugs.gentoo.org/929273 Signed-off-by: William Hubbs <williamh@gentoo.org> app-admin/github-backup-utils/github-backup-utils-3.12.3.ebuild | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
