Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 796557 - media-libs/mlt-7.0.1 version bump (switch to cmake)
Summary: media-libs/mlt-7.0.1 version bump (switch to cmake)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL: https://invent.kde.org/multimedia/kde...
Whiteboard:
Keywords:
Depends on:
Blocks: 796560
  Show dependency tree
 
Reported: 2021-06-18 07:51 UTC by Sven Eden
Modified: 2021-12-02 23:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Experimental ebuild to install mlt-7.0.1 (mlt-7.0.1.ebuild,5.12 KB, text/plain)
2021-06-18 07:51 UTC, Sven Eden
Details
Fix man page symlinking in new cmake build system (mlt-7.0.1-fix_man_symlink.patch,583 bytes, patch)
2021-06-18 07:53 UTC, Sven Eden
Details | Diff
Remove absolute runtime paths from new cmake build system (mlt-7.0.1-remove-rpath.patch,525 bytes, patch)
2021-06-18 07:54 UTC, Sven Eden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Eden 2021-06-18 07:51:24 UTC
Created attachment 716685 [details]
Experimental ebuild to install mlt-7.0.1

media-video/shotcut newer than Version 21.03.21 has switched to mlt-7.

Attached is an experimental ebuild for media-libs/mlt-7.0.1, which WILL *BREAK* kdenlive(*)! It is only meant as a starting point.

The new mlt-7 has its binaries and libraries re-organized, so my ebuild might only be a starting point to get mlt slotted?

(*) kdenlive calls objects and functions that are no longer present, so it is not about a simple patching. As I am using shotcut, I have added kde-apps/kdenlive to package.provided and am happy, but having mlt to be slotted, so both can be installed, might be the more reasonable approach.
Comment 1 Sven Eden 2021-06-18 07:53:06 UTC
Created attachment 716688 [details, diff]
Fix man page symlinking in new cmake build system

The build system was changed to cmake, and not everything is fully in order there, yet. The unpatched CMakeLists.txt uses absolute paths for symlinking the man page, which triggers a sandbox violation.
Comment 2 Sven Eden 2021-06-18 07:54:19 UTC
Created attachment 716691 [details, diff]
Remove absolute runtime paths from new cmake build system

The unpatched CMakeLists.txt does not remove the absolute runtime paths upon installation, causing Q/A warnings about unsafe paths on merging.
Comment 3 Andreas Sturmlechner gentoo-dev 2021-07-16 20:54:02 UTC
Also blocking kdenlive-21.08 release.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-20 21:20:45 UTC
Sven, you didn't include the Signed-off-by line. Could you inclulde that if you agree to the GCO terms and also ideally provide it via `git format-patch`?

(Note I think you forgot to CC kde@ as co-maintainers by the way.)

I'll need to do this myself otherwise.
Comment 5 Andreas Sturmlechner gentoo-dev 2021-07-21 08:13:08 UTC
Is a separate slot/parallel installation feasible at all? Otherwise, we'll just restrict kdenlive-21.04.3 to mlt-6 before stabilisation, and soon-to-be-released 21.08.0 will support >=mlt-7 anyway.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-29 01:40:44 UTC
(In reply to Andreas Sturmlechner from comment #5)
> Is a separate slot/parallel installation feasible at all?

I started poking at this but didn't really have enough time in the end. I figured it wasn't worth the hassle.

> Otherwise, we'll just restrict kdenlive-21.04.3 to mlt-6 before stabilisation, and
> soon-to-be-released 21.08.0 will support >=mlt-7 anyway.

I'll do this in the same push later today hopefully.
Comment 7 Larry the Git Cow gentoo-dev 2021-08-01 20:19:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22a5116e66ece33b10989f419953f138a0564620

commit 22a5116e66ece33b10989f419953f138a0564620
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-01 19:41:40 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-01 20:19:11 +0000

    kde-apps/kdenlive: Restrict to <media-libs/mlt-7
    
    Bug: https://bugs.gentoo.org/796557
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../kdenlive/{kdenlive-21.04.3.ebuild => kdenlive-21.04.3-r1.ebuild}     | 1 +
 1 file changed, 1 insertion(+)
Comment 8 Larry the Git Cow gentoo-dev 2021-08-05 01:48:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b87e752f3025f4010a3b52f74297cbc063316479

commit b87e752f3025f4010a3b52f74297cbc063316479
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-07-22 05:14:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-08-05 01:47:44 +0000

    media-libs/mlt: add 7.0.1
    
    Closes: https://bugs.gentoo.org/796557
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/mlt/Manifest                            |   1 +
 media-libs/mlt/files/mlt-7.0.1-cmake-symlink.patch |  14 ++
 media-libs/mlt/mlt-7.0.1.ebuild                    | 209 +++++++++++++++++++++
 3 files changed, 224 insertions(+)
Comment 9 Sven Eden 2021-11-16 07:16:44 UTC
(In reply to Sam James from comment #4)
> Sven, you didn't include the Signed-off-by line. Could you inclulde that if
> you agree to the GCO terms and also ideally provide it via `git
> format-patch`?
> 
> (Note I think you forgot to CC kde@ as co-maintainers by the way.)
> 
> I'll need to do this myself otherwise.

Oh? That one went past me.

Where did I forget to use --signoff? I normally use that always and everywhere... :-(
Comment 10 Andreas Sturmlechner gentoo-dev 2021-11-30 12:36:14 UTC
Sam, aren't we missing sci-libs/fftw:3.0= unconditional dep now that MOD_PLUS is left default enabled by the build system?
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-30 12:46:56 UTC
(In reply to Andreas Sturmlechner from comment #10)
> Sam, aren't we missing sci-libs/fftw:3.0= unconditional dep now that
> MOD_PLUS is left default enabled by the build system?

IIRC I'd thought it was off but apparently there's a use for FFTW as Eric pointed out. Will look at it (and check the others) later. Away at moment (at vet again...)
Comment 12 Larry the Git Cow gentoo-dev 2021-12-02 23:39:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a92d5b2e4cee52fa9a8df28e1b4fdd4f0195cc8

commit 0a92d5b2e4cee52fa9a8df28e1b4fdd4f0195cc8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-12-02 23:37:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-12-02 23:38:10 +0000

    media-libs/mlt: unconditionally enable FFTW (PLUS)
    
    Closes: https://bugs.gentoo.org/603168
    Closes: https://bugs.gentoo.org/796557
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/mlt/{mlt-7.2.0.ebuild => mlt-7.2.0-r1.ebuild} | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)