Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 795921 - media-video/pipewire: misleading USE flags, annoying REQUIRED_USE
Summary: media-video/pipewire: misleading USE flags, annoying REQUIRED_USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-14 08:18 UTC by Joonas Niilola
Modified: 2021-07-06 15:56 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2021-06-14 08:18:43 UTC
Hey, 

globally 'aac' is used to enable support for MPEG-4 AAC Audio, 
https://packages.gentoo.org/useflags/aac
but with pipewire, it has nothing to do with AAC audio support, rather it's tied to some bluetooth thing. There are also other flags used like this, 
aac, aptx & ldac. Would you consider enabling the support for *all* of these simply under 'bluetooth' USE? The deps themself seem very light. 

Or rename the USE, bluetooth-aac, bluetooth-ldac etc.

Just a thought.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-06-14 08:20:11 UTC
That was my suggestion when it came up.
Comment 2 Andreas Sturmlechner gentoo-dev 2021-06-14 08:20:30 UTC
(enabling it unconditionally under bluetooth)
Comment 3 Larry the Git Cow gentoo-dev 2021-07-06 15:56:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1bb4af5c47763a0ff2feba7d48cd5d495615630

commit e1bb4af5c47763a0ff2feba7d48cd5d495615630
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-07-06 15:55:05 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-07-06 15:55:07 +0000

    media-video/pipewire: combine USE=aac, USE=aptx & USE=ldac in USE=bluetooth
    
    Closes: https://bugs.gentoo.org/795921
    Package-Manager: Portage-3.0.21, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 ...wire-0.3.30.ebuild => pipewire-0.3.30-r1.ebuild} | 21 ++++++++-------------
 media-video/pipewire/pipewire-0.3.31.ebuild         | 21 ++++++++-------------
 media-video/pipewire/pipewire-9999.ebuild           | 21 ++++++++-------------
 3 files changed, 24 insertions(+), 39 deletions(-)