Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 795819 - sci-mathematics/gmp-ecm-7.0.4-r3 QA Notice: The following files contain writable and executable sections when using LIBTOOL=slibtool
Summary: sci-mathematics/gmp-ecm-7.0.4-r3 QA Notice: The following files contain writ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-06-13 23:03 UTC by Alessandro Barbieri
Modified: 2021-06-15 00:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge_info (emerge_info,36.02 KB, text/plain)
2021-06-13 23:03 UTC, Alessandro Barbieri
Details
gmp-ecm-7.0.4-r3:20210309-012528.logx (gmp-ecm-7.0.4-r3:20210309-012528.logx,167.49 KB, text/plain)
2021-06-13 23:03 UTC, Alessandro Barbieri
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Barbieri 2021-06-13 23:03:19 UTC
This package has QA issues. Attached relevant logs and emerge --info
Comment 1 Alessandro Barbieri 2021-06-13 23:03:31 UTC
Created attachment 715818 [details]
emerge_info

emerge --info
Comment 2 Alessandro Barbieri 2021-06-13 23:03:33 UTC
Created attachment 715821 [details]
gmp-ecm-7.0.4-r3:20210309-012528.logx

build log
Comment 3 Alessandro Barbieri 2021-06-13 23:04:19 UTC
 * QA Notice: The following files contain writable and executable sections                                                                                                                                                                  
 *  Files with such sections will not work properly (or at all!) on some                                                                                                                                                                    
 *  architectures/operating systems.  A bug should be filed at                                                                                                                                                                              
 *  https://bugs.gentoo.org/ to make sure the issue is fixed.                                                         
 *  For more information, see:                                                                                        
 *                                                                                                                    
 *    https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart                                                      
 *                                                                                                                    
 *  Please include the following list of files in your report:                                                        
 *  Note: Bugs should be filed for the respective maintainers                                                         
 *  of the package in question and not hardened@gentoo.org.                                                           
 * !WX --- --- usr/lib64/libecm.a:mulredc1_20.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_19.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_18.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_17.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_16.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_15.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_14.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_13.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_12.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_11.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_10.o                                                                       
 * !WX --- --- usr/lib64/libecm.a:mulredc1_9.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_8.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_7.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_6.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_5.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_4.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_3.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc1_2.o                                                                        
 * !WX --- --- usr/lib64/libecm.a:mulredc20.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc19.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc18.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc17.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc16.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc15.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc14.o                                                                                                                                                                                               
 * !WX --- --- usr/lib64/libecm.a:mulredc13.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc12.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc11.o                                                                                                                                                                                               
 * !WX --- --- usr/lib64/libecm.a:mulredc10.o                                                                         
 * !WX --- --- usr/lib64/libecm.a:mulredc9.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc8.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc7.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc6.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc5.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc4.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc3.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc2.o                                                                          
 * !WX --- --- usr/lib64/libecm.a:mulredc1.o
Comment 4 François Bissey 2021-06-14 08:34:35 UTC
Hurgh, I thought we had dealt with those in a definitive way upstream. Let's see how those have made it back.
Comment 5 François Bissey 2021-06-14 11:08:14 UTC
I think slibtool may be eating the --noexecstack generated by upstream. We have it because the asm is autogenerated and goes through transformation before being compiled. I think I now have the sense on how to fix the generation itself, but there are a few things that don't match. I don't think upstream regenerated the asm files in a while and may have even amended them after generation.

I may have a PR ready for this by tomorrow that makes using --noexecstack irrelevant and follow it up upstream.
Comment 6 François Bissey 2021-06-14 23:07:16 UTC
Upstream issue is now https://gitlab.inria.fr/zimmerma/ecm/-/issues/21858

My PR may follow a slightly different strategy from I will put upstream.
Comment 7 Larry the Git Cow gentoo-dev 2021-06-15 00:43:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8c7da7cc0a7a42cc82475a54a18b80c574ee8cc8

commit 8c7da7cc0a7a42cc82475a54a18b80c574ee8cc8
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2021-06-15 00:22:50 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-06-15 00:40:54 +0000

    sci-mathematics/gmp-ecm: remove old "unused" gmp-ecm-7.0.4-r3.ebuild.
    
    Closes: https://bugs.gentoo.org/795819
    Closes: https://github.com/gentoo/gentoo/pull/21244
    Package-Manager: Portage-3.0.18, Repoman-3.0.2
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/gmp-ecm/gmp-ecm-7.0.4-r3.ebuild | 57 -------------------------
 1 file changed, 57 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c1907192c06e8030cbf975866ab01b98b577e98

commit 9c1907192c06e8030cbf975866ab01b98b577e98
Author:     François Bissey <frp.bissey@gmail.com>
AuthorDate: 2021-06-14 23:12:37 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-06-15 00:40:51 +0000

    sci-mathematics/gmp-ecm: fix executable stack for good
    
    Package-Manager: Portage-3.0.18, Repoman-3.0.2
    Bug: https://bugs.gentoo.org/795819
    Signed-off-by: François René Pierre Bissey <frp.bissey@gmail.com>
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 .../gmp-ecm/files/gmp-ecm-7.0.4-execstack.patch    | 49 +++++++++++++
 sci-mathematics/gmp-ecm/gmp-ecm-7.0.4-r4.ebuild    | 81 ++++++++++++++++++++++
 2 files changed, 130 insertions(+)