Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 795768 - app-editors/neovim: default to luajit
Summary: app-editors/neovim: default to luajit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 2 votes (vote)
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-06-13 11:21 UTC by Lin Jian
Modified: 2022-04-04 21:56 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lin Jian 2021-06-13 11:21:40 UTC
I have trouble[1] using lsp_signature[2] with neovim-9999. It turns out the cause is that plugin needs luajit or >=lua-5.2.

Also, the developer of that plugin says, "Lots of neovim plugins built on LuaJIT. And programmer is presuming the LuaJIT is available by default".[3]

So, maybe defaulting to luajit instead of lua-5.1 is a good idea?

[1]: https://github.com/ray-x/lsp_signature.nvim/issues/29
[2]: https://github.com/ray-x/lsp_signature.nvim
[3]: https://github.com/ray-x/lsp_signature.nvim/issues/29#issuecomment-860193030
Comment 1 yiqunding 2021-07-03 04:50:43 UTC
The "Third-party dependencies" of neovim build guide explicitly lists luajit as dependency: https://github.com/neovim/neovim/wiki/Building-Neovim#third-party-dependencies

I think we should always depend on luajit
Comment 2 antisocrates 2022-02-13 13:47:42 UTC
I have been researching this today, and the support channel for neovim at libera.chat, unanimously told me to use luajit instead of lua5.1, not sure why it isn't the default already.
Comment 3 Larry the Git Cow gentoo-dev 2022-04-04 21:37:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89b6ec419c5d45364bf2b051246e19f908630661

commit 89b6ec419c5d45364bf2b051246e19f908630661
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-01 01:41:35 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-04 21:37:12 +0000

    profiles: Prefer luajit for app-editors/neovim
    
    Closes: https://bugs.gentoo.org/795768
    Closes: https://github.com/gentoo/gentoo/pull/24842
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/base/package.use | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-04-04 21:56:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46304c70d7a441ea6828eeee5f9668edbf39a87b

commit 46304c70d7a441ea6828eeee5f9668edbf39a87b
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-04-04 21:55:20 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-04-04 21:56:21 +0000

    profiles: Expand LUA_TARGETS
    
    Apparently I cannot use this syntax in profiles/?
    
    Bug: https://bugs.gentoo.org/795768
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/base/package.use | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)