794970 – games-arcade/jumpnbump: fno-common patch (to replace current use of -fcommon)

Bug 794970 - games-arcade/jumpnbump: fno-common patch (to replace current use of -fcommon)

Summary: games-arcade/jumpnbump: fno-common patch (to replace current use of -fcommon)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal trivial (vote)
Assignee:	Gentoo Games

URL:	https://github.com/LibreGames/jumpnbu...
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2021-06-08 16:58 UTC by Samuel Bauer
Modified:	2021-11-18 19:11 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
allows to compile without -fcommon (jumpnbump-1.61-fno-common.patch,1.11 KB, patch) 2021-06-08 16:58 UTC, Samuel Bauer	Details \| Diff
ebuild patch (jnb.patch,657 bytes, patch) 2021-06-08 17:01 UTC, Samuel Bauer	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Samuel Bauer 2021-06-08 16:58:52 UTC

Created attachment 714729 [details, diff]
allows to compile without -fcommon

For now flag-o-matic adds -fcommon to allow compiling

Comment 1 Samuel Bauer 2021-06-08 17:01:10 UTC

Created attachment 714738 [details, diff]
ebuild patch

Comment 2 Samuel Bauer 2021-06-08 17:05:19 UTC

same patch already available on gitlab:

https://github.com/LibreGames/jumpnbump/commit/b72b70a4233776bdaa6a683c89af2becefd53bd6

Comment 3 Larry the Git Cow gentoo-dev

2021-11-18 19:11:39 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74f54c8e5622e307705505e280b94e2aaf93f006

commit 74f54c8e5622e307705505e280b94e2aaf93f006
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-11-18 18:23:06 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-11-18 19:08:07 +0000

    games-arcade/jumpnbump: add 1.61_p20210421
    
    * EAPI7->8
    * enable py3.10
    * drop -fcommon workaround wrt bug #794970 (fixed upstream)
    * add zlib/bzip2/pillow missing deps.
    * IUSE=gtk->gui (IUSE=launcher or =menu may make more sense
      but didn't see a major need for non-generic flags here)
    * move icon to right location
    
    Closes: https://bugs.gentoo.org/794970
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-arcade/jumpnbump/Manifest                    |  1 +
 .../jumpnbump/jumpnbump-1.61_p20210421.ebuild      | 69 ++++++++++++++++++++++
 2 files changed, 70 insertions(+)