Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 794439 - x11-terms/kitty minor ebuild modification
Summary: x11-terms/kitty minor ebuild modification
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Pagano
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-05 13:41 UTC by Arnaud Vallette d'Osia
Modified: 2021-06-12 16:58 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge--info,5.54 KB, text/plain)
2021-06-08 14:34 UTC, Arnaud Vallette d'Osia
Details
Portage test python script (test,494 bytes, text/x-python)
2021-06-08 14:52 UTC, Mike Pagano
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arnaud Vallette d'Osia 2021-06-05 13:41:23 UTC
Hello and thanks for this ebuild: I rely on it since a while.
portpeek util, by mpagano has problems with kitty ebuild's keywords,
and I think it is caused by the (unneeded) double quotes around "9999".
Would you please remove them?
like this : https://gitweb.gentoo.org/repo/gentoo.git/tree/gui-wm/sway/sway-1.6.ebuild
Thanks for the support
Arnaud
Comment 1 Ionen Wolkens gentoo-dev 2021-06-06 04:15:34 UTC
While it's true they're unneeded, it's still valid syntax and this should instead be fixed in portpeek if it's really the issue (haven't tried).

At most quotes could be cleaned as part of other changes, but well.
Comment 2 Arnaud Vallette d'Osia 2021-06-06 16:52:09 UTC
> this should instead be fixed in portpeek

agreed.

I see you've attached the right persons, thanks.
Comment 3 Mike Pagano gentoo-dev 2021-06-06 23:24:24 UTC
(In reply to Arnaud Vallette d'Osia from comment #2)
> > this should instead be fixed in portpeek
> 
> agreed.
> 
> I see you've attached the right persons, thanks.

Can you explain to me which quotes you mean ?
and what you have in your package.accept_keywords?
Comment 4 Arnaud Vallette d'Osia 2021-06-07 09:00:30 UTC
> Can you explain to me which quotes you mean ?

Sure. those:
https://gitweb.gentoo.org/repo/gentoo.git/tree/x11-terms/kitty/kitty-0.20.3.ebuild#n10

> and what you have in your package.accept_keywords?

yep, here:
=x11-terms/kitty-0.20.3 ~amd64
=x11-terms/kitty-terminfo-0.20.3 ~amd64

Thanks for portpeek by the way: I sometimes painfully checked things manually before, and I'm glad to rely on your tool.
Comment 5 Mike Pagano gentoo-dev 2021-06-07 17:39:58 UTC
Arnaud, can you help me replicate?


/etc/portage/package.accept_keywords: 

=x11-terms/kitty-0.20.3 ~amd64
=x11-terms/kitty-terminfo-0.20.3 ~amd64

installed:

eix kitty

[I] x11-terms/kitty
     Available versions:  ~0.19.3 ~0.20.1 (~)0.20.3 **9999*l {debug wayland PYTHON_SINGLE_TARGET="(+)python3_8 python3_9"}
     Installed versions:  0.20.3(01:36:22 PM 06/07/2021)(-debug -wayland PYTHON_SINGLE_TARGET="python3_9 -python3_8")
     Homepage:            https://github.com/kovidgoyal/kitty
     Description:         A modern, hackable, featureful, OpenGL-based terminal emulator

[I] x11-terms/kitty-terminfo
     Available versions:  ~0.19.3^t ~0.20.1^t (~)0.20.3^t **9999*l^t {debug}
     Installed versions:  0.20.3^t(01:36:01 PM 06/07/2021)(-debug)
     Homepage:            https://github.com/kovidgoyal/kitty
     Description:         Terminfo for kitty, an OpenGL-based terminal emulator


portpeek -artq

package.keywords:
Could not find file /etc/portage/package.keywords
No ebuild options found.

package.accept_keywords:

package.unmask:

package.mask:

package.use:

package.env:

Done
Comment 6 Arnaud Vallette d'Osia 2021-06-07 19:57:33 UTC
> Arnaud, can you help me replicate?
Sure, thanks for the support, hope this helps:


emerge -avp kitty

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   ~] x11-terms/kitty-0.20.3::gentoo  USE="wayland -debug" PYTHON_SINGLE_TARGET="python3_9 -python3_8" 3 406 KiB

Total: 1 package (1 reinstall), Size of downloads: 3 406 KiB



portpeek -a

package.keywords:
Could not find file /etc/portage/package.keywords
No ebuild options found.

package.accept_keywords:

Installed: <media-video/mpv-9999  Keywords ['amd64']

Installed: =app-misc/ddcutil-0.9.9  Keywords ['~amd64']

Installed: =x11-misc/piedock-1.6.9  Keywords ['~amd64']

Package: =x11-terms/kitty-0.20.3 ~amd64 not found. Please check /etc/portage/package.accept_keywords to validate entry

Installed: =x11-terms/kitty-terminfo-0.20.3  Keywords ['~amd64']

Installed: =xfce-base/thunar-4.17.3  Keywords ['~amd64']

Installed: =gui-apps/waybar-0.9.7  Keywords ['~amd64']

Installed: =dev-libs/date-3.0.0  Keywords ['~amd64']

Installed: =gui-wm/wayfire-0.7.1  Keywords ['~amd64']

Installed: =gui-libs/wf-config-0.7.1  Keywords ['~amd64']

Installed: =gui-apps/wcm-0.7.0  Keywords ['~amd64']

package.unmask:

package.mask:

package.use:

package.env:
Comment 7 Mike Pagano gentoo-dev 2021-06-08 12:42:46 UTC
Can you paste the output of emerge --info ?

Which python version is active?
Comment 8 Arnaud Vallette d'Osia 2021-06-08 14:34:18 UTC
Created attachment 714645 [details]
emerge --info

python 3.9
Comment 9 Mike Pagano gentoo-dev 2021-06-08 14:52:47 UTC
Created attachment 714657 [details]
Portage test python script

Firstly, thanks for you patience.

Can you run the attached script and print the output?
Comment 10 Arnaud Vallette d'Osia 2021-06-08 17:07:35 UTC
you're welcome, and thanks for the support

./test 
Package: =x11-term/kitty-0.20.3 exists
Comment 11 Larry the Git Cow gentoo-dev 2021-06-11 18:57:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=308e8a5cc6d7885e07ba16d9884ae63ca7366c2b

commit 308e8a5cc6d7885e07ba16d9884ae63ca7366c2b
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2021-06-11 18:57:44 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2021-06-11 18:57:44 +0000

    app-portage/portpeek: Fix split command
    
    Reported-by: Arnaud Vallette d'Osia
    Closes: https://bugs.gentoo.org/794439
    Package-Manager: Portage-3.0.18, Repoman-3.0.2
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 app-portage/portpeek/Manifest              |  1 +
 app-portage/portpeek/portpeek-3.2.1.ebuild | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)
Comment 12 Arnaud Vallette d'Osia 2021-06-12 16:51:14 UTC
Yeah, that split() special behavior is a real foot-gun.
Thanks for tracking this down.
This indeed fixes this bug.
Comment 13 Mike Pagano gentoo-dev 2021-06-12 16:58:58 UTC
(In reply to Arnaud Vallette d'Osia from comment #12)
> Yeah, that split() special behavior is a real foot-gun.
> Thanks for tracking this down.
> This indeed fixes this bug.

Thanks for your quick responses.  You made me look up foot-gun.  :)