Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 794211 - games-puzzle/pathological: pygame2 compatibility patch
Summary: games-puzzle/pathological: pygame2 compatibility patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-06-04 23:17 UTC by Samuel Bauer
Modified: 2021-06-05 05:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch for pygame2 support (pathological-pygame2-fix.ebuild.patch,766 bytes, patch)
2021-06-04 23:17 UTC, Samuel Bauer
Details | Diff
test patch (new.patch,1.87 KB, patch)
2021-06-04 23:28 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2021-06-04 23:17:41 UTC
Created attachment 713703 [details, diff]
ebuild patch for pygame2 support

The following ebuild patch adds a sed one liner to fix pathological issues with pyagme2.
Comment 1 Ionen Wolkens gentoo-dev 2021-06-04 23:28:12 UTC
Created attachment 713706 [details, diff]
test patch

Thanks, sed did point me in the right direction but going with a more specific patch approach not to cause unnecessary changes (like in English comments and license in the .py)

And the "is not" notably don't seem needed.

Few other things need checking too, for example it tests for sdl-mixer but pygame2 uses sdl2-mixer, so I'm thinking to set it to >=pygame-2 in anticipation for a (future) pygame1 removal.

Attaching tentative patch, not that I've tested much yet.
Comment 2 Larry the Git Cow gentoo-dev 2021-06-05 05:07:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0528696360252c65b9ec1c42ad88c974cb104d90

commit 0528696360252c65b9ec1c42ad88c974cb104d90
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-05 04:56:18 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-05 05:03:59 +0000

    games-puzzle/pathological: support pygame-2, tidy ebuild
    
    - use patch to fix input events with pygame-2
    - add sdl2-image[jpeg,png], pygame-1 ebuild would ensure
      availability but not every games need this and so -2 doesn't
    - check for sdl2-mixer[mod] in postinst over sdl-mixer using optfeature
    - remove write-highscores as it's unused with debian patches and don't
      want to change behavior after this long or break the patchset
    - remove \xa9 sed (bug #162025), already fixed by debian patches
    
    sdl2-* deps are invalid with pygame-1 but there's no real reason
    to restrict to >=pygame-2 (still runs with 1) or complexify when
    pygame-1 will have to be removed eventually.
    
    Thanks to Samuel Bauer for pointing out inputs fix for pygame-2.
    
    Closes: https://bugs.gentoo.org/794211
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../pathological-1.1.3_p16-pygame2-compat.patch    | 68 ++++++++++++++++++++
 .../pathological/pathological-1.1.3_p16-r3.ebuild  | 74 ++++++++++++++++++++++
 2 files changed, 142 insertions(+)