Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 793920 - dev-lang/spidermonkey-78.11.0: fails to compile "error: could not compile `packed_simd`"
Summary: dev-lang/spidermonkey-78.11.0: fails to compile "error: could not compile `pa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM64 Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-02 15:56 UTC by Marco Scardovi (scardracs)
Modified: 2021-07-15 20:41 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge --info,6.15 KB, text/plain)
2021-06-02 15:56 UTC, Marco Scardovi (scardracs)
Details
emerge --log (emerge --log,83.13 KB, text/plain)
2021-06-02 15:58 UTC, Marco Scardovi (scardracs)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Scardovi (scardracs) 2021-06-02 15:56:25 UTC
Created attachment 713313 [details]
emerge --info

Possible context of error: error: could not compile `packed_simd`

Bug find on ARM64 but may be present on other arches as well
Comment 1 Marco Scardovi (scardracs) 2021-06-02 15:58:09 UTC
Created attachment 713316 [details]
emerge --log
Comment 2 Oleg 2021-06-02 19:18:02 UTC
Got this error with rustc 1.54.0-dev (9a700d294 2021-05-26) (gentoo):

error[E0557]: feature has been removed
   --> /tmp/portage/dev-lang/spidermonkey-78.10.1/work/firefox-78.10.1/third_party/rust/packed_simd/src/lib.rs:205:5
    |
205 |     const_fn,
    |     ^^^^^^^^ feature has been removed
    |
    = note: split into finer-grained feature gates

error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
  --> /tmp/portage/dev-lang/spidermonkey-78.10.1/work/firefox-78.10.1/third_party/rust/packed_simd/src/codegen/llvm.rs:43:7
   |
43 |     #[rustc_args_required_const(2)]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^

error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
  --> /tmp/portage/dev-lang/spidermonkey-78.10.1/work/firefox-78.10.1/third_party/rust/packed_simd/src/codegen/llvm.rs:37:7
   |
37 |     #[rustc_args_required_const(2)]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^

error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
  --> /tmp/portage/dev-lang/spidermonkey-78.10.1/work/firefox-78.10.1/third_party/rust/packed_simd/src/codegen/llvm.rs:31:7
   |
31 |     #[rustc_args_required_const(2)]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^

error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
  --> /tmp/portage/dev-lang/spidermonkey-78.10.1/work/firefox-78.10.1/third_party/rust/packed_simd/src/codegen/llvm.rs:25:7
   |
25 |     #[rustc_args_required_const(2)]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^

error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
  --> /tmp/portage/dev-lang/spidermonkey-78.10.1/work/firefox-78.10.1/third_party/rust/packed_simd/src/codegen/llvm.rs:19:7
   |
19 |     #[rustc_args_required_const(2)]
Comment 3 Oleg 2021-06-02 19:27:13 UTC
Compiles with ruts-1.51
Comment 4 Marco Scardovi (scardracs) 2021-06-02 19:30:15 UTC
(In reply to Oleg from comment #3)
> Compiles with ruts-1.51

I use rust-bin because compiling it with a PinePhone would probably kill it forever
Comment 5 Marco Scardovi (scardracs) 2021-06-09 21:22:45 UTC
ping: News about that bug?
Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev 2021-06-09 22:29:07 UTC
I cannot help you. Not reproducible for amd64 or x86.
packed_simd upstream (Mozilla) hasn't been touched since bug 756334.

Try to build just https://github.com/hsivonen/packed_simd/archive/0917fe780032a6bbb23d71be545f9c1834128d75.tar.gz which should fail (=that's the version spidermonkey uses).

Now try to build latest https://github.com/rust-lang/packed_simd to see if a newer version works for you.
Comment 7 Marco Scardovi (scardracs) 2021-06-09 22:30:46 UTC
(In reply to Thomas Deutschmann from comment #6)
> I cannot help you. Not reproducible for amd64 or x86.
> packed_simd upstream (Mozilla) hasn't been touched since bug 756334.
> 
> Try to build just
> https://github.com/hsivonen/packed_simd/archive/
> 0917fe780032a6bbb23d71be545f9c1834128d75.tar.gz which should fail (=that's
> the version spidermonkey uses).
> 
> Now try to build latest https://github.com/rust-lang/packed_simd to see if a
> newer version works for you.

Seems the problem is only on arm/64 arches. I will try with PinePhone tomorrow and report back
Comment 8 tt_1 2021-06-27 18:32:51 UTC
I can try to reproduce on my arm64, but I need emerge -pv spidermonkey from you, and possibly emerge --info spidermonkey

which is your active version of gcc?
Comment 9 Marco Scardovi (scardracs) 2021-06-27 18:42:04 UTC
(In reply to tt_1 from comment #8)
> I can try to reproduce on my arm64, but I need emerge -pv spidermonkey from
> you, and possibly emerge --info spidermonkey
> 
> which is your active version of gcc?

GCC 11.1... sorry but actually my OS is broken so i can't retry it
Comment 10 tt_1 2021-07-09 06:21:47 UTC
this happens because rustc_args_required_const was removed in rust-1.54, upstream pullrequst is here: https://github.com/rust-lang/rust/pull/85110

mozilla bug with request to update rust_simd package: https://bugzilla.mozilla.org/show_bug.cgi?id=1719674

firefox + firefox-esr also affected
Comment 11 tt_1 2021-07-10 06:16:42 UTC
backported patch for firefox-esr and spidermonkey:78

https://bugzilla.mozilla.org/show_bug.cgi?id=1719674#c11

seems its not going to be backported, so maybe the mozilla team wants to add this to the patchset when rust-1.54.0 is released and added to the tree. 

same for not yet released firefox-90.0:  https://bugzilla.mozilla.org/show_bug.cgi?id=1719674#c13
Comment 12 Larry the Git Cow gentoo-dev 2021-07-12 23:32:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b0d441066a018f166e97f3d8b23f624d390a59e

commit 6b0d441066a018f166e97f3d8b23f624d390a59e
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-07-12 23:28:39 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-07-12 23:32:23 +0000

    dev-lang/spidermonkey: bump to v78.12.0
    
    Closes: https://bugs.gentoo.org/793920
    Package-Manager: Portage-3.0.21, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-lang/spidermonkey/Manifest                    |   2 +
 dev-lang/spidermonkey/spidermonkey-78.12.0.ebuild | 454 ++++++++++++++++++++++
 2 files changed, 456 insertions(+)
Comment 13 tt_1 2021-07-15 20:41:56 UTC
@mozilla team: the fix was *not* backported to new esr-91 branch, if you're not happy about it please comment on the upstream bug to maybe convince them.