Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 793839 - sci-libs/vtk-8.2.0-r1[all-modules] - Could NOT find GDAL (missing: GDAL_LIBRARY GDAL_INCLUDE_DIR)
Summary: sci-libs/vtk-8.2.0-r1[all-modules] - Could NOT find GDAL (missing: GDAL_LIBRA...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernd
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-06-02 07:21 UTC by Cecil Curry
Modified: 2021-06-10 03:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
"emerge --info" output (emerge.info,22.43 KB, text/plain)
2021-06-02 07:21 UTC, Cecil Curry
Details
"emerge vtk" log (build.log.gz,7.17 KB, application/gzip)
2021-06-02 07:23 UTC, Cecil Curry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cecil Curry 2021-06-02 07:21:55 UTC
Created attachment 713229 [details]
"emerge --info" output

sci-libs/vtk-8.2.0-r1 fails to emerge with a fatal error during the src_configure() phase when the "gdal" USE flag is disabled and when sci-libs/gdal is not installed on the current system. The CMake error suggests that our VTK ebuild no longer properly disables GDAL discovery when the "gdal" USE flag is disabled:

    CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
      Could NOT find GDAL (missing: GDAL_LIBRARY GDAL_INCLUDE_DIR) (found version
      "GDAL_VERSION-NOTFOUND")
    Call Stack (most recent call first):
      /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
      /usr/share/cmake/Modules/FindGDAL.cmake:153 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
      IO/GDAL/CMakeLists.txt:1 (find_package)

See the attached logfile for voluminous details. Thanks for all the continued hard work, fellow Gentoo data scientists!
Comment 1 Cecil Curry 2021-06-02 07:23:38 UTC
Created attachment 713232 [details]
"emerge vtk" log
Comment 2 Bernd 2021-06-02 15:55:57 UTC
Looks like this is tied to the USE=all-modules flag. I built this version successfully today, while checking to add python-3.9 support with only USE="X python" and this issue didn't show up.

Could you, for the future, please consider attaching log files uncompressed if their size is small enough? This would ease the inspection of those files in the browser. Thanks you :)
Comment 3 Cecil Curry 2021-06-03 03:11:53 UTC
> Looks like this is tied to the USE=all-modules flag.

Yup! You nailed it. I brute-forced through the above error by just installing GDAL. Of course, I then got upper-cut by yet another fatal src_configure() error that smelled strongly of "all-modules":

    CMake Error at CMake/vtkModuleMacros.cmake:891 (find_package):
      By not providing "FindKISSFFT.cmake" in CMAKE_MODULE_PATH this project has
      asked CMake to find a package configuration file provided by "KISSFFT", but
      CMake did not find one.
    
      Could not find a package configuration file provided by "KISSFFT" with any
      of the following names:
    
        KISSFFTConfig.cmake
        kissfft-config.cmake
    
      Add the installation prefix of "KISSFFT" to CMAKE_PREFIX_PATH or set
      "KISSFFT_DIR" to a directory containing one of the above files.  If
      "KISSFFT" provides a separate development package or SDK, be sure it has
      been installed.
    Call Stack (most recent call first):
      ThirdParty/kissfft/CMakeLists.txt:1 (vtk_module_third_party)
    
    
    -- Configuring incomplete, errors occurred!

The "vtk_module_third_party" identifier was the dead giveaway. To no one's surprise, disabling "all-modules" fixed everything.

> Could you, for the future, please consider attaching log files uncompressed if their size is small enough?

Absolutely! I didn't think hard enough about that and just attached the log compressed. I'll get this right next time. Well, hopefully there won't be a next time... but, we know there will. *sigh*
Comment 4 Bernd 2021-06-03 06:46:13 UTC
(In reply to Cecil Curry from comment #3)
> > Looks like this is tied to the USE=all-modules flag.
> 
> Yup! You nailed it. I brute-forced through the above error by just
> installing GDAL. Of course, I then got upper-cut by yet another fatal
> src_configure() error that smelled strongly of "all-modules":
> 
>     CMake Error at CMake/vtkModuleMacros.cmake:891 (find_package):
>       By not providing "FindKISSFFT.cmake" in CMAKE_MODULE_PATH this project
> has

There's already a bug for this one (bug #754684). However, there's more to this than just these two. If Qt isn't installed, this will throw an error before the gdal error pops up. Also database support (postgres, mysql, odbc) is needed as well.
I'm just compiling with an updated ebuild, which will eventually fix some of the all-modules-related issues.
Comment 5 Larry the Git Cow gentoo-dev 2021-06-10 03:37:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2728a6a5f2c0a39f44ceee464a764bec6da2c320

commit 2728a6a5f2c0a39f44ceee464a764bec6da2c320
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2021-06-03 16:52:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-10 03:37:44 +0000

    sci-libs/vtk: improve all-modules USE flag
    
    - add missing flags to REQUIRED_USE
    - add new mysql USE flag - needed by all-modules, adds new dependency on
            dev-db/mysql-connector-c. Dev-db/mariadb-connector-c isn't supported
            by this version. Fix an issue with using of deprecated my_bool when
            using mysql-connector-c.
    - remove xdmf2 USE flag, block sci-libs/xdmf2 with all-modules:
            sci-libs/xdmf2 doesn't ship any cmake configuration files, which leads
            to configuration errors when trying to build against external xdmf2
    - block sci-libs/xdmf2: when built against internal xdmf2, there are header
            file collisions with the header files installed by sci-libs/xdmf2
    - add dependency on sci-libs/kissfft, bug #754684) and drop bundled
    - fix an issue with xdmf3 library being installed in both library locations,
            lib and lib64
    - fix QA issues with RPATH
    - byte compile python files
    - disable searching for zfp (no package in tree)
    - addresses some QA issues with defined but unused cmake variables: fixing all
            of them would need a thorough testing of each single USE flag and checking
            where these belong to, in this over-complex build system (bug #660582)
    
    Closes: https://bugs.gentoo.org/793839
    Closes: https://bugs.gentoo.org/754684
    Closes: https://bugs.gentoo.org/646846
    Bug: https://bugs.gentoo.org/660582
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 ...01-fix-library-installation-dir-for-xdmf3.patch |  57 +++
 sci-libs/vtk/vtk-8.2.0-r2.ebuild                   | 382 +++++++++++++++++++++
 2 files changed, 439 insertions(+)