Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 793683 - dev-lang/spidermonkey-78.11.0: fails to compile on Python3.10
Summary: dev-lang/spidermonkey-78.11.0: fails to compile on Python3.10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 793974 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-06-01 09:02 UTC by Marco Scardovi (scardracs)
Modified: 2021-06-02 23:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge --info,6.63 KB, text/plain)
2021-06-01 09:02 UTC, Marco Scardovi (scardracs)
Details
emerge --log (emerge --log,12.88 KB, application/octet-stream)
2021-06-01 09:03 UTC, Marco Scardovi (scardracs)
Details
le noob patch (attribute_error.patch,2.56 KB, patch)
2021-06-01 18:34 UTC, Adjudicator Darren
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Scardovi (scardracs) 2021-06-01 09:02:32 UTC
Created attachment 713112 [details]
emerge --info

Possible context of error: AttributeError: module 'collections' has no attribute 'Sequence'
Comment 1 Marco Scardovi (scardracs) 2021-06-01 09:03:17 UTC
Created attachment 713115 [details]
emerge --log
Comment 2 Adjudicator Darren 2021-06-01 16:42:44 UTC
ergo had to mask it, and the fallback version dev-lang/spidermonkey-78.10.1::gentoo worked.
Comment 3 Marco Scardovi (scardracs) 2021-06-01 17:11:14 UTC
(In reply to Adjudicator Darren from comment #2)
> ergo had to mask it, and the fallback version
> dev-lang/spidermonkey-78.10.1::gentoo worked.

Well, that's not a solution if we want to fix the bug
Comment 4 Adjudicator Darren 2021-06-01 17:52:59 UTC
(In reply to Marco Scardovi from comment #3)
> (In reply to Adjudicator Darren from comment #2)
> > ergo had to mask it, and the fallback version
> > dev-lang/spidermonkey-78.10.1::gentoo worked.
> 
> Well, that's not a solution if we want to fix the bug

sorry, I didn't mean to imply that was in any way a fix, but more like adding the info that if masked then the prev. version of spidermonkey worked. 

On second look it's because of python 3.10 not being used for the fallback (ie. change the 10 into 9 in line PYTHON_COMPAT=( python3_{7..10} ) of spidermonkey-78.11.0.ebuild" and it works the same as the fallback 78.10.1 which already has the 7..9 range)

Now, a fix would probably be something like https://github.com/nose-devs/nose2/commit/fba2ebfb6e794b12e15810818afd189f5a043097

heck, I might even try it...
Comment 5 Adjudicator Darren 2021-06-01 18:10:13 UTC
(In reply to Adjudicator Darren from comment #4)
> Now, a fix would probably be something like
> https://github.com/nose-devs/nose2/commit/
> fba2ebfb6e794b12e15810818afd189f5a043097
> 
> heck, I might even try it...


well Ok, it's not that simple, I'll leave it to the experts :D a quick fix would then be to limit to 3.9 python in ebuild.
Comment 6 Adjudicator Darren 2021-06-01 18:19:51 UTC
actually I can do it, I just thought that there are a ton more places where the `import collections` had to be replaced by `import collections.abc`
but it's only a handful of places
for those ABCs in https://docs.python.org/3.9/library/collections.abc.html#collections-abstract-base-classes

patch soon, just to show you where.
Comment 7 Adjudicator Darren 2021-06-01 18:34:43 UTC
Created attachment 713193 [details, diff]
le noob patch

noobish patch to show what needed to be changed to make it work with python 3.10 (for me)
Comment 8 Larry the Git Cow gentoo-dev 2021-06-01 19:04:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f113130772cdc6778b1f0246b1f39fa9ef3d120b

commit f113130772cdc6778b1f0246b1f39fa9ef3d120b
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-06-01 19:03:29 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-06-01 19:03:29 +0000

    dev-lang/spidermonkey: drop Python 3.10 support
    
    Closes: https://bugs.gentoo.org/793683
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-lang/spidermonkey/spidermonkey-78.11.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab234dbe0d77c590c346da156df8cf473d17703a

commit ab234dbe0d77c590c346da156df8cf473d17703a
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-06-01 19:03:45 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-06-01 19:04:07 +0000

    Revert "www-client/firefox: allow Python 3.10"
    
    This reverts commit 736f264969ebe128ae8b1d7b6d1dcd58e2e4dfc0.
    
    Bug: https://bugs.gentoo.org/793683
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-78.11.0.ebuild | 2 +-
 www-client/firefox/firefox-89.0.ebuild    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 9 Marco Scardovi (scardracs) 2021-06-01 19:15:15 UTC
(In reply to Larry the Git Cow from comment #8)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=f113130772cdc6778b1f0246b1f39fa9ef3d120b
> 
> commit f113130772cdc6778b1f0246b1f39fa9ef3d120b
> Author:     Thomas Deutschmann <whissi@gentoo.org>
> AuthorDate: 2021-06-01 19:03:29 +0000
> Commit:     Thomas Deutschmann <whissi@gentoo.org>
> CommitDate: 2021-06-01 19:03:29 +0000
> 
>     dev-lang/spidermonkey: drop Python 3.10 support
>     
>     Closes: https://bugs.gentoo.org/793683
>     Package-Manager: Portage-3.0.19, Repoman-3.0.3
>     Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
> 
>  dev-lang/spidermonkey/spidermonkey-78.11.0.ebuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Additionally, it has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=ab234dbe0d77c590c346da156df8cf473d17703a
> 
> commit ab234dbe0d77c590c346da156df8cf473d17703a
> Author:     Thomas Deutschmann <whissi@gentoo.org>
> AuthorDate: 2021-06-01 19:03:45 +0000
> Commit:     Thomas Deutschmann <whissi@gentoo.org>
> CommitDate: 2021-06-01 19:04:07 +0000
> 
>     Revert "www-client/firefox: allow Python 3.10"
>     
>     This reverts commit 736f264969ebe128ae8b1d7b6d1dcd58e2e4dfc0.
>     
>     Bug: https://bugs.gentoo.org/793683
>     Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
> 
>  www-client/firefox/firefox-78.11.0.ebuild | 2 +-
>  www-client/firefox/firefox-89.0.ebuild    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

I don't think just dropping python3.10 is a solution to set it as solved
Comment 10 Adjudicator Darren 2021-06-01 22:29:27 UTC
(In reply to Marco Scardovi from comment #9)

> 
> I don't think just dropping python3.10 is a solution to set it as solved

It's probably because the changes required to fix this ought to be done upstream by mozilla people, instead of gentoo.

>     Revert "www-client/firefox: allow Python 3.10"

had no idea firefox was also hit by this because I didn't have it emerged, but can confirm that it is now, and there are possibly about 856 places that would need to be changed about this...

couldn't find an upstream bug on mozilla's site that would handle this, but perhaps my searches aren't that good.

found something only mildly related that's not even worth mentioning: https://bugzilla.mozilla.org/show_bug.cgi?id=1628641

Guess we're stuck with python 3.9 until mozilla decides to make a ton of changes for 3.10
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-06-02 23:42:33 UTC
*** Bug 793974 has been marked as a duplicate of this bug. ***