Bug 793173 – media-libs/zxing-cpp-1.2.0: cmake fails configuring tests due to upstream's use of FetchContent.cmake module

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2021-05-31 08:31:55 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/zxing-cpp-1.2.0 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
If you think this is a GCC-11 related issue, please block bug 732706.

[Comment 1 Agostino Sarubbo 2021-05-31 08:31:58 UTC]

Created attachment 712704 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2021-05-31 08:31:59 UTC]

Created attachment 712707 [details]
1-CMakeError.log

1-CMakeError.log

[Comment 3 Agostino Sarubbo 2021-05-31 08:32:01 UTC]

Created attachment 712710 [details]
1-CMakeOutput.log

1-CMakeOutput.log

[Comment 4 Agostino Sarubbo 2021-05-31 08:32:02 UTC]

Created attachment 712713 [details]
2-CMakeOutput.log

2-CMakeOutput.log

[Comment 5 Larry the Git Cow 2021-06-24 09:07:07 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b8488497cc29da9301c84812f504d813f816bff

commit 2b8488497cc29da9301c84812f504d813f816bff
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2021-06-24 09:06:31 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2021-06-24 09:06:31 +0000

    media-libs/zxing-cpp: Drop tests due to upstream use of FetchContent
    
    Upstream commits:
    fad045ff2e53e2a69f7b091cfe77e8bea31222b6
    c0c3e0b306d78efae9f0af02e3cc20126ff8ebe4
    
    Closes: https://bugs.gentoo.org/793173
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 media-libs/zxing-cpp/zxing-cpp-1.2.0.ebuild | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

[Comment 6 Larry the Git Cow 2025-02-17 20:18:55 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5c62bd26e15d585d1516010cdbde0d809fd5ae8

commit d5c62bd26e15d585d1516010cdbde0d809fd5ae8
Author:     Sam James <[e-mail]>
AuthorDate: 2025-02-17 20:10:43 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-02-17 20:18:24 +0000

    media-libs/zxing-cpp: wire up tests
    
    Fortunately, the situation has improved since bug #793173. Wire up the tests
    accordingly.
    
    Note that upstream do say that the unit tests option "shouldn't be used
    in production builds". My assumption is that this is because of it setting
    ZXING_BUILD_FOR_TEST, but when looking at use of that, I can't see anything
    harmful.
    
    Bug: https://bugs.gentoo.org/793173
    Signed-off-by: Sam James <[e-mail]>

 media-libs/zxing-cpp/Manifest                  |  1 +
 media-libs/zxing-cpp/zxing-cpp-2.2.1-r1.ebuild | 48 ++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)