Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 792423 - app-editors/vscode: keyword request for arm & arm64
Summary: app-editors/vscode: keyword request for arm & arm64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Adel KARA SLIMANE
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2021-05-27 07:33 UTC by Joonas Niilola
Modified: 2021-06-01 08:43 UTC (History)
1 user (show)

See Also:
Package list:
app-editors/vscode ~arm ~arm64
Runtime testing required: Yes


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2021-05-27 07:33:11 UTC
Hey, 

please keyword app-editors/vscode for ~arm and ~arm64. It is currently profile-arch-masked for these architechtures, which should be automatically handled by tatt to my knowledge.
Comment 1 Joonas Niilola gentoo-dev 2021-05-27 07:33:38 UTC
Runtime testing preferred, as it's a binary package which doesn't compile anything.
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2021-06-01 08:25:37 UTC
The package was added with ~arm/~arm64 keywords from day 1:

  +++ b/app-editors/vscode/vscode-1.56.2.ebuild
  @@ -0,0 +1,105 @@
  ...
  +KEYWORDS="-* ~amd64 ~arm ~arm64"

Consider dropping keywords to make it keywords-processed as usual.
Comment 3 Joonas Niilola gentoo-dev 2021-06-01 08:34:34 UTC
^ Hey, 

I'm pretty sure my previous attempt at defining arch-dependent stuff in an ebuild ended up in some pkgcheck/repoman error without the KEYWORDS, but I tried it now and it seems to pass. Thanks, I'll remember this in the future!

As for what it comes to keywording, I don't think there's much to do here anyway. They're binaries provided by upstream. I'm just going to unmask the relevant parts under profiles.
Comment 4 Larry the Git Cow gentoo-dev 2021-06-01 08:43:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=160ecefb72d45be2654d57189a49d752a568ed70

commit 160ecefb72d45be2654d57189a49d752a568ed70
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2021-06-01 08:42:44 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-06-01 08:43:15 +0000

    profiles/arch/arm64: unmask app-editors/vscode
    
    Closes: https://bugs.gentoo.org/792423
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/arch/arm64/package.mask | 5 -----
 1 file changed, 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b185a25ca2dc56068b656dda69467d024940be0

commit 9b185a25ca2dc56068b656dda69467d024940be0
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2021-06-01 08:42:12 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-06-01 08:43:14 +0000

    profiles/arch/arm: unmask app-editors/vscode
    
    Bug: https://bugs.gentoo.org/792423
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/arch/arm/package.mask | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)