Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 792234 - net-misc/curl-7.77.0 - /.../quiche.c: error: too many arguments to function quiche_connect
Summary: net-misc/curl-7.77.0 - /.../quiche.c: error: too many arguments to function q...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matt Jolly
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-05-26 11:28 UTC by Toralf Förster
Modified: 2023-02-16 05:08 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,18.04 KB, text/plain)
2021-05-26 11:29 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,317.79 KB, text/plain)
2021-05-26 11:29 UTC, Toralf Förster
Details
environment (environment,97.73 KB, text/plain)
2021-05-26 11:29 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,24.57 KB, application/x-bzip)
2021-05-26 11:29 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,35.52 KB, application/x-bzip)
2021-05-26 11:29 UTC, Toralf Förster
Details
net-misc:curl-7.77.0:20210526-110305.log (net-misc:curl-7.77.0:20210526-110305.log,342.18 KB, text/plain)
2021-05-26 11:29 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,39.12 KB, application/x-bzip)
2021-05-26 11:29 UTC, Toralf Förster
Details
emerge-info.txt (emerge-info.txt,17.79 KB, text/plain)
2022-06-28 06:41 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,18.39 KB, text/plain)
2022-06-28 06:41 UTC, Toralf Förster
Details
environment (environment,104.05 KB, text/plain)
2022-06-28 06:41 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,25.36 KB, application/x-bzip)
2022-06-28 06:42 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,14.36 KB, application/x-bzip)
2022-06-28 06:42 UTC, Toralf Förster
Details
net-misc:curl-7.83.1:20220627-194727.log (net-misc:curl-7.83.1:20220627-194727.log,18.89 KB, text/plain)
2022-06-28 06:42 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,30.59 KB, application/x-bzip)
2022-06-28 06:42 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-05-26 11:28:59 UTC
  223 |                             size_t scid_len, quiche_config *config);
      |                                              ~~~~~~~~~~~~~~~^~~~~~
/var/tmp/portage/net-misc/curl-7.77.0/work/curl-7.77.0/lib/vquic/quiche.c:228:14: error: too many arguments to function ‘quiche_connect’
  228 |   qs->conn = quiche_connect(conn->host.name, (const uint8_t *) qs->scid,
      |              ^~~~~~~~~~~~~~
In file included from /var/tmp/portage/net-misc/curl-7.77.0/work/curl-7.77.0/lib/vquic/quiche.c:26:
/usr/include/quiche.h:222:14: note: declared here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_hardened-j2-20210521-114951

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.1.0 *
clang version 12.0.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/12/bin
/usr/lib/llvm/12
12.0.0
Python 3.8.10
Available Ruby profiles:
  (none found)
Available Rust versions:
  [1]   rust-bin-1.52.1 *
The following VMs are available for generation-2:
1)	JamVM JDK 2.0.0 [jamvm]
*)	AdoptOpenJDK 8.292_p10 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   jamvm 
  [2]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Wed May 26 10:50:12 UTC 2021

emerge -qpvO net-misc/curl
[ebuild     U ] net-misc/curl-7.77.0 [7.76.1] USE="ftp http2 imap ipv6 openssl pop3 progress-meter quiche smtp ssl tftp -adns -alt-svc -brotli -gnutls -gopher -hsts -idn -kerberos -ldap -mbedtls -metalink (-nghttp3) -nss -rtmp -samba -ssh -sslv3 -static-libs -telnet -test -threads (-winssl) -zstd" ABI_X86="(64) -32 (-x32)" CURL_SSL="openssl -gnutls -mbedtls -nss (-winssl)"
Comment 1 Toralf Förster gentoo-dev 2021-05-26 11:29:01 UTC
Created attachment 711363 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-05-26 11:29:02 UTC
Created attachment 711366 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-05-26 11:29:04 UTC
Created attachment 711369 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-05-26 11:29:05 UTC
Created attachment 711372 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-05-26 11:29:06 UTC
Created attachment 711375 [details]
logs.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2021-05-26 11:29:08 UTC
Created attachment 711378 [details]
net-misc:curl-7.77.0:20210526-110305.log
Comment 7 Toralf Förster gentoo-dev 2021-05-26 11:29:09 UTC
Created attachment 711381 [details]
temp.tar.bz2
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-26 13:21:01 UTC
[12:45:28]  <sam_> huh
[12:45:34]  <sam_> someone reported this downstream iin Gentoo: https://bugs.gentoo.org/792234
[12:45:41]  <sam_> does curl need a certain version of quiche?
[12:45:48]  <sam_> the reporter is using 0.8.1
[12:47:02]  <sam_> I see https://github.com/curl/curl/commit/424aa64d54fd2c4baf69aa0c09bf5db347ff59f0 made it into 7.77.0..
[13:20:51]  <@bagder> sam_: we basically only work with quiche master
[13:21:10]  <sam_> oh bugger
[13:22:49]  <sam_> thanks for letting me know bagder, it's not really critical here, we provide the optioon but I suspect not many use it
Comment 9 Craig Andrews gentoo-dev 2021-05-26 19:22:59 UTC
Reported upstream at https://github.com/cloudflare/quiche/issues/946
Comment 10 Larry the Git Cow gentoo-dev 2021-06-08 14:05:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89eaaf950d091325fbcb1c7b006d4962fc7e2e8a

commit 89eaaf950d091325fbcb1c7b006d4962fc7e2e8a
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2021-06-08 14:04:12 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2021-06-08 14:05:37 +0000

    net-libs/quiche: 0.9.0 version bump
    
    Bug: https://bugs.gentoo.org/792234
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 net-libs/quiche/Manifest            |  29 +++++
 net-libs/quiche/quiche-0.9.0.ebuild | 219 ++++++++++++++++++++++++++++++++++++
 net-libs/quiche/quiche-9999.ebuild  |  56 ++++-----
 3 files changed, 276 insertions(+), 28 deletions(-)
Comment 11 Craig Andrews gentoo-dev 2021-06-08 14:10:24 UTC
net-libs/quiche-0.9.0 is now in portage and net-misc/curl-7.77.0[quiche] builds successfully with it.

I think the net-misc/curl-7.77.0 rebuild should be changed to depend on >=net-libs/quiche-0.9.0.
Comment 12 Toralf Förster gentoo-dev 2022-06-28 06:41:55 UTC
it still breaks
Comment 13 Toralf Förster gentoo-dev 2022-06-28 06:41:56 UTC
Created attachment 788219 [details]
emerge-info.txt
Comment 14 Toralf Förster gentoo-dev 2022-06-28 06:41:57 UTC
Created attachment 788222 [details]
emerge-history.txt
Comment 15 Toralf Förster gentoo-dev 2022-06-28 06:41:58 UTC
Created attachment 788228 [details]
environment
Comment 16 Toralf Förster gentoo-dev 2022-06-28 06:42:00 UTC
Created attachment 788231 [details]
etc.portage.tar.bz2
Comment 17 Toralf Förster gentoo-dev 2022-06-28 06:42:01 UTC
Created attachment 788234 [details]
logs.tar.bz2
Comment 18 Toralf Förster gentoo-dev 2022-06-28 06:42:02 UTC
Created attachment 788237 [details]
net-misc:curl-7.83.1:20220627-194727.log
Comment 19 Toralf Förster gentoo-dev 2022-06-28 06:42:03 UTC
Created attachment 788240 [details]
temp.tar.bz2
Comment 20 Larry the Git Cow gentoo-dev 2023-02-16 05:08:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c6ec8d4579f9fbb2b3fbfb93de2abb7893cb42f

commit 1c6ec8d4579f9fbb2b3fbfb93de2abb7893cb42f
Author:     Matt Jolly <Matt.Jolly@footclan.ninja>
AuthorDate: 2023-02-09 23:37:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-16 05:08:27 +0000

    net-misc/curl: add 7.88.0
    
    drop ipv6 and quiche USE
    
    Using quiche requires building cURL with the same SSL flavour
    as the quiche library (i.e. BoringSSL). This is currently
    unsupported on Gentoo.
    
    Drop `ipv6` USE; it doesn't require additional deps and `--ipv4`
    can be used at runtime to force connectivity in dual-stack configurations.
    
    Closes: https://bugs.gentoo.org/881711
    Closes: https://bugs.gentoo.org/792234
    Closes: https://bugs.gentoo.org/847451
    Closes: https://bugs.gentoo.org/867985
    Closes: https://bugs.gentoo.org/835851
    
    Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
    Closes: https://github.com/gentoo/gentoo/pull/29511
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/curl/Manifest                             |   2 +
 net-misc/curl/curl-7.88.0.ebuild                   | 298 +++++++++++++++++++++
 .../files/curl-7.88.0-test-gnuserv-tls-srp.patch   |  39 +++
 .../curl-7.88.0-test-uninitialised-value.patch     |  30 +++
 4 files changed, 369 insertions(+)