Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 791910 - app-admin/logrotate-3.18.1 errors on "size=+NNN" from rsync and other packages
Summary: app-admin/logrotate-3.18.1 errors on "size=+NNN" from rsync and other packages
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://www.linuxquestions.org/questi...
Whiteboard:
Keywords:
: 791913 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-25 07:43 UTC by Hank Leininger
Modified: 2021-05-25 08:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Leininger 2021-05-25 07:43:10 UTC
New sanity checks of key value pairs in logrotate config files were added here:

https://github.com/logrotate/logrotate/commit/2b588b5ec2e5c27bee857c4abeddafa6a9602ebc

And this was included in the 3.18.1 release.

Trouble is that breaks on existing logrotate files provided by other packages such as rsyncd:

# egrep size /etc/logrotate.d/rsyncd 
        size=+1024k

That produces:

rsyncd:5 keyword 'size' not properly separated, found 0x3d

That file is provided by the rsync package and has not changed since at least 2015, but only began causing errors with logrotate-3.18.1.

Slackware folks encountered this a couple days ago; forum post linked at $URL.

There are a few other packages that provide logrotate config files with similar, now-incorrect syntax; at a glance:

$ find . -type f -iname \*logrotate\* -print0 | xargs -0 egrep 'size *= *\+'
./net-misc/rsync/files/rsyncd.logrotate:        size=+1024k
./www-misc/xxv/files/xxvd-logrotate:    size=+4096k
./www-misc/xxv/files/xxvd-logrotate:    size=+4096k
./dev-util/jenkins-bin/files/jenkins-bin-r1.logrotate:    size=+4096k
./dev-db/firebird/files/firebird.logrotate:     size=+1024k

Probably each of those packages needs a bug created about this, unless logrotate is patched (by upstream or by us) to accept the =+ syntax.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-25 07:46:44 UTC
*** Bug 791913 has been marked as a duplicate of this bug. ***
Comment 2 Larry the Git Cow gentoo-dev 2021-05-25 08:28:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=862d8edad5c4307c3233c432b2f2d3a9434254fa

commit 862d8edad5c4307c3233c432b2f2d3a9434254fa
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-05-25 08:27:46 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-05-25 08:28:38 +0000

    net-misc/rsync: Revbump for logrotate file syntax fix
    
    Thanks-to: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/791910
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-misc/rsync/files/rsyncd.logrotate                           | 2 +-
 net-misc/rsync/{rsync-3.2.3-r3.ebuild => rsync-3.2.3-r4.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)