Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 791460 - net-misc/rdesktop-1.9.0-r1[kerberos]: CredSSP support requires GSSAPI, install the dependency or disable the feature using --disable-credssp.
Summary: net-misc/rdesktop-1.9.0-r1[kerberos]: CredSSP support requires GSSAPI, instal...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-05-22 12:15 UTC by Andrew Savchenko
Modified: 2021-06-14 10:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.gz (rdesktop-1.9.0-r1:20210522-052159.log.gz,2.01 KB, application/gzip)
2021-05-22 12:15 UTC, Andrew Savchenko
Details
emerge --info (emerge.info,12.81 KB, text/plain)
2021-05-22 12:15 UTC, Andrew Savchenko
Details
rdesktop-1.9.0-gssapi-check.patch (rdesktop-1.9.0-gssapi-check.patch,332 bytes, patch)
2021-05-22 12:17 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2021-05-22 12:15:13 UTC
Created attachment 710247 [details]
build.log.gz

Hi!

With app-crypt/mit-krb5-1.19.1 rdesktop-1.9.0-r1 fails to find it:

checking pkg-config is at least version 0.9.0... yes

CredSSP support requires GSSAPI, install the dependency
or disable the feature using --disable-credssp.

This happens because in case of empty $OSTYPE and non-freebsd host the check does *nothing*, see configure.ac:

 70 AS_IF([test "x$enable_credssp" != "xno"], [
 71     case "$OSTYPE" in
 72          darwin*)
 73         AC_CHECK_HEADER(Kerberos/gssapi_krb5.h, [WITH_CREDSSP=1], [WITH_CREDSSP=0])
 74         GSSAPI_CFLAGS=""
 75         GSSAPI_LIBS="-framework Kerberos"
 76         ;;
 77          *)
 78         #if 'OSTYPE' is not set use 'host' instead
 79         if test x"$OSTYPE" = "x"; then
 80             case "$host" in
 81                 *-*-freebsd*)
 82                 if test -n "$PKG_CONFIG"; then
 83                     PKG_CHECK_MODULES(GSSAPI, gss, [WITH_CREDSSP=1], [WITH_CREDSSP=0])
 84                 fi
 85                 ;;
 86             *)
 87                 ;;
 88             esac
 89         else
 90             if test -n "$PKG_CONFIG"; then
 91                 PKG_CHECK_MODULES(GSSAPI, krb5-gssapi, [WITH_CREDSSP=1], [WITH_CREDSSP=0])
 92             fi
 93         fi
 94         ;;
 95     esac

So if one falls at lines 86-87, no check is performed. This is exactly my case. Attached patch fixes this.
Comment 1 Andrew Savchenko gentoo-dev 2021-05-22 12:15:47 UTC
Created attachment 710250 [details]
emerge --info
Comment 2 Andrew Savchenko gentoo-dev 2021-05-22 12:17:45 UTC
Created attachment 710253 [details, diff]
rdesktop-1.9.0-gssapi-check.patch

Signed-off-by: Andrew Savchenko <bircoph@gentoo.org>
Comment 3 Andrew Savchenko gentoo-dev 2021-06-05 20:13:53 UTC
Ping.

Ok to apply proposed patch?
Comment 4 Bernard Cafarelli gentoo-dev 2021-06-08 20:09:14 UTC
So sorry, I thought I had commented with a ack here!

Definitely go ahead and feel free to apply it (or I will push it in a few days)
Comment 5 Larry the Git Cow gentoo-dev 2021-06-14 10:39:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22a231dabf0ace29c93d901f084227f98fa2fb30

commit 22a231dabf0ace29c93d901f084227f98fa2fb30
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2021-06-14 10:39:18 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2021-06-14 10:39:25 +0000

    net-misc/rdesktop: fix gss-api check, thanks bircoph
    
    Closes: https://bugs.gentoo.org/791460
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../files/rdesktop-1.9.0-gssapi-check.patch        | 12 ++++
 net-misc/rdesktop/rdesktop-1.9.0-r2.ebuild         | 79 ++++++++++++++++++++++
 2 files changed, 91 insertions(+)