Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 791154 - sys-apps/groff-1.22.4 src/roff/groff/pipeline.c: error: ‘sys_siglist’ undeclared (first use in this function)
Summary: sys-apps/groff-1.22.4 src/roff/groff/pipeline.c: error: ‘sys_siglist’ undecla...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: MIPS Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-20 04:11 UTC by Aaron D Borden
Modified: 2023-02-09 00:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info on the build host (amd64) (emerge-info.txt,5.24 KB, text/plain)
2021-05-20 04:11 UTC, Aaron D Borden
Details
emerge --info from the mipsel crossdev wrapper (mipsel-unknown-linux-gnu-emerge-info.txt,4.62 KB, text/plain)
2021-05-20 04:12 UTC, Aaron D Borden
Details
build log (build.log,242.22 KB, text/x-log)
2021-05-20 04:14 UTC, Aaron D Borden
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron D Borden 2021-05-20 04:11:37 UTC
Created attachment 709938 [details]
emerge --info on the build host (amd64)

I'm using crossdev to compile mipsel-unknown-linux-gnu on an amd64 build host. It looks like [sys_siglist was removed][1] in glibc 2.32 and should be replaced with strsignal in most cases.

I'm seeing this in several packages and I see several resolved bugs related to this. I can open additional bugs for the other packages where I'm seeing this but wanted to confirm the issue, first.

I don't understand why I'm seeing this in the crossdev sysroot and not on my amd64 host system. I would think it's platform independent.


[1]: https://sourceware.org/pipermail/libc-announce/2020/000029.html
Comment 1 Aaron D Borden 2021-05-20 04:12:26 UTC
Created attachment 709941 [details]
emerge --info from the mipsel crossdev wrapper
Comment 2 Aaron D Borden 2021-05-20 04:14:35 UTC
Created attachment 709944 [details]
build log
Comment 3 Aaron D Borden 2021-05-20 05:05:49 UTC
Ah, I think this is a bug in crossdev. I'm realizing that this is only failing in the crossdev environment because /usr/share/crossdev/include/site/mipsel-linux-gnu contains:

    ac_cv_have_decl_sys_siglist=${ac_cv_have_decl_sys_siglist=yes}

So glibc doesn't support sys_siglist, but the ac variable is set by crossdev indicating it is.

groff _should_ be updated to use strsignal, but in most cases the ac check is working as expected and not triggering a bug.

Am I understanding this correctly?
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-09 00:44:47 UTC
(In reply to Aaron D Borden from comment #3)
> Ah, I think this is a bug in crossdev. I'm realizing that this is only
> failing in the crossdev environment because
> /usr/share/crossdev/include/site/mipsel-linux-gnu contains:
> 
>     ac_cv_have_decl_sys_siglist=${ac_cv_have_decl_sys_siglist=yes}
> 
> So glibc doesn't support sys_siglist, but the ac variable is set by crossdev
> indicating it is.
> 
> groff _should_ be updated to use strsignal, but in most cases the ac check
> is working as expected and not triggering a bug.
> 
> Am I understanding this correctly?

This sounds plausible. Let me check.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-09 00:46:42 UTC
Spot on.
Comment 6 Larry the Git Cow gentoo-dev 2023-02-09 00:47:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=86c7a0a4149490bfb53077a1e26543130f2baca2

commit 86c7a0a4149490bfb53077a1e26543130f2baca2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-09 00:46:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-09 00:46:24 +0000

    wrappers: fix mipsel-linux-gnu cache vars for *sys_siglist
    
    sys_siglist was removed from glibc-2.32. Before now, for mipsel-linux-gnu,
    we were forcing the cache var to 'yes', rather than 'no'. I suspect this
    test would've worked correctly even without caching anyway, but it is what it
    is.
    
    Default to 'no' instead of 'yes'.
    
    See also: https://lists.openembedded.org/g/openembedded-core/topic/dunfell_patch_site_make/77178472?p=
    Closes: https://bugs.gentoo.org/791154
    Signed-off-by: Sam James <sam@gentoo.org>

 wrappers/site/mipsel-linux-gnu | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)