Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 790854 - x11-misc/dunst-9999: fails applying patch for DEFAULT_CFLAGS
Summary: x11-misc/dunst-9999: fails applying patch for DEFAULT_CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aisha Tammy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-18 20:16 UTC by Nikita Zlobin
Modified: 2021-07-16 09:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log + emerge --info.txt (build.log-emerge-info.txt,8.48 KB, text/plain)
2021-05-19 18:08 UTC, Ionen Wolkens
Details
build.log (build.log,3.60 KB, text/x-log)
2021-06-26 15:12 UTC, Kajzer
Details
emerge --info (emerge-info.txt,14.96 KB, text/plain)
2021-06-26 15:12 UTC, Kajzer
Details
Patch fixing the bug (0001-x11-misc-dunst-Use-sed-instead-of-patch-file.patch,1.11 KB, patch)
2021-07-15 11:58 UTC, Thomas Schneider
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Zlobin 2021-05-18 20:16:20 UTC
files/dunst-1.6.1-no-Os.patch fails to apply to recent code due to change in DEFAULT_CFLAGS - it got appended ${EXTRA_CFLAGS}

IMHO - there's little sence in overriding default flags if CFLAGS from env override them.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-05-19 18:08:34 UTC
Created attachment 709911 [details]
build.log + emerge --info.txt

Even if it's obvious, please still attach build.log + emerge --info for build failures next time.
Comment 2 Kajzer 2021-06-26 15:11:50 UTC
If the "PATCHES" line from the ebuild is removed , it builds fine and it works fine
Comment 3 Kajzer 2021-06-26 15:12:22 UTC
Created attachment 719433 [details]
build.log
Comment 4 Kajzer 2021-06-26 15:12:44 UTC
Created attachment 719436 [details]
emerge --info
Comment 5 Thomas Schneider 2021-07-15 11:58:15 UTC
Created attachment 723997 [details, diff]
Patch fixing the bug
Comment 6 Larry the Git Cow gentoo-dev 2021-07-16 09:51:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67223872158b0a243523fb9aacefed3233dbd4fa

commit 67223872158b0a243523fb9aacefed3233dbd4fa
Author:     Thomas Schneider <qsx@chaotikum.eu>
AuthorDate: 2021-07-15 11:56:48 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-07-16 09:51:44 +0000

    x11-misc/dunst: Use sed instead of patch file in -9999
    
    This way it won’t fail when config.mk changes upstream.
    
    Closes: https://bugs.gentoo.org/790854
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Thomas Schneider <qsx@chaotikum.eu>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 x11-misc/dunst/dunst-9999.ebuild | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)